git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"Philip Oakley" <philipoakley@iee.org>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Jiang Xin" <worldhello.net@gmail.com>,
	"Alexander Shopov" <ash@kambanaria.org>,
	"Jordi Mas" <jmas@softcatala.org>,
	"Ralf Thielow" <ralf.thielow@gmail.com>,
	"Christopher Díaz" <christopher.diaz.riv@gmail.com>,
	"Jean-Noël Avila" <jn.avila@free.fr>,
	"Marco Paolone" <marcopaolone@gmail.com>,
	"Changwoo Ryu" <cwryu@debian.org>,
	"Vasco Almeida" <vascomalmeida@sapo.pt>,
	"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
	"Peter Krefting" <peter@softwolves.pp.se>,
	"Trần Ngọc Quân" <vnwildman@gmail.com>,
	"Jacques Viviers" <jacques.viviers@gmail.com>,
	m4sk1n <m4sk1n@o2.pl>
Subject: Re: [PATCH] submodule: avoid sentence-lego in translated string
Date: Mon, 9 Oct 2017 09:47:26 -0700	[thread overview]
Message-ID: <CAGZ79ka7xo96MHaAUbkDuFjWMQaaD4j2UrRndcinAg6uzaP6Kw@mail.gmail.com> (raw)
In-Reply-To: <CAN0heSqFSiev8BeZVu3KBA5vswsbQrrOH=tYYOSs_h_eq=8-3Q@mail.gmail.com>

On Sun, Oct 8, 2017 at 9:14 PM, Martin Ågren <martin.agren@gmail.com> wrote:
> In this particular case, we could have three specific messages plus one default
> message (which at the time shouldn't ever occur). Or we have one specific
> message for the "tag"-case, which seems to have been Stefan's original
> motivation, and a generic message for the other cases.

I think the original patch is an improvement for the translations,
but I'd really want to deliver as much information to the user,
(it's an error message after all, so tell as much as possible that can
be helpful,)
which is why I would prefer to keep `typename(type)` in there.

I always assumed that translators are aware of these issues and sort of
work around this somehow, maybe like this:

  "submodule entry '%s' (%s) is not a commit. It is of type %s"

Thanks,
Stefan

  reply	other threads:[~2017-10-09 16:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-08  7:38 [L10N] Kickoff of translation for Git 2.15.0 round 1 Jiang Xin
2017-10-08  8:48 ` [PATCH] submodule: avoid sentence-lego in translated string Martin Ågren
2017-10-08  9:32   ` Philip Oakley
2017-10-08 10:26     ` Martin Ågren
2017-10-09  0:51     ` brian m. carlson
2017-10-09  1:30       ` Junio C Hamano
2017-10-09  4:14         ` Martin Ågren
2017-10-09 16:47           ` Stefan Beller [this message]
2017-10-09 21:11             ` Jean-Noël AVILA
2017-10-10  1:26               ` Junio C Hamano
2017-10-10  2:35                 ` Changwoo Ryu
2017-10-10 18:14                   ` Martin Ågren
2017-10-08 12:18 ` [PATCH] i18n: add a missing space in message Jean-Noel Avila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79ka7xo96MHaAUbkDuFjWMQaaD4j2UrRndcinAg6uzaP6Kw@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=DJm00n@mail.ru \
    --cc=ash@kambanaria.org \
    --cc=christopher.diaz.riv@gmail.com \
    --cc=cwryu@debian.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacques.viviers@gmail.com \
    --cc=jmas@softcatala.org \
    --cc=jn.avila@free.fr \
    --cc=m4sk1n@o2.pl \
    --cc=marcopaolone@gmail.com \
    --cc=martin.agren@gmail.com \
    --cc=peter@softwolves.pp.se \
    --cc=philipoakley@iee.org \
    --cc=ralf.thielow@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=vascomalmeida@sapo.pt \
    --cc=vnwildman@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).