* [ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
@ 2015-04-07 20:36 ` headius
2015-04-08 1:46 ` [ruby-core:68796] [Ruby trunk - Bug #11045] " nobu
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: headius @ 2015-04-07 20:36 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been reported by Charles Nutter.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045
* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:68796] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
2015-04-07 20:36 ` [ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior headius
@ 2015-04-08 1:46 ` nobu
2015-04-09 16:59 ` [ruby-core:68826] " headius
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: nobu @ 2015-04-08 1:46 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Nobuyoshi Nakada.
Charles Nutter wrote:
> 3. Do we really want to be testing linux-specific crypt behavior?
I don't think we want, it's just an implementation regression test.
> I propose that we just make the test skip non-alpha salt unconditionally.
Or we need a standard way to isolate this kind of tests.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52066
* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:68826] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
2015-04-07 20:36 ` [ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior headius
2015-04-08 1:46 ` [ruby-core:68796] [Ruby trunk - Bug #11045] " nobu
@ 2015-04-09 16:59 ` headius
2015-04-21 18:45 ` [ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] " headius
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: headius @ 2015-04-09 16:59 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Charles Nutter.
Nobuyoshi Nakada wrote:
> Or we need a standard way to isolate this kind of tests.
That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52089
* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
` (2 preceding siblings ...)
2015-04-09 16:59 ` [ruby-core:68826] " headius
@ 2015-04-21 18:45 ` headius
2015-04-21 18:45 ` [ruby-core:68955] [Ruby trunk - Bug #11045] " headius
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: headius @ 2015-04-21 18:45 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Charles Nutter.
Status changed from Open to Closed
Fixed by r50366.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52209
* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee:
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:68955] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
` (3 preceding siblings ...)
2015-04-21 18:45 ` [ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] " headius
@ 2015-04-21 18:45 ` headius
2015-06-30 4:20 ` [ruby-core:69806] " usa
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: headius @ 2015-04-21 18:45 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Charles Nutter.
Assignee set to Charles Nutter
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52210
* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:69806] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
` (4 preceding siblings ...)
2015-04-21 18:45 ` [ruby-core:68955] [Ruby trunk - Bug #11045] " headius
@ 2015-06-30 4:20 ` usa
2015-07-03 8:37 ` [ruby-core:69852] " usa
2015-07-03 18:55 ` [ruby-core:69859] " nagachika00
7 siblings, 0 replies; 8+ messages in thread
From: usa @ 2015-06-30 4:20 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Usaku NAKAMURA.
Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53202
* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:69852] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
` (5 preceding siblings ...)
2015-06-30 4:20 ` [ruby-core:69806] " usa
@ 2015-07-03 8:37 ` usa
2015-07-03 18:55 ` [ruby-core:69859] " nagachika00
7 siblings, 0 replies; 8+ messages in thread
From: usa @ 2015-07-03 8:37 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Usaku NAKAMURA.
Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53252
* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread* [ruby-core:69859] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
` (6 preceding siblings ...)
2015-07-03 8:37 ` [ruby-core:69852] " usa
@ 2015-07-03 18:55 ` nagachika00
7 siblings, 0 replies; 8+ messages in thread
From: nagachika00 @ 2015-07-03 18:55 UTC (permalink / raw)
To: ruby-core
Issue #11045 has been updated by Tomoyuki Chikanaga.
Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
Backported into `ruby_2_2` branch at r51130.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53264
* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread