From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id B609517DF31A for ; Wed, 22 Apr 2015 03:33:42 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id CB069B5D839 for ; Wed, 22 Apr 2015 03:45:48 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 18A7F97A826 for ; Wed, 22 Apr 2015 03:45:49 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3rWf1-bimDJo for ; Wed, 22 Apr 2015 03:45:48 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id A22A997A820 for ; Wed, 22 Apr 2015 03:45:48 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 6962095243A for ; Wed, 22 Apr 2015 03:45:46 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C6D9F12044C; Wed, 22 Apr 2015 03:45:45 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 4BDD3120432 for ; Wed, 22 Apr 2015 03:45:41 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=yuolabIvJVKdO4p4tk2SCCDTArw=; b=vhDPZa684BsBFgDgtH xilEpKXRWENbe0gqSmyk+7jZdWloXt+kqNzfkFuhswXTNP1tv6vqvaQViZT/gulA 7Z5Y0WnDtpAXQULDZR+1crAIfYDsQCv7eylwNJFS2kD4JFPqBxMpdovftaAhO+Gm mb2is19cBs2wM9HCC/7V+GPCs= Received: by filter0287p1mdw1.sendgrid.net with SMTP id filter0287p1mdw1.27051.55369AD0C 2015-04-21 18:45:37.0688946 +0000 UTC Received: from herokuapp.com (ec2-54-147-211-55.compute-1.amazonaws.com [54.147.211.55]) by ismtpd-031 (SG) with ESMTP id 14cdd4cc06d.3bf8.16ecae for ; Tue, 21 Apr 2015 18:45:37 +0000 (UTC) Date: Tue, 21 Apr 2015 18:45:36 +0000 From: headius@headius.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 43352 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11045 X-Redmine-Issue-Author: headius X-Redmine-Sender: headius X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6wFkW3ly0VyScV5QYpVs8T4jdcZ/i7mRsaP/ Hai1SFL6Why4LdDnv95/kZ1+oyukc8GTDEtIvRkx1eZ9BFmeW7KR2qAhuq0emM642kaWplv4UN6VUW LZEQJBSooHjhQJfqAWQ6z/Dt0C+2ax77LCK7 X-ML-Name: ruby-core X-Mail-Count: 68954 Subject: [ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11045 has been updated by Charles Nutter. Status changed from Open to Closed Fixed by r50366. ---------------------------------------- Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior https://bugs.ruby-lang.org/issues/11045#change-52209 * Author: Charles Nutter * Status: Closed * Priority: Normal * Assignee: * ruby -v: trunk * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb. 1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar) 2. On platforms that use glibc but don't report version, this guard won't work. 3. Do we really want to be testing linux-specific crypt behavior? I propose that we just make the test skip non-alpha salt unconditionally. -- https://bugs.ruby-lang.org/