From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 7F5EB17D59A6 for ; Wed, 8 Apr 2015 10:36:53 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id DFEE8B5D868 for ; Wed, 8 Apr 2015 10:46:56 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 114B297A82B for ; Wed, 8 Apr 2015 10:46:58 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ynqwf4v1T_Hu for ; Wed, 8 Apr 2015 10:46:57 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 9A00497A820 for ; Wed, 8 Apr 2015 10:46:57 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 4B1DF952439 for ; Wed, 8 Apr 2015 10:46:55 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 70C80120432; Wed, 8 Apr 2015 10:46:54 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2D85712040E for ; Wed, 8 Apr 2015 10:46:50 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=8S5XDcUf/eyemT0BVi5UMd5OmU4=; b=I6M6wYgaItDz9Z74tT uQ75c1oA9YYGCs3uZR2RgmQVEKGITpvxmnvVkYbxXZrwkfcdTGuBlDmDT80yodNR gWmwgtYn3A55ORPGTtv2dhFgUZpgitO5fCDb63F877WIsc2pNoXYQdnfHPRCWopQ fttTziXOOKEFq61c4trjWoeAo= Received: by filter0390p1mdw1.sendgrid.net with SMTP id filter0390p1mdw1.25705.55248885E 2015-04-08 01:46:45.641996186 +0000 UTC Received: from herokuapp.com (ec2-54-166-10-189.compute-1.amazonaws.com [54.166.10.189]) by ismtpd-047 (SG) with ESMTP id 14c96b549c9.79c5.cbc804 for ; Wed, 08 Apr 2015 01:46:45 +0000 (UTC) Date: Wed, 08 Apr 2015 01:46:45 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 43203 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11045 X-Redmine-Issue-Author: headius X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6V2AMDeSn2swLQfV+F2s6/y/0D/dW+BJflEI P6IPPTVFad18Tfab62BA0r/GqEefT6bsJ4K/f6sgVI9YUTDQLtyz2AHkeYcPlTZf9QzB3d0oE8kEUa aWuguUrmE35cLqrXoGVQ+8hB2sI4BLVswSJ9 X-SendGrid-Contentd-ID: {"test_id":"1428457607"} X-ML-Name: ruby-core X-Mail-Count: 68796 Subject: [ruby-core:68796] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11045 has been updated by Nobuyoshi Nakada. Charles Nutter wrote: > 3. Do we really want to be testing linux-specific crypt behavior? I don't think we want, it's just an implementation regression test. > I propose that we just make the test skip non-alpha salt unconditionally. Or we need a standard way to isolate this kind of tests. ---------------------------------------- Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior https://bugs.ruby-lang.org/issues/11045#change-52066 * Author: Charles Nutter * Status: Open * Priority: Normal * Assignee: * ruby -v: trunk * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb. 1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar) 2. On platforms that use glibc but don't report version, this guard won't work. 3. Do we really want to be testing linux-specific crypt behavior? I propose that we just make the test skip non-alpha salt unconditionally. -- https://bugs.ruby-lang.org/