[ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[headius]

Issue #11045 has been reported by Charles Nutter.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:68796] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[nobu]

Issue #11045 has been updated by Nobuyoshi Nakada.


Charles Nutter wrote:
> 3. Do we really want to be testing linux-specific crypt behavior?

I don't think we want, it's just an implementation regression test.

> I propose that we just make the test skip non-alpha salt unconditionally.

Or we need a standard way to isolate this kind of tests.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52066

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:68826] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[headius]

Issue #11045 has been updated by Charles Nutter.


Nobuyoshi Nakada wrote:
> Or we need a standard way to isolate this kind of tests.

That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52089

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[headius]

Issue #11045 has been updated by Charles Nutter.

Status changed from Open to Closed

Fixed by r50366.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52209

* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:68955] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[headius]

Issue #11045 has been updated by Charles Nutter.

Assignee set to Charles Nutter

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52210

* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:69806] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[usa]

Issue #11045 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53202

* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:69852] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[usa]

Issue #11045 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53252

* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/

[ruby-core:69859] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

[nagachika00]

Issue #11045 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into `ruby_2_2` branch at r51130.

----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-53264

* Author: Charles Nutter
* Status: Closed
* Priority: Normal
* Assignee: Charles Nutter
* ruby -v: trunk
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.



-- 
https://bugs.ruby-lang.org/