From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 9DAFA196009D for ; Fri, 3 Jul 2015 17:11:19 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 871D6B5D890 for ; Fri, 3 Jul 2015 17:37:15 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 700C297A827 for ; Fri, 3 Jul 2015 17:37:17 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FTINxD1HlsjW for ; Fri, 3 Jul 2015 17:37:17 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 348F197A826 for ; Fri, 3 Jul 2015 17:37:17 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 14019952439 for ; Fri, 3 Jul 2015 17:37:14 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 62111120476; Fri, 3 Jul 2015 17:37:14 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 68294120446 for ; Fri, 3 Jul 2015 17:37:10 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=ebf06AOgWE8PHV258QNtq1R/Ckk=; b=KbU2iX7bvTY5Sw9iru +vraNY6rTrWjivfVJiEB8aO5fJw7+XhZCqrxPjLvhL8evkM6E9UDTghGBZCIi4lK fAb2VzBccBWspsLQi1AjU22/1kAiO6rYZEh0gVRB35f/VJo1az8pV2i1TONRzqqD /XJzklBr1ptughPA7HVCmdHmU= Received: by filter0648p1mdw1.sendgrid.net with SMTP id filter0648p1mdw1.31120.559649AB5 2015-07-03 08:37:02.041605398 +0000 UTC Received: from herokuapp.com (ec2-54-163-167-66.compute-1.amazonaws.com [54.163.167.66]) by ismtpd-028 (SG) with ESMTP id 14e530fd016.1be.1a914f for ; Fri, 03 Jul 2015 08:37:02 +0000 (UTC) Date: Fri, 03 Jul 2015 08:37:01 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44450 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11045 X-Redmine-Issue-Author: headius X-Redmine-Issue-Assignee: headius X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5ABgVlQuwMFQmu7M430Xp+SWkWEIS4qNV5gD 5jORXv7JV/xK85gMsUO41Im3yyfDUwo6AQ3KOetwM0zB80kHq04Dotxt47PlxgNcSYFtxUn7UHepuD BvyL1PDf2kTRdTyO4oQCfXhsjivj3bHe14hL X-ML-Name: ruby-core X-Mail-Count: 69852 Subject: [ruby-core:69852] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11045 has been updated by Usaku NAKAMURA. Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED ---------------------------------------- Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior https://bugs.ruby-lang.org/issues/11045#change-53252 * Author: Charles Nutter * Status: Closed * Priority: Normal * Assignee: Charles Nutter * ruby -v: trunk * Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED ---------------------------------------- I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb. 1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar) 2. On platforms that use glibc but don't report version, this guard won't work. 3. Do we really want to be testing linux-specific crypt behavior? I propose that we just make the test skip non-alpha salt unconditionally. -- https://bugs.ruby-lang.org/