From: headius@headius.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:68826] [Ruby trunk - Bug #11045] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
Date: Thu, 09 Apr 2015 16:59:09 +0000 [thread overview]
Message-ID: <redmine.journal-52089.20150409165908.4d3fd668d8449325@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11045.20150407203653@ruby-lang.org
Issue #11045 has been updated by Charles Nutter.
Nobuyoshi Nakada wrote:
> Or we need a standard way to isolate this kind of tests.
That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.
----------------------------------------
Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior
https://bugs.ruby-lang.org/issues/11045#change-52089
* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: trunk
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.
1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?
I propose that we just make the test skip non-alpha salt unconditionally.
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2015-04-09 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11045.20150407203653@ruby-lang.org>
2015-04-07 20:36 ` [ruby-core:68788] [Ruby trunk - Bug #11045] [Open] ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior headius
2015-04-08 1:46 ` [ruby-core:68796] [Ruby trunk - Bug #11045] " nobu
2015-04-09 16:59 ` headius [this message]
2015-04-21 18:45 ` [ruby-core:68954] [Ruby trunk - Bug #11045] [Closed] " headius
2015-04-21 18:45 ` [ruby-core:68955] [Ruby trunk - Bug #11045] " headius
2015-06-30 4:20 ` [ruby-core:69806] " usa
2015-07-03 8:37 ` [ruby-core:69852] " usa
2015-07-03 18:55 ` [ruby-core:69859] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-52089.20150409165908.4d3fd668d8449325@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).