[PATCH] localedata: Add Minguo calendar support to zh_TW

[PATCH] localedata: Add Minguo calendar support to zh_TW

[Felix Yan]

Minguo calendar is the official calendar system, and very widely used in
Taiwan, it would be nice to have the support in glibc.

Some background information: The government website (www.gov.tw) uses it
without the prefix, popular public services like Taiwan HSR also uses
this calendar system.

Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
---
 localedata/locales/zh_TW | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..958992e8be 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:民國:%EC%Ey年";/
+    "+:1:1912//01//01:1912//12//31:民國:%EC元年";/
+    "+:1:1911//12//31:-*:民前:%EC%Ey年"
 END LC_TIME
 
 LC_MESSAGES
-- 
2.20.1

Re: [PATCH] localedata: Add Minguo calendar support to zh_TW

[Rafal Luzynski]

Hello Felix,

Thank you for your effort and I'm sorry for the late reply.
I think this is your first contribution for glibc.  Please note
that you don't need a copyright assignment to contribute the
locale data changes but you may need it to contribute to other
modules.

Please see the issue below:

13.02.2019 11:51 Felix Yan <felixonmars@archlinux.org> wrote:
> [...]
> diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
> index 92b04b083d..958992e8be 100644
> --- a/localedata/locales/zh_TW
> +++ b/localedata/locales/zh_TW
> @@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
>  % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
>  t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
>  week 7;19971130;1
> +
> +era "+:2:1913//01//01:+*:民國:%EC%Ey年";/
> +    "+:1:1912//01//01:1912//12//31:民國:%EC元年";/
> +    "+:1:1911//12//31:-*:民前:%EC%Ey年"

Please use the Unicode sequences like "<U5206>" above instead
of actual Chinese characters.  Recently we have allowed using
actual characters instead of the Unicode sequences but only for
plain ASCII characters and only if they don't have a different
meaning already.  Other characters (including Chinese) may not
be portable, may be difficult or impossible to read, may be
lost while sending etc.

I have not tested your patch further due to this issue.
Please fix this and resend version 2 of your patch.

Regards,

Rafal 

[PATCH v2] localedata: Add Minguo calendar support to zh_TW

[Felix Yan]

Minguo calendar is the official calendar system, and very widely used in
Taiwan, it would be nice to have the support in glibc.

Some background information: The government website (www.gov.tw) uses it
without the prefix, popular public services like Taiwan HSR also uses
this calendar system.

Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
---
 localedata/locales/zh_TW | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..b869dec317 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_MESSAGES
-- 
2.21.0

Re: [PATCH v2] localedata: Add Minguo calendar support to zh_TW

[Rafal Luzynski]

Felix,

Thank you for the update.  Please see the results of my tests.  First,
unpatched version:


$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey
19
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY
2019
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1992-01-01
92
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1992-01-01
1992
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1913-01-01
13
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1913-01-01
1913
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1912-12-31
12
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1912-12-31
1912
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1912-01-01
12
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1912-01-01
1912
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1911-12-31
11
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1911-12-31
1911
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1901-12-31
01
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1901-12-31
1901


Now the same commands with your patch applied:


$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey
108
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY
民國108年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1992-01-01
81
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1992-01-01
民國81年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1913-01-01
02
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1913-01-01
民國02年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1912-12-31
01
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1912-12-31
民國元年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1912-01-01
01
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1912-01-01
民國元年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1911-12-31
01
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1911-12-31
民前01年
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1901-12-31
11
$ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1901-12-31
民前11年


Please confirm this is what you wanted to achieve.  Being unable to
read Chinese script I can only verify the numbers and I can only
trust you that this is correct otherwise.

Now please look inside the localedata/locales directory. [1] There
are 5 other locales from Taiwan: cmn_TW, hak_TW, lzh_TW, nan_TW,
and nan_TW@latin.  If Minguo calendar is popular in Taiwan then do
you think that those other locales need the same update as well?
Can you please update them, and maybe squash all changes into a single
patch?

Also please see below:

1.03.2019 20:27 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan, it would be nice to have the support in glibc.
> 
> Some background information: The government website (www.gov.tw) uses it
> without the prefix, popular public services like Taiwan HSR also uses
> this calendar system.

I don't understand what is the prefix ("without the prefix") here.
Is this a typo or maybe just a concept I am not familiar with?

> Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
> ---
>  localedata/locales/zh_TW | 4 ++++
>  1 file changed, 4 insertions(+)

ChangeLog entry is missing here.  I don't mean updating ChangeLog and
posting the diff here but a short summary of changes should be included
in the commit message, e.g.:

        [BZ #...]
        * localedata/locales/zh_TW (LC_TIME): Add era, support Minguo
        calendar.

or 

        [BZ #...]
        * localedata/locales/zh_TW (era): Add, support Minguo calendar.

I've just realized that Bugzilla entry is missing for this issue, please
file it. [2] (Select Component: localedata).  Also add the bug number
to the first line of the commit message which is also the subject line
of this email.

> diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
> index 92b04b083d..b869dec317 100644
> --- a/localedata/locales/zh_TW
> +++ b/localedata/locales/zh_TW
> @@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
>  % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
>  t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
>  week 7;19971130;1
> +
> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>  END LC_TIME
>  
>  LC_MESSAGES
> -- 
> 2.21.0

I believe this is correct, see my tests above.

Regards,

Rafal


[1]
https://sourceware.org/git/?p=glibc.git;a=tree;f=localedata/locales;hb=HEAD
[2] https://sourceware.org/bugzilla/enter_bug.cgi?product=glibc

Re: [PATCH v2] localedata: Add Minguo calendar support to zh_TW

[Felix Yan]

[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]

On 2019/3/2 下午11:49, Rafal Luzynski wrote:
> $ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1913-01-01
> 02
> $ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1913-01-01
> 民國02年

There seems to be a small difference here:

$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1913-01-01
2
$ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1913-01-01
民國2年

The text is correct without the zero padding before number. Am I missing
something that caused this difference?

> Please confirm this is what you wanted to achieve.  Being unable to
> read Chinese script I can only verify the numbers and I can only
> trust you that this is correct otherwise.

Apart from the above difference, the other parts are correct. I have
double confirmed this on #l10n-tw too.

> Now please look inside the localedata/locales directory. [1] There
> are 5 other locales from Taiwan: cmn_TW, hak_TW, lzh_TW, nan_TW,
> and nan_TW@latin.  If Minguo calendar is popular in Taiwan then do
> you think that those other locales need the same update as well?
> Can you please update them, and maybe squash all changes into a single
> patch?

For nan_TW@latin maybe I need to find a Minnan user. I didn't find one
yet though. Would it be possible to leave that one out for now?

>> Some background information: The government website (www.gov.tw) uses it
>> without the prefix, popular public services like Taiwan HSR also uses
>> this calendar system.
> 
> I don't understand what is the prefix ("without the prefix") here.
> Is this a typo or maybe just a concept I am not familiar with?

I meant the short version (%Ey), sorry for the confusion.

I'll send a revised patch soon.

-- 
Regards,
Felix Yan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] localedata: Add Minguo calendar support to zh_TW

[Rafal Luzynski]

2.03.2019 18:04 Felix Yan <felixonmars@archlinux.org> wrote:
> On 2019/3/2 下午11:49, Rafal Luzynski wrote:
> > $ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1913-01-01
> > 02
> > $ LC_TIME=zh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1913-01-01
> > 民國02年
> 
> There seems to be a small difference here:
> 
> $ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%Ey -d 1913-01-01
> 2
> $ LC_TIME=zh_TW.UTF-8 /usr/bin/date +%EY -d 1913-01-01
> 民國2年
> 
> The text is correct without the zero padding before number. Am I missing
> something that caused this difference?

Yes, it's a new feature added to glibc 2.29 shortly before the release. [1]
If you want "2" without the zero padding you must use "%-Ey" or "%-EY".

> > Please confirm this is what you wanted to achieve.  Being unable to
> > read Chinese script I can only verify the numbers and I can only
> > trust you that this is correct otherwise.
> 
> Apart from the above difference, the other parts are correct. I have
> double confirmed this on #l10n-tw too.

Thank you.

> > Now please look inside the localedata/locales directory. [1] There
> > are 5 other locales from Taiwan: cmn_TW, hak_TW, lzh_TW, nan_TW,
> > and nan_TW@latin.  If Minguo calendar is popular in Taiwan then do
> > you think that those other locales need the same update as well?
> > Can you please update them, and maybe squash all changes into a single
> > patch?
> 
> For nan_TW@latin maybe I need to find a Minnan user. I didn't find one
> yet though. Would it be possible to leave that one out for now?

Sure.  You can contribute another patch referring to the same bug report
if you contribute it soon.  You will need to file a new bug report after
2.30 is released (August 2019).

> >> Some background information: The government website (www.gov.tw) uses
> >> it
> >> without the prefix, popular public services like Taiwan HSR also uses
> >> this calendar system.
> > 
> > I don't understand what is the prefix ("without the prefix") here.
> > Is this a typo or maybe just a concept I am not familiar with?
> 
> I meant the short version (%Ey), sorry for the confusion.
> 
> I'll send a revised patch soon.

Thank you.  I saw your email but I have not tested/reviewed yet.

Regards,

Rafal


[1] https://sourceware.org/bugzilla/show_bug.cgi?id=23758

[PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Felix Yan]

Minguo calendar is the official calendar system, and very widely used in
Taiwan, it would be nice to have the support in glibc.

Some background information: The government website (www.gov.tw) uses it,
popular public services like Taiwan HSR also uses this calendar system.

Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

        [BZ #24293]
        * localedata/locales/zh_TW (era): Add, support Minguo calendar.
---
 localedata/locales/cmn_TW | 4 ++++
 localedata/locales/hak_TW | 4 ++++
 localedata/locales/lzh_TW | 4 ++++
 localedata/locales/nan_TW | 4 ++++
 localedata/locales/zh_TW  | 4 ++++
 5 files changed, 20 insertions(+)

diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
index cca7cc19af..9d9aca0f9e 100644
--- a/localedata/locales/cmn_TW
+++ b/localedata/locales/cmn_TW
@@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
 t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %-d號 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/hak_TW b/localedata/locales/hak_TW
index f62937e91b..ec86e985d1 100644
--- a/localedata/locales/hak_TW
+++ b/localedata/locales/hak_TW
@@ -116,6 +116,10 @@ t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %e日 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/lzh_TW b/localedata/locales/lzh_TW
index 9654463d42..4740418a83 100644
--- a/localedata/locales/lzh_TW
+++ b/localedata/locales/lzh_TW
@@ -150,6 +150,10 @@ alt_digits    "<U3007>";/
             "<U5345><U4E00>"
 %
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/nan_TW b/localedata/locales/nan_TW
index f5bc5d1642..0f19c66c86 100644
--- a/localedata/locales/nan_TW
+++ b/localedata/locales/nan_TW
@@ -117,6 +117,10 @@ t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %e日 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..b869dec317 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_MESSAGES
-- 
2.21.0

Re: [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski]

Hello Felix,

Thank you for the next version of your patch.

2.03.2019 18:11 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan, it would be nice to have the support in glibc.

The commit language should be straight and simple, "it would be nice..."
is nice but not necessary, I think.  Also, it will be part of the
repository,
no need to express a wish when it will have been already fulfilled. :-)

> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also uses this calendar system.

"also uses" -> "also use" (plural).

> Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

"wikipedia" -> "Wikipedia".  Otherwise correct.

> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.

All updated files must be listed here alphabetically, if the comment is
the same it should be replaced with "Likewise." E.g.,

        [BZ #24293]
        * localedata/locales/cmn_TW (era): Add, support Minguo calendar.
        * localedata/locales/hak_TW (era): Likewise.
        * ...

> ---
>  localedata/locales/cmn_TW | 4 ++++
>  localedata/locales/hak_TW | 4 ++++
>  localedata/locales/lzh_TW | 4 ++++
>  localedata/locales/nan_TW | 4 ++++
>  localedata/locales/zh_TW  | 4 ++++
>  5 files changed, 20 insertions(+)
> 
> diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
> index cca7cc19af..9d9aca0f9e 100644
> --- a/localedata/locales/cmn_TW
> +++ b/localedata/locales/cmn_TW
> @@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
>  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
>  % %Y年 %b %-d號 %A %H:%M:%S %Z
>  date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
> +
> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>  END LC_TIME

Do I see correctly that the content of "era" is the same in all locales?
Please forgive me my ignorance, is this correct despite these are different
languages?

Regards,

Rafal

Re: [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Felix Yan]

[-- Attachment #1.1: Type: text/plain, Size: 1488 bytes --]

On 2019/3/6 上午7:45, Rafal Luzynski wrote:
>>  localedata/locales/cmn_TW | 4 ++++
>>  localedata/locales/hak_TW | 4 ++++
>>  localedata/locales/lzh_TW | 4 ++++
>>  localedata/locales/nan_TW | 4 ++++
>>  localedata/locales/zh_TW  | 4 ++++
>>  5 files changed, 20 insertions(+)
>>
>> diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
>> index cca7cc19af..9d9aca0f9e 100644
>> --- a/localedata/locales/cmn_TW
>> +++ b/localedata/locales/cmn_TW
>> @@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
>>  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
>>  % %Y年 %b %-d號 %A %H:%M:%S %Z
>>  date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
>> +
>> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
>> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
>> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>>  END LC_TIME
> 
> Do I see correctly that the content of "era" is the same in all locales?
> Please forgive me my ignorance, is this correct despite these are different
> languages?

zh_TW is locale for the writing system of Traditional Chinese in Taiwan,
while the others are for different pronunciation systems. They are
reflecting different aspects (or variants) of the same language. I
believe most users uses zh_TW and very few uses the others. The others
can be useful for a TTS system, though.

I'll correct the issues and send next version shortly.

-- 
Regards,
Felix Yan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski]

7.03.2019 10:35 Felix Yan <felixonmars@archlinux.org> wrote:
> On 2019/3/6 上午7:45, Rafal Luzynski wrote:
> > [...]
> > Do I see correctly that the content of "era" is the same in all locales?
> > Please forgive me my ignorance, is this correct despite these are
> > different
> > languages?
> 
> zh_TW is locale for the writing system of Traditional Chinese in Taiwan,
> while the others are for different pronunciation systems. They are
> reflecting different aspects (or variants) of the same language.

I don't think I understand this paragraph but I believe that you mean
that this is correct despite the language difference.  Due to my lack
of knowledge about Chinese language I am unable to verify this.

> I
> believe most users uses zh_TW and very few uses the others. The others
> can be useful for a TTS system, though.

That few people use a language is not a reason not to provide the
correct translation.  But that's irrelevant since (IIUC) the patch
provides correct locale data for all these languages.

> I'll correct the issues and send next version shortly.

Thank you, I will move to the new version.

Regards,

Rafal

[PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Felix Yan]

Minguo calendar is the official calendar system, and very widely used in
Taiwan. This commit adds its support into glibc.

Some background information: The government website (www.gov.tw) uses it,
popular public services like Taiwan HSR also use this calendar system.

Link to Wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

        [BZ #24293]
        * localedata/locales/zh_TW (era): Add, support Minguo calendar.
        * localedata/locales/cmn_TW (era): Likewise.
        * localedata/locales/hak_TW (era): Likewise.
        * localedata/locales/lzh_TW (era): Likewise.
        * localedata/locales/nan_TW (era): Likewise.
---
 localedata/locales/cmn_TW | 4 ++++
 localedata/locales/hak_TW | 4 ++++
 localedata/locales/lzh_TW | 4 ++++
 localedata/locales/nan_TW | 4 ++++
 localedata/locales/zh_TW  | 4 ++++
 5 files changed, 20 insertions(+)

diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
index cca7cc19af..9d9aca0f9e 100644
--- a/localedata/locales/cmn_TW
+++ b/localedata/locales/cmn_TW
@@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
 t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %-d號 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/hak_TW b/localedata/locales/hak_TW
index f62937e91b..ec86e985d1 100644
--- a/localedata/locales/hak_TW
+++ b/localedata/locales/hak_TW
@@ -116,6 +116,10 @@ t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %e日 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/lzh_TW b/localedata/locales/lzh_TW
index 9654463d42..4740418a83 100644
--- a/localedata/locales/lzh_TW
+++ b/localedata/locales/lzh_TW
@@ -150,6 +150,10 @@ alt_digits    "<U3007>";/
             "<U5345><U4E00>"
 %
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/nan_TW b/localedata/locales/nan_TW
index f5bc5d1642..0f19c66c86 100644
--- a/localedata/locales/nan_TW
+++ b/localedata/locales/nan_TW
@@ -117,6 +117,10 @@ t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %e日 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..b869dec317 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@ am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_MESSAGES
-- 
2.21.0

Re: [PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski]

7.03.2019 10:40 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan. This commit adds its support into glibc.
> 
> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also use this calendar system.
> 
> Link to Wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.
>         * localedata/locales/cmn_TW (era): Likewise.
>         * localedata/locales/hak_TW (era): Likewise.
>         * localedata/locales/lzh_TW (era): Likewise.
>         * localedata/locales/nan_TW (era): Likewise.

This patch is correct, thank you.

Reviewed-by: Rafal Luzynski <digitalfreak@lingonborough.com>

Do you need someone to push it for you?

Questions to more experienced maintainers:

* Have you got any objections against this patch?
* Do we need a NEWS entry for this change?

Mike, Joseph, Carlos, anyone?

Regards,

Rafal

Re: [PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Felix Yan]

[-- Attachment #1.1: Type: text/plain, Size: 172 bytes --]

On 2019/3/8 下午6:52, Rafal Luzynski wrote:
> Do you need someone to push it for you?

Yes. Sorry I am not sure about the process here.

-- 
Regards,
Felix Yan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski]

8.03.2019 12:03 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> On 2019/3/8 下午6:52, Rafal Luzynski wrote:
> > Do you need someone to push it for you?
> 
> Yes. Sorry I am not sure about the process here.

The process you have followed is absolutely correct, as long as
you contribute to locale data or if your patch is trivial.
If you wanted to contribute to other parts, then you would have
to sign the copyright assignment. But for now it is correct,
locale data are not copyrighted. Someone (most probably myself)
will push this for you shortly.

Regards,

Rafal

Re: [PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski]

11.03.2019 12:05 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> [...] Someone (most probably myself)
> will push this for you shortly.

This patch [1] has just been pushed to master with minor reword of
the subject line reflecting the fact that not just zh_TW but also
other Taiwanese locales have been updated.  Thank you Felix for your
contribution.  Feel free to contribute more patches if you have more
updates, especially for nan_TW@latin which is not yet updated.

Regards,

Rafal


[1] https://sourceware.org/ml/libc-alpha/2019-03/msg00135.html