From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A407220248 for ; Sat, 2 Mar 2019 17:49:03 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:message-id:in-reply-to:references :subject:mime-version:content-type:content-transfer-encoding; q= dns; s=default; b=rvoSAHdWDDgk+hiobBdnlyMxKYa9ZR/1Ac0i5rjAOUH4Qy rqwf+5iTEffxMp9igx+WzO+zaCdqihrlshO05XJfOIdSFiRq/oWfZkMzq/ztp4Bt HXISo1l4/Mj8WeC89BXccjlnMCKUsCqVx6JN77HynnixZGMiaHwBr6N5Dbf0c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:message-id:in-reply-to:references :subject:mime-version:content-type:content-transfer-encoding; s= default; bh=9EmXyJ5Q+LFloZDuZIYr3nQgoac=; b=HKMtXIlGaNxvvevq/Xdy W4m68eDXNiMqupwC4C0l6EF4MydkcCY06rf7MXUmfU+ZWLEmEtFMqGP2THoegkIF SciURJD1SCcQtiSYLCvWNYPBf2Q2NPEIJWT+npyRUaXBG4QVr5h+L+NjIYXk4nwO aW6RNrQYFM8fuijNe4vD87g= Received: (qmail 25128 invoked by alias); 2 Mar 2019 17:48:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24642 invoked by uid 89); 2 Mar 2019 17:48:42 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: shared-ano163.rev.nazwa.pl Date: Sat, 2 Mar 2019 18:46:03 +0100 (CET) From: Rafal Luzynski To: Felix Yan , libc-alpha@sourceware.org Message-ID: <673805479.156077.1551548763940@poczta.nazwa.pl> In-Reply-To: <020711cd-bf67-eec9-3992-e78c34bf1831@archlinux.org> References: <20190213105150.9323-1-felixonmars@archlinux.org> <20190301192730.10959-1-felixonmars@archlinux.org> <246188907.153474.1551541771071@poczta.nazwa.pl> <020711cd-bf67-eec9-3992-e78c34bf1831@archlinux.org> Subject: Re: [PATCH v2] localedata: Add Minguo calendar support to zh_TW MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2.03.2019 18:04 Felix Yan wrote: > On 2019/3/2 =E4=B8=8B=E5=8D=8811:49, Rafal Luzynski wrote: > > $ LC_TIME=3Dzh_TW.UTF-8 ./testrun.sh /usr/bin/date +%Ey -d 1913-01-01 > > 02 > > $ LC_TIME=3Dzh_TW.UTF-8 ./testrun.sh /usr/bin/date +%EY -d 1913-01-01 > > =E6=B0=91=E5=9C=8B02=E5=B9=B4 >=20 > There seems to be a small difference here: >=20 > $ LC_TIME=3Dzh_TW.UTF-8 /usr/bin/date +%Ey -d 1913-01-01 > 2 > $ LC_TIME=3Dzh_TW.UTF-8 /usr/bin/date +%EY -d 1913-01-01 > =E6=B0=91=E5=9C=8B2=E5=B9=B4 >=20 > The text is correct without the zero padding before number. Am I missing > something that caused this difference? Yes, it's a new feature added to glibc 2.29 shortly before the release. [1] If you want "2" without the zero padding you must use "%-Ey" or "%-EY". > > Please confirm this is what you wanted to achieve. Being unable to > > read Chinese script I can only verify the numbers and I can only > > trust you that this is correct otherwise. >=20 > Apart from the above difference, the other parts are correct. I have > double confirmed this on #l10n-tw too. Thank you. > > Now please look inside the localedata/locales directory. [1] There > > are 5 other locales from Taiwan: cmn_TW, hak_TW, lzh_TW, nan_TW, > > and nan_TW@latin. If Minguo calendar is popular in Taiwan then do > > you think that those other locales need the same update as well? > > Can you please update them, and maybe squash all changes into a single > > patch? >=20 > For nan_TW@latin maybe I need to find a Minnan user. I didn't find one > yet though. Would it be possible to leave that one out for now? Sure. You can contribute another patch referring to the same bug report if you contribute it soon. You will need to file a new bug report after 2.30 is released (August 2019). > >> Some background information: The government website (www.gov.tw) uses > >> it > >> without the prefix, popular public services like Taiwan HSR also uses > >> this calendar system. > >=20 > > I don't understand what is the prefix ("without the prefix") here. > > Is this a typo or maybe just a concept I am not familiar with? >=20 > I meant the short version (%Ey), sorry for the confusion. >=20 > I'll send a revised patch soon. Thank you. I saw your email but I have not tested/reviewed yet. Regards, Rafal [1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D23758