unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Rafal Luzynski <digitalfreak@lingonborough.com>
To: Felix Yan <felixonmars@archlinux.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]
Date: Fri, 8 Mar 2019 11:52:07 +0100 (CET)	[thread overview]
Message-ID: <590987813.74896.1552042327990@poczta.nazwa.pl> (raw)
In-Reply-To: <20190307094002.16972-1-felixonmars@archlinux.org>

7.03.2019 10:40 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan. This commit adds its support into glibc.
> 
> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also use this calendar system.
> 
> Link to Wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.
>         * localedata/locales/cmn_TW (era): Likewise.
>         * localedata/locales/hak_TW (era): Likewise.
>         * localedata/locales/lzh_TW (era): Likewise.
>         * localedata/locales/nan_TW (era): Likewise.

This patch is correct, thank you.

Reviewed-by: Rafal Luzynski <digitalfreak@lingonborough.com>

Do you need someone to push it for you?

Questions to more experienced maintainers:

* Have you got any objections against this patch?
* Do we need a NEWS entry for this change?

Mike, Joseph, Carlos, anyone?

Regards,

Rafal

  reply	other threads:[~2019-03-08 10:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 10:51 [PATCH] localedata: Add Minguo calendar support to zh_TW Felix Yan
2019-03-01 18:31 ` Rafal Luzynski
2019-03-01 19:27 ` [PATCH v2] " Felix Yan
2019-03-02 15:49   ` Rafal Luzynski
2019-03-02 17:04     ` Felix Yan
2019-03-02 17:46       ` Rafal Luzynski
2019-03-02 17:11 ` [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293] Felix Yan
2019-03-05 23:45   ` Rafal Luzynski
2019-03-07  9:35     ` Felix Yan
2019-03-08 10:47       ` Rafal Luzynski
2019-03-07  9:40 ` [PATCH v4] " Felix Yan
2019-03-08 10:52   ` Rafal Luzynski [this message]
2019-03-08 11:03     ` Felix Yan
2019-03-11 11:05       ` Rafal Luzynski
2019-03-15  9:20         ` Rafal Luzynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=590987813.74896.1552042327990@poczta.nazwa.pl \
    --to=digitalfreak@lingonborough.com \
    --cc=felixonmars@archlinux.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).