From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 24E0C20248 for ; Tue, 5 Mar 2019 23:46:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:message-id:in-reply-to:references :subject:mime-version:content-type:content-transfer-encoding; q= dns; s=default; b=l0HzPgmQN8wOvPuSKg9NBpHNiEijDYaSkQtPdPZNbd5qzv wbcXJd1mSjjLeSLrfMWFYEuSHfN/KbFlhNZ+lvJdIPoEgKEa5maZhTftOOz8RURR bRWgRcGCPwFQB11ukcw1un8NOLjO0WMhC8Q+bAL97W9maJw4XuAr3QF354IAk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:message-id:in-reply-to:references :subject:mime-version:content-type:content-transfer-encoding; s= default; bh=lJDgtBH9JpLWMWu26wB+r/lqM+8=; b=ewpg4/uCb6JVThiGv4HD IqxpulO3n3beXqj+noy5Mw7v+9MaGAGFaDoRKWExlsBbhC2c1FNSPZDB1Mhwy2cI QrD4v12x1xdvkHHPizx94dMn0xd3CZLR4wKWzIU+M0+LA+8OhqxpKv7qnEttzf18 p1VwxubcI5AGlHW4yXrpHOo= Received: (qmail 50488 invoked by alias); 5 Mar 2019 23:46:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50472 invoked by uid 89); 5 Mar 2019 23:46:43 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: shared-ano163.rev.nazwa.pl Date: Wed, 6 Mar 2019 00:45:57 +0100 (CET) From: Rafal Luzynski To: Felix Yan , libc-alpha@sourceware.org Message-ID: <28917729.169388.1551829557828@poczta.nazwa.pl> In-Reply-To: <20190302171111.18578-1-felixonmars@archlinux.org> References: <20190213105150.9323-1-felixonmars@archlinux.org> <20190302171111.18578-1-felixonmars@archlinux.org> Subject: Re: [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Felix, Thank you for the next version of your patch. 2.03.2019 18:11 Felix Yan wrote: >=20 > Minguo calendar is the official calendar system, and very widely used in > Taiwan, it would be nice to have the support in glibc. The commit language should be straight and simple, "it would be nice..." is nice but not necessary, I think. Also, it will be part of the repository, no need to express a wish when it will have been already fulfilled. :-) > Some background information: The government website (www.gov.tw) uses it, > popular public services like Taiwan HSR also uses this calendar system. "also uses" -> "also use" (plural). > Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar "wikipedia" -> "Wikipedia". Otherwise correct. >=20 > [BZ #24293] > * localedata/locales/zh_TW (era): Add, support Minguo calendar. All updated files must be listed here alphabetically, if the comment is the same it should be replaced with "Likewise." E.g., [BZ #24293] * localedata/locales/cmn_TW (era): Add, support Minguo calendar. * localedata/locales/hak_TW (era): Likewise. * ... > --- > localedata/locales/cmn_TW | 4 ++++ > localedata/locales/hak_TW | 4 ++++ > localedata/locales/lzh_TW | 4 ++++ > localedata/locales/nan_TW | 4 ++++ > localedata/locales/zh_TW | 4 ++++ > 5 files changed, 20 insertions(+) >=20 > diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW > index cca7cc19af..9d9aca0f9e 100644 > --- a/localedata/locales/cmn_TW > +++ b/localedata/locales/cmn_TW > @@ -119,6 +119,10 @@ am_pm "";/ > t_fmt_ampm "%p %I%M%S" > % %Y=E5=B9=B4 %b %-d=E8=99=9F %A %H:%M:%S %Z > date_fmt "%Y %b %-d %A %H:%M:%S %Z" > + > +era "+:2:1913//01//01:+*::%EC%Ey";/ > + "+:1:1912//01//01:1912//12//31::%EC";/ > + "+:1:1911//12//31:-*::%EC%Ey" > END LC_TIME Do I see correctly that the content of "era" is the same in all locales? Please forgive me my ignorance, is this correct despite these are different languages? Regards, Rafal