git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] upload-pack.c: fix a sparse warning
@ 2020-10-31 21:04 Ramsay Jones
  2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano
  2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon
  0 siblings, 2 replies; 11+ messages in thread
From: Ramsay Jones @ 2020-10-31 21:04 UTC (permalink / raw)
  To: steadmon; +Cc: GIT Mailing-list


Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Josh,

If you need to re-roll your 'js/trace2-session-id' branch, could you please
squash this into the relevant patch (commit edb21a501e, "upload-pack, serve:
log received client trace2 SID", 29-10-2020).

Thanks!

ATB,
Ramsay Jones
 
 upload-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/upload-pack.c b/upload-pack.c
index b7d097bf1b..2996b8083c 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -1111,7 +1111,7 @@ static void receive_needs(struct upload_pack_data *data,
 		if (data->allow_filter &&
 		    parse_feature_request(features, "filter"))
 			data->filter_capability_requested = 1;
-		if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, 0)))
+		if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, NULL)))
 		{
 			char *client_sid = xstrndup(arg, feature_len);
 			trace2_data_string("trace2", NULL, "client-sid", client_sid);
-- 
2.29.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-11-04 20:05 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones
2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano
2020-11-02  0:05   ` Ramsay Jones
2020-11-02 18:55     ` Junio C Hamano
2020-11-03  2:04       ` Ramsay Jones
2020-11-03  2:50         ` Junio C Hamano
2020-11-04 13:43         ` Johannes Schindelin
2020-11-04 16:57           ` Ramsay Jones
2020-11-04 18:11             ` Junio C Hamano
2020-11-04 20:05               ` Ramsay Jones
2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).