From: Josh Steadmon <steadmon@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] upload-pack.c: fix a sparse warning
Date: Mon, 2 Nov 2020 14:21:50 -0800 [thread overview]
Message-ID: <20201102222150.GB1904687@google.com> (raw)
In-Reply-To: <eaf5ac83-af3f-5028-3a9e-1669c9cde116@ramsayjones.plus.com>
On 2020.10.31 21:04, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Josh,
>
> If you need to re-roll your 'js/trace2-session-id' branch, could you please
> squash this into the relevant patch (commit edb21a501e, "upload-pack, serve:
> log received client trace2 SID", 29-10-2020).
>
> Thanks!
>
> ATB,
> Ramsay Jones
Fixed in V2, thanks!
> upload-pack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/upload-pack.c b/upload-pack.c
> index b7d097bf1b..2996b8083c 100644
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -1111,7 +1111,7 @@ static void receive_needs(struct upload_pack_data *data,
> if (data->allow_filter &&
> parse_feature_request(features, "filter"))
> data->filter_capability_requested = 1;
> - if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, 0)))
> + if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, NULL)))
> {
> char *client_sid = xstrndup(arg, feature_len);
> trace2_data_string("trace2", NULL, "client-sid", client_sid);
> --
> 2.29.0
prev parent reply other threads:[~2020-11-02 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones
2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano
2020-11-02 0:05 ` Ramsay Jones
2020-11-02 18:55 ` Junio C Hamano
2020-11-03 2:04 ` Ramsay Jones
2020-11-03 2:50 ` Junio C Hamano
2020-11-04 13:43 ` Johannes Schindelin
2020-11-04 16:57 ` Ramsay Jones
2020-11-04 18:11 ` Junio C Hamano
2020-11-04 20:05 ` Ramsay Jones
2020-11-02 22:21 ` Josh Steadmon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102222150.GB1904687@google.com \
--to=steadmon@google.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).