From: Junio C Hamano <gitster@pobox.com>
To: GIT Mailing-list <git@vger.kernel.org>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build
Date: Sat, 31 Oct 2020 15:22:08 -0700 [thread overview]
Message-ID: <xmqqsg9uxchb.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <eaf5ac83-af3f-5028-3a9e-1669c9cde116@ramsayjones.plus.com> (Ramsay Jones's message of "Sat, 31 Oct 2020 21:04:58 +0000")
With -Wsparse-error, "make sparse" would fail, instead of just
giving a warning message.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
config.mak.dev | 1 +
1 file changed, 1 insertion(+)
diff --git c/config.mak.dev w/config.mak.dev
index 3126a5364d..022fb58218 100644
--- c/config.mak.dev
+++ w/config.mak.dev
@@ -1,5 +1,6 @@
ifeq ($(filter no-error,$(DEVOPTS)),)
DEVELOPER_CFLAGS += -Werror
+SPARSE_FLAGS += -Wsparse-error
endif
ifneq ($(filter pedantic,$(DEVOPTS)),)
DEVELOPER_CFLAGS += -pedantic
next prev parent reply other threads:[~2020-10-31 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones
2020-10-31 22:22 ` Junio C Hamano [this message]
2020-11-02 0:05 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Ramsay Jones
2020-11-02 18:55 ` Junio C Hamano
2020-11-03 2:04 ` Ramsay Jones
2020-11-03 2:50 ` Junio C Hamano
2020-11-04 13:43 ` Johannes Schindelin
2020-11-04 16:57 ` Ramsay Jones
2020-11-04 18:11 ` Junio C Hamano
2020-11-04 20:05 ` Ramsay Jones
2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg9uxchb.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).