list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Ramsay Jones <>
To: Junio C Hamano <>
Cc: GIT Mailing-list <>
Subject: Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build
Date: Tue, 3 Nov 2020 02:04:45 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 02/11/2020 18:55, Junio C Hamano wrote:
> Ramsay Jones <> writes:
>> Yes, anybody who just does 'make sparse' will notice the failure, so
>> that would be a definite improvement. (How many people run 'make sparse'
>> though?).
> At least, I was planning to add one to the number when I wrote the
> patch, so that I would start using it as part of daily integration
> build before pushing day's result out.

Great! :-D

How are you installing sparse? (I am using Linux Mint 20, based on
Ubuntu 20.04, whose sparse package version is 0.6.1-2build1 - which
is to say too old; you require version 0.6.2 or greater. Building
from source, I am currently using v0.6.3-76-gf680124b).

[I seem to remember you saying you used Fedora, which usually has
more up-to-date software than most distros].

>> I guess it would be most useful on a CI build, but I don't know what
>> would be involved in setting that up.
> CI builds already have enough stuff around invocation of "make test"
> etc., and it would be trivial to pass SPARSE_FLAGS from the command
> line when adding "make sparse" invocation to one of the scripts in
> ci/ directory, so from that point of view, this patch is not needed
> for them, either.

My concern was more about how the CI system obtains/installs/builds a
sufficiently new version of sparse. Otherwise, 'make sparse' won't do
very much. ;-)  As I said, I don't know what's involved in getting
that to work.

Ramsay Jones

  reply	other threads:[~2020-11-03  2:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones
2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano
2020-11-02  0:05   ` Ramsay Jones
2020-11-02 18:55     ` Junio C Hamano
2020-11-03  2:04       ` Ramsay Jones [this message]
2020-11-03  2:50         ` Junio C Hamano
2020-11-04 13:43         ` Johannes Schindelin
2020-11-04 16:57           ` Ramsay Jones
2020-11-04 18:11             ` Junio C Hamano
2020-11-04 20:05               ` Ramsay Jones
2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).