Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build

[Junio C Hamano <gitster@pobox.com>]

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> Yes, anybody who just does 'make sparse' will notice the failure, so
> that would be a definite improvement. (How many people run 'make sparse'
> though?).

At least, I was planning to add one to the number when I wrote the
patch, so that I would start using it as part of daily integration
build before pushing day's result out.

I can tweak my $(MAKE) command line arguments in the script I use
for daily integration builds, so the patch is not strictly needed
for me personally.

> I guess it would be most useful on a CI build, but I don't know what
> would be involved in setting that up.

CI builds already have enough stuff around invocation of "make test"
etc., and it would be trivial to pass SPARSE_FLAGS from the command
line when adding "make sparse" invocation to one of the scripts in
ci/ directory, so from that point of view, this patch is not needed
for them, either.

My hope was that it would make it harder for individual contributors
who run "make sparse" and fail to notice an error from it.