From: Junio C Hamano <firstname.lastname@example.org> To: Ramsay Jones <email@example.com> Cc: GIT Mailing-list <firstname.lastname@example.org> Subject: Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Date: Mon, 02 Nov 2020 10:55:18 -0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Ramsay Jones <email@example.com> writes: > Yes, anybody who just does 'make sparse' will notice the failure, so > that would be a definite improvement. (How many people run 'make sparse' > though?). At least, I was planning to add one to the number when I wrote the patch, so that I would start using it as part of daily integration build before pushing day's result out. I can tweak my $(MAKE) command line arguments in the script I use for daily integration builds, so the patch is not strictly needed for me personally. > I guess it would be most useful on a CI build, but I don't know what > would be involved in setting that up. CI builds already have enough stuff around invocation of "make test" etc., and it would be trivial to pass SPARSE_FLAGS from the command line when adding "make sparse" invocation to one of the scripts in ci/ directory, so from that point of view, this patch is not needed for them, either. My hope was that it would make it harder for individual contributors who run "make sparse" and fail to notice an error from it.
next prev parent reply other threads:[~2020-11-02 18:55 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones 2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano 2020-11-02 0:05 ` Ramsay Jones 2020-11-02 18:55 ` Junio C Hamano [this message] 2020-11-03 2:04 ` Ramsay Jones 2020-11-03 2:50 ` Junio C Hamano 2020-11-04 13:43 ` Johannes Schindelin 2020-11-04 16:57 ` Ramsay Jones 2020-11-04 18:11 ` Junio C Hamano 2020-11-04 20:05 ` Ramsay Jones 2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).