git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build
Date: Wed, 4 Nov 2020 20:05:04 +0000	[thread overview]
Message-ID: <5885924e-ae91-1ed8-7b32-949b9ea377bd@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqk0v1m1ox.fsf@gitster.c.googlers.com>



On 04/11/2020 18:11, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> On 04/11/2020 13:43, Johannes Schindelin wrote:
>>> Hi Ramsay,
>>>
>>> On Tue, 3 Nov 2020, Ramsay Jones wrote:
>>>
>>>> On 02/11/2020 18:55, Junio C Hamano wrote:
>>>>
>>>>> CI builds already have enough stuff around invocation of "make test"
>>>>> etc., and it would be trivial to pass SPARSE_FLAGS from the command
>>>>> line when adding "make sparse" invocation to one of the scripts in ci/
>>>>> directory, so from that point of view, this patch is not needed for
>>>>> them, either.
>>>>
>>>> My concern was more about how the CI system obtains/installs/builds a
>>>> sufficiently new version of sparse. Otherwise, 'make sparse' won't do
>>>> very much. ;-)  As I said, I don't know what's involved in getting that
>>>> to work.
>>>
>>> As mentioned in https://github.com/gitgitgadget/git/issues/345, there is a
>>> Pipeline that builds sparse packages for Ubuntu, ready for use in our CI
>>> build: https://dev.azure.com/git/git/_build?definitionId=10&_a=summary.
>>> Currently, it is scheduled to run every weekday at 5:00am (I assume that's
>>> UTC).
>>
>> Oh-my! Has there been a CI 'make sparse' build since september last year? :-D
>> I missed that! (I couldn't view the azure build summary given above - it just
>> keeps asking for a user/password :( ).
> 
> Hmph, is that what Dscho said?
> 
> I thought he was just saying packaged versions of latest sparse
> usable on Ubuntu are regularly available so those who wants to add
> "make sparse" to our jobs have a place to fetch it from.

Ah, yes. Having read that again, I think your interpretation is correct.

Ahem. My mistake. Still, it's good to know that a suitable version of
sparse is available should anyone need it.

Thanks!

ATB,
Ramsay Jones



  reply	other threads:[~2020-11-04 20:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 21:04 [PATCH] upload-pack.c: fix a sparse warning Ramsay Jones
2020-10-31 22:22 ` [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build Junio C Hamano
2020-11-02  0:05   ` Ramsay Jones
2020-11-02 18:55     ` Junio C Hamano
2020-11-03  2:04       ` Ramsay Jones
2020-11-03  2:50         ` Junio C Hamano
2020-11-04 13:43         ` Johannes Schindelin
2020-11-04 16:57           ` Ramsay Jones
2020-11-04 18:11             ` Junio C Hamano
2020-11-04 20:05               ` Ramsay Jones [this message]
2020-11-02 22:21 ` [PATCH] upload-pack.c: fix a sparse warning Josh Steadmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5885924e-ae91-1ed8-7b32-949b9ea377bd@ramsayjones.plus.com \
    --to=ramsay@ramsayjones.plus.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).