Re: [RFC PATCH] push: start warning upcoming default change for push.default

[Junio C Hamano <gitster@pobox.com>]

lists@haller-berlin.de (Stefan Haller) writes:

> Marc Branchaud <marcnarc@xiplink.com> wrote:
>
>> I think that an incantation like
>> 
>>   git checkout -b topic origin/master
>> 
>> makes it pretty clear that topic is meant to be merged into origin's 
>> master branch.  And so a simple "git push" as you describe I think 
>> *should* update origin's master branch.
>
> Not for us, no.  (But this is maybe a different topic.)
>
> In our workflow (centralized repository), we never ever have a local
> branch with a different name than its upstream branch. Never.
>
> When we say
>
>   git checkout -b topic origin/master
>
> then it's always a mistake, and what we really meant was
>
>   git checkout -b --no-track topic origin/master

It would have been nice if you explained larger picture of your
workflow, as almost anything else in life, a blanket statement like
the above is not a universal truth.  It is clear you were aware of
that from your "Not for *us*", there is not enough clue for others
to tell if their workflow is similar to yours to decide if the above
rule of thumb of yours is a good one to follow for them.

Let's illustrate what I mean by "explain larger picture of workflow"
with a few examples.

An example of where "checkout -b topic origin/master" would not be a
mistake is when it is the norm for your project for contributors to
integrate their work with "pull --rebase", it is perfectly sensible
for a contributor to

	git checkout -b frotz origin/master

to start working on his feature "frotz", and way before the feature
becomes ready, starting to work on unrelated feature "nitfol" with

	git checout -b nitfol origin/master

and keep building these in parallel, running "git pull --rebase" to
float yet-to-be-published his own work on updated the shared history
before continuing to work on a topic until the feature is done.  As
the contributor may not know upfront which of these independent
features will become ready when he starts working, it is sensible
to be on the latter "nitfol" topic and "git push" it to update the
shared history with the finished work on the branch.

In this case, you would want "git push" a branch to its @{upstream}.

Another example that "checkout -b topic origin/master" would not be
a mistake is when you fork your favorite project at GitHub, work on
two independent topics. You work the same way as the above (you may
not "pull --rebase", though), and then push both of them out and ask
them to be pulled "Please pull my 'frotz' and 'nitfol' branches".

In this case, you would want "git push" a branch to update the
branch with the same name (i.e. either 'current' or 'matching').