From: Jonathan Nieder <jrnieder@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: Setup non-pushing gerrit instance for glibc.
Date: Thu, 24 Oct 2019 18:25:09 -0700 [thread overview]
Message-ID: <20191025012509.GB45423@google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910242122100.22279@digraph.polyomino.org.uk>
Hi,
A few quick notes from an ex Gerrit developer (nowadays almost all my
time is devoted to Git instead).
Joseph Myers wrote:
> Observations on teething troubles with the initial setup:
>
> 1. What's the status of fixing the problem with insufficient diff context
> in emails when comments relate to particular parts of the diff?
A quick search doesn't find a bug open about this at
https://crbug.com/gerrit/new.
[...]
> 2. Could text comments in emails from gerrit be properly wrapped?
> Messages such as
> <https://sourceware.org/ml/libc-alpha/2019-10/msg00715.html> are hard to
> read in the list archives because of very long lines. (Of course, diff
> context / quoted source lines should not be wrapped.)
Makes sense. Likewise, I don't see an existing bug open for this.
> 4. Could we document how to get and keep up to date a complete local copy
> of all the glibc review data in gerrit (comments etc.) using whatever APIs
> are available?
"git clone --mirror" would do this --- the code for the 5th iteration
of change #1234 is at refs/changes/34/1234/5, and the metadata (review
comments, etc) is at refs/changes/34/1234/meta.
See https://gerrit-review.googlesource.com/Documentation/concept-refs-for-namespace.html
and https://gerrit-review.googlesource.com/Documentation/user-upload.html#_gritty_details
for more on this subject.
Alternatively you can do something with
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html,
but that sounds fussier.
[...]
> 5. It would also be useful to have documentation for how someone should
> make a patch series appear appropriately in gerrit if they want to propose
> a series that way. That means the emails for a patch series should
> include 1/N, 2/N etc. in their subjects (with a 0/N cover letter as
> appropriate).
I really like this idea. Feel free to file a feature request for it
at https://crbug.com/gerrit/new.
> 6. Lower priority, but note there are certain kinds of changes involving
> huge diffs (e.g. to generated files) that thus *would* need a message size
> limit and pointing to a URL for the diffs in that case, for it to be
> possible to handle such changes through gerrit.
The default behavior is to limit diffs to 256k:
https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#sendemail.maximumDiffSize
Thanks,
Jonathan
next prev parent reply other threads:[~2019-10-25 1:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:39 Setup non-pushing gerrit instance for glibc Carlos O'Donell
2019-10-24 21:41 ` Joseph Myers
2019-10-25 0:43 ` Ian Kent
2019-10-25 1:16 ` Jonathan Nieder
2019-10-25 10:21 ` Ian Kent
2019-10-25 1:02 ` Carlos O'Donell
2019-10-25 2:04 ` Sergio Durigan Junior
2019-10-25 3:14 ` Simon Marchi
2019-10-25 4:10 ` Simon Marchi
2019-10-25 14:48 ` Joseph Myers
2019-10-25 15:48 ` Simon Marchi
2019-10-25 16:10 ` Joseph Myers
2019-10-25 16:28 ` Simon Marchi
2019-10-25 1:25 ` Jonathan Nieder [this message]
2019-10-25 14:09 ` Florian Weimer
2019-10-25 15:18 ` Joseph Myers
2019-10-25 17:00 ` Sergio Durigan Junior
2019-10-25 20:33 ` Joseph Myers
2019-10-25 21:06 ` Sergio Durigan Junior
2019-10-25 21:13 ` Joseph Myers
2019-10-27 22:12 ` Sergio Durigan Junior
2019-10-28 17:58 ` Joseph Myers
2019-10-28 19:17 ` Jonathan Nieder
2019-10-28 22:59 ` Joseph Myers
2019-10-29 1:21 ` Sergio Durigan Junior
2019-10-25 22:03 ` Jonathan Nieder
2019-10-26 13:53 ` Carlos O'Donell
2019-10-30 18:25 ` Szabolcs Nagy
2019-11-12 18:53 ` Gabriel F. T. Gomes
2019-11-12 19:21 ` Carlos O'Donell
2019-11-12 19:59 ` Florian Weimer
2019-11-12 20:02 ` Jonathan Nieder
2019-11-12 21:10 ` Gabriel F. T. Gomes
2019-11-12 21:13 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025012509.GB45423@google.com \
--to=jrnieder@gmail.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).