From: Ian Kent <ikent@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>,
Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: Setup non-pushing gerrit instance for glibc.
Date: Fri, 25 Oct 2019 08:43:04 +0800 [thread overview]
Message-ID: <580baf4ff0699a1eed12c2ea48f2162db639ad1c.camel@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910242122100.22279@digraph.polyomino.org.uk>
On Thu, 2019-10-24 at 21:41 +0000, Joseph Myers wrote:
> On Thu, 24 Oct 2019, Carlos O'Donell wrote:
>
> > * Try to setup email based code review in gerrit.
> > - Currently email is outbound only.
>
> Observations on teething troubles with the initial setup:
>
> 1. What's the status of fixing the problem with insufficient diff
> context
> in emails when comments relate to particular parts of the diff? They
> need
> to quote the relevant amount of context (typically at least the whole
> diff
> hunk, including the hunk header showing the changed function name)
> rather
> than just one line and a reference to an external URL. It's
> important for
> messages with reviews to be meaningful in themselves without
> depending on
> external links. This is a longstanding problem (it was obvious in
> some
> experiments some people did with proposing GCC patches with
> Rietveld,
> gerrit's predecessor, several years ago). Someone in the GDB
> discussions
> mentioned a prototype patch to add some context to the emails, so
> maybe we
> could use that patch.
>
> 2. Could text comments in emails from gerrit be properly wrapped?
> Messages such as
> <https://sourceware.org/ml/libc-alpha/2019-10/msg00715.html> are hard
> to
> read in the list archives because of very long lines. (Of course,
> diff
> context / quoted source lines should not be wrapped.)
>
> 3. Could we document (on the wiki, I suppose) the process for setting
> up
> git remotes if you want a git repository to get local copies of all
> versions of all changes proposed this way? My understanding is
> gerrit
> makes those available as refs named in some particular way, so adding
> a
> remote with appropriate fetch config should work, but the particular
> recipe ought to be documented.
>
> 4. Could we document how to get and keep up to date a complete local
> copy
> of all the glibc review data in gerrit (comments etc.) using whatever
> APIs
> are available? Again, I think the relevant APIs already exist, but
> how to
> use them for glibc ought to be documented (this is especially the
> case for
> a service like this that's experimental, and thus might go away in
> future).
>
> 5. It would also be useful to have documentation for how someone
> should
> make a patch series appear appropriately in gerrit if they want to
> propose
> a series that way. That means the emails for a patch series should
> include 1/N, 2/N etc. in their subjects (with a 0/N cover letter as
> appropriate).
I haven't spent much time with Gerrit but the time I have spent
I've found myself thinking Gerrit is designed with the assumption
that submissions are "one" patch.
I found handling a patch series (which I almost always have when
doing changes) rather painful!
>
> 6. Lower priority, but note there are certain kinds of changes
> involving
> huge diffs (e.g. to generated files) that thus *would* need a message
> size
> limit and pointing to a URL for the diffs in that case, for it to be
> possible to handle such changes through gerrit. (When sending email
> manually for such a change one can always omit the 50 MB of diffs to
> generated files, but as I understand it part of the point of such a
> patch
> review system is that the system seems the exact change proposed to
> be
> committed, complete with generated files, so enabling automated
> testing of
> patch proposals if desired.)
>
next prev parent reply other threads:[~2019-10-25 0:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:39 Setup non-pushing gerrit instance for glibc Carlos O'Donell
2019-10-24 21:41 ` Joseph Myers
2019-10-25 0:43 ` Ian Kent [this message]
2019-10-25 1:16 ` Jonathan Nieder
2019-10-25 10:21 ` Ian Kent
2019-10-25 1:02 ` Carlos O'Donell
2019-10-25 2:04 ` Sergio Durigan Junior
2019-10-25 3:14 ` Simon Marchi
2019-10-25 4:10 ` Simon Marchi
2019-10-25 14:48 ` Joseph Myers
2019-10-25 15:48 ` Simon Marchi
2019-10-25 16:10 ` Joseph Myers
2019-10-25 16:28 ` Simon Marchi
2019-10-25 1:25 ` Jonathan Nieder
2019-10-25 14:09 ` Florian Weimer
2019-10-25 15:18 ` Joseph Myers
2019-10-25 17:00 ` Sergio Durigan Junior
2019-10-25 20:33 ` Joseph Myers
2019-10-25 21:06 ` Sergio Durigan Junior
2019-10-25 21:13 ` Joseph Myers
2019-10-27 22:12 ` Sergio Durigan Junior
2019-10-28 17:58 ` Joseph Myers
2019-10-28 19:17 ` Jonathan Nieder
2019-10-28 22:59 ` Joseph Myers
2019-10-29 1:21 ` Sergio Durigan Junior
2019-10-25 22:03 ` Jonathan Nieder
2019-10-26 13:53 ` Carlos O'Donell
2019-10-30 18:25 ` Szabolcs Nagy
2019-11-12 18:53 ` Gabriel F. T. Gomes
2019-11-12 19:21 ` Carlos O'Donell
2019-11-12 19:59 ` Florian Weimer
2019-11-12 20:02 ` Jonathan Nieder
2019-11-12 21:10 ` Gabriel F. T. Gomes
2019-11-12 21:13 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580baf4ff0699a1eed12c2ea48f2162db639ad1c.camel@redhat.com \
--to=ikent@redhat.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).