From: Joseph Myers <joseph@codesourcery.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: Setup non-pushing gerrit instance for glibc.
Date: Mon, 28 Oct 2019 17:58:05 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1910281739380.20661@digraph.polyomino.org.uk> (raw)
In-Reply-To: <877e4pon1t.fsf@redhat.com>
On Sun, 27 Oct 2019, Sergio Durigan Junior wrote:
> When the GDB community decided to give gerrit a try, the main problem it
> was looking to solve was the "patches go missing" issue.
We have that problem in glibc, but we also have the problem of how to make
review as efficient for the reviewer as possible - enabling reviewing 100
patches a day, as Carlos said at the glibc BoF.
If reviewing a patch, or understanding the context for comments, requires
opening a browser tab and cutting and pasting a URL in there and clicking
around to find things on that page, that *reduces* my efficiency and
breaks up the flow of going through patches, bug reports and comments (on
various projects) that have come in over the time interval since I last
went through them, compared to simply having all the needed information in
an email in at least 90% of cases. Maybe there are 10% of cases where a
patch needs to break the flow anyway (e.g. if I suspect some issue but
need to do a build with the patch applied to test for it before replying).
But there are 90% of common cases that it should be possible to handle
properly by email if a few issues are fixed:
* Properly support emails with inline replies and the metadata at the
bottom of the email not quoted (only the relevant content replied to being
quoted). This means (a) attaching them to the right issue, based on
message-ids found in email headers and (b) not losing the quoted text
being replied to which is important to understanding the replies.
* Handle email replies to notifications of new patches, not just to
comments on them.
* Include diff hunks in emails with comments on changed code (we now have
more context in the code quoted, which is an improvement, but seeing the
actual *changes* being commented on, rather than just one version of the
code, is important to provide sufficient information in many cases).
Most of the time, an initial response to a bug report in Bugzilla does not
require opening a browser (the main pain point is dealing with attached
testcases, since Bugzilla doesn't attach those to emails). Reviewing and
cleaning up state for all open bugs in a particular area, via the web
interface, is a more occasional activity. The first two points above are
things that work just fine with email replies in Bugzilla (replying inline
to any Bugzilla message works fine without any special rules about what to
quote where); the third point isn't applicable there.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-10-28 17:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:39 Setup non-pushing gerrit instance for glibc Carlos O'Donell
2019-10-24 21:41 ` Joseph Myers
2019-10-25 0:43 ` Ian Kent
2019-10-25 1:16 ` Jonathan Nieder
2019-10-25 10:21 ` Ian Kent
2019-10-25 1:02 ` Carlos O'Donell
2019-10-25 2:04 ` Sergio Durigan Junior
2019-10-25 3:14 ` Simon Marchi
2019-10-25 4:10 ` Simon Marchi
2019-10-25 14:48 ` Joseph Myers
2019-10-25 15:48 ` Simon Marchi
2019-10-25 16:10 ` Joseph Myers
2019-10-25 16:28 ` Simon Marchi
2019-10-25 1:25 ` Jonathan Nieder
2019-10-25 14:09 ` Florian Weimer
2019-10-25 15:18 ` Joseph Myers
2019-10-25 17:00 ` Sergio Durigan Junior
2019-10-25 20:33 ` Joseph Myers
2019-10-25 21:06 ` Sergio Durigan Junior
2019-10-25 21:13 ` Joseph Myers
2019-10-27 22:12 ` Sergio Durigan Junior
2019-10-28 17:58 ` Joseph Myers [this message]
2019-10-28 19:17 ` Jonathan Nieder
2019-10-28 22:59 ` Joseph Myers
2019-10-29 1:21 ` Sergio Durigan Junior
2019-10-25 22:03 ` Jonathan Nieder
2019-10-26 13:53 ` Carlos O'Donell
2019-10-30 18:25 ` Szabolcs Nagy
2019-11-12 18:53 ` Gabriel F. T. Gomes
2019-11-12 19:21 ` Carlos O'Donell
2019-11-12 19:59 ` Florian Weimer
2019-11-12 20:02 ` Jonathan Nieder
2019-11-12 21:10 ` Gabriel F. T. Gomes
2019-11-12 21:13 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910281739380.20661@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).