From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: Setup non-pushing gerrit instance for glibc.
Date: Fri, 25 Oct 2019 17:06:25 -0400 [thread overview]
Message-ID: <87r230o7qm.fsf@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910252028040.7099@digraph.polyomino.org.uk> (Joseph Myers's message of "Fri, 25 Oct 2019 20:33:33 +0000")
On Friday, October 25 2019, Joseph Myers wrote:
> On Fri, 25 Oct 2019, Sergio Durigan Junior wrote:
>
>> Unfortunately, you do need to quote the content from the email footer.
>> I agree that gerrit should be able to keep track of Message-Id's and
>> match the replies using In-Reply-To, but unfortunately it doesn't do
>> that. It relies on the information present at the quoted footer to
>> determine which change the email refers to.
>
> If it doesn't work as well as Bugzilla at handling incoming email, it's
> probably not ready for serious use in glibc development (i.e. anyone
> submitting patches that way will need to watch for replies on the mailing
> list that don't get into gerrit's data, until gerrit's email handling is
> fixed). Is there an issue for fixing gerrit to handle emails quoting
> relevant context without the footer?
TBH, I wouldn't know right now. I haven't looked at gerrit's source
code to see how hard/feasible it would be to fix this.
What we can do is insert a message in the emails explaining that the
footer needs to be preserved when replying to it. We will also have to
warn the user that replying directly to a new change message will not
work; gerrit can only understand email replies to comments.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2019-10-25 21:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:39 Setup non-pushing gerrit instance for glibc Carlos O'Donell
2019-10-24 21:41 ` Joseph Myers
2019-10-25 0:43 ` Ian Kent
2019-10-25 1:16 ` Jonathan Nieder
2019-10-25 10:21 ` Ian Kent
2019-10-25 1:02 ` Carlos O'Donell
2019-10-25 2:04 ` Sergio Durigan Junior
2019-10-25 3:14 ` Simon Marchi
2019-10-25 4:10 ` Simon Marchi
2019-10-25 14:48 ` Joseph Myers
2019-10-25 15:48 ` Simon Marchi
2019-10-25 16:10 ` Joseph Myers
2019-10-25 16:28 ` Simon Marchi
2019-10-25 1:25 ` Jonathan Nieder
2019-10-25 14:09 ` Florian Weimer
2019-10-25 15:18 ` Joseph Myers
2019-10-25 17:00 ` Sergio Durigan Junior
2019-10-25 20:33 ` Joseph Myers
2019-10-25 21:06 ` Sergio Durigan Junior [this message]
2019-10-25 21:13 ` Joseph Myers
2019-10-27 22:12 ` Sergio Durigan Junior
2019-10-28 17:58 ` Joseph Myers
2019-10-28 19:17 ` Jonathan Nieder
2019-10-28 22:59 ` Joseph Myers
2019-10-29 1:21 ` Sergio Durigan Junior
2019-10-25 22:03 ` Jonathan Nieder
2019-10-26 13:53 ` Carlos O'Donell
2019-10-30 18:25 ` Szabolcs Nagy
2019-11-12 18:53 ` Gabriel F. T. Gomes
2019-11-12 19:21 ` Carlos O'Donell
2019-11-12 19:59 ` Florian Weimer
2019-11-12 20:02 ` Jonathan Nieder
2019-11-12 21:10 ` Gabriel F. T. Gomes
2019-11-12 21:13 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r230o7qm.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).