From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4706F1F4C0 for ; Fri, 25 Oct 2019 01:25:18 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=OA/2 MeSBnO4Qy0tEOCF31vWFMc/Mg1FtgEzfxgQmGTQ2Vf57rfr2hiCiFRjwCRdfO8Qr o4B6znp4VkTQwL8ietSY5HwAXTdXOsB86+jr6sDmM4iG+CP84gRGbv+Irea2Bzi+ pTesQQ1q3AKih52cWWVzztbos7TPsRHt69navq4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=eNBazRP6qc 9/0X6ejJA75HDuBKY=; b=d/fysvRUJIXYrWJVR0BiB+ImP5NoLbpf+jC2OgP5cy BZDRRqMYvCE1rkzU4GOvKcY82ial28IPvgu8rS7s2tEpRC1QX2IR9L6lVZrdWd0h vmBk2qCIgopiNnvAJWss/8/0mqpeRnKQk8mw9gXVCd+nD7uFy+abRdQRTbTMI4HA M= Received: (qmail 9071 invoked by alias); 25 Oct 2019 01:25:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9061 invoked by uid 89); 25 Oct 2019 01:25:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-pg1-f169.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nzkFagAHD4nA4xCYjUZXWCagPnwbZz1iusv8hSKLsAI=; b=dS+f/3LgqAYCmLFVAphjLQG+p8jIhdkOMEWq9RmyzxzEyn+u8NFLk2aj7ro8McabKM 2bfXpWw2V2EtQyzvFSEc7JxMKZGWjH141ecLwhdt+fqexkBTMmuBH9zjBSFb+G0mN/j7 9KL7l0+ivm/PvAQM4GpL3PmGDsLTxlcdKcXvezEcKvRwkkuDpvReXJYjrg6/7g6ftcH8 s6hBkTZ7B/TLGjZzfjuGE4RGkNiD3ML7+Y2Zwod+uFwHNXBGzDdQSKo98rYzwJ8juG6Q 6LzgRLgQISVgyAH8fwLoWC4A8u1S/XlliBp6KSFBrulOkLj7KlUeKChMq246VlffVVfO AYRQ== Date: Thu, 24 Oct 2019 18:25:09 -0700 From: Jonathan Nieder To: Joseph Myers Cc: Carlos O'Donell , libc-alpha Subject: Re: Setup non-pushing gerrit instance for glibc. Message-ID: <20191025012509.GB45423@google.com> References: <2e93ece9-386b-c587-9355-33a4695a3f02@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hi, A few quick notes from an ex Gerrit developer (nowadays almost all my time is devoted to Git instead). Joseph Myers wrote: > Observations on teething troubles with the initial setup: > > 1. What's the status of fixing the problem with insufficient diff context > in emails when comments relate to particular parts of the diff? A quick search doesn't find a bug open about this at https://crbug.com/gerrit/new. [...] > 2. Could text comments in emails from gerrit be properly wrapped? > Messages such as > are hard to > read in the list archives because of very long lines. (Of course, diff > context / quoted source lines should not be wrapped.) Makes sense. Likewise, I don't see an existing bug open for this. > 4. Could we document how to get and keep up to date a complete local copy > of all the glibc review data in gerrit (comments etc.) using whatever APIs > are available? "git clone --mirror" would do this --- the code for the 5th iteration of change #1234 is at refs/changes/34/1234/5, and the metadata (review comments, etc) is at refs/changes/34/1234/meta. See https://gerrit-review.googlesource.com/Documentation/concept-refs-for-namespace.html and https://gerrit-review.googlesource.com/Documentation/user-upload.html#_gritty_details for more on this subject. Alternatively you can do something with https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html, but that sounds fussier. [...] > 5. It would also be useful to have documentation for how someone should > make a patch series appear appropriately in gerrit if they want to propose > a series that way. That means the emails for a patch series should > include 1/N, 2/N etc. in their subjects (with a 0/N cover letter as > appropriate). I really like this idea. Feel free to file a feature request for it at https://crbug.com/gerrit/new. > 6. Lower priority, but note there are certain kinds of changes involving > huge diffs (e.g. to generated files) that thus *would* need a message size > limit and pointing to a URL for the diffs in that case, for it to be > possible to handle such changes through gerrit. The default behavior is to limit diffs to 256k: https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#sendemail.maximumDiffSize Thanks, Jonathan