git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
  2017-11-18  9:08  6%       ` 小川恭史
@ 2017-11-18 11:36  6%         ` Junio C Hamano
  0 siblings, 0 replies; 21+ results
From: Junio C Hamano @ 2017-11-18 11:36 UTC (permalink / raw)
  To: 小川恭史; +Cc: git

小川恭史 <aiueogawa217@gmail.com> writes:

> I upgraded the version of git from 2.13.1 to 2.15.0 on Mac and fixed my issue.
> Thanks.

Ah, yes, that bug was fixed in the 2.14.0 timeframe but was
backported to 2.13.2 and onwards (it was a bug in 2.13.0, I think).


^ permalink raw reply	[relevance 6%]

* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
  2017-11-18  7:56  5%     ` Junio C Hamano
@ 2017-11-18  9:08  6%       ` 小川恭史
  2017-11-18 11:36  6%         ` Junio C Hamano
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-11-18  9:08 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

I upgraded the version of git from 2.13.1 to 2.15.0 on Mac and fixed my issue.
Thanks.

2017-11-18 16:56 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>>> Please make it a habit (not limited to when interacting with
>>> _this_ project) to state a bit more than "does not work";
>>> instead, say "it is expected to do X, but instead it does Y, and
>>> the difference between X and Y I perceive is Z".
>>
>> Thanks. I'll rewrite the issue.
>>
>> Assuming that we have sub/something and something is not included anywhere else,
>>
>>         cd sub && git stash -- something
>>
>>  is expected to make a stash for sub/something but instead returns error like
>>
>>         error: pathspec 'something' did not match any file(s) known to git.
>>         Did you forget to 'git add'?
>>
>> .
>>
>> I don't know what I should write about 'the difference between X and Y is Z'.
>
> If the difference between X and Y is obvious there is no need.
>
> I just tried it and I do not see the command is broken in the way
> you describe.
>
> Trial #1 -- the command fully spelled out.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>Makefile
>     $ Documentation/master: git stash push -m "doc-make" -- Makefile
>     Saved working directory and index state On master: doc-make
>     $ Documentation/master: git stash show --stat
>      Documentation/Makefile | 1 +
>      1 file changed, 1 insertion(+:
>
> Trial #2 -- lazily issue the command without subcommand.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>Makefile
>     $ Documentation/master: git stash -- Makefile
>     Saved working directory and index state WIP on master: 89ea799ffc Sync with maint
>     $ Documentation/master: git stash show --stat
>      Documentation/Makefile | 1 +
>      1 file changed, 1 insertion(+:
>
> Trial #3 -- make sure having files with the same name is not hiding any bug.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>CodingGuidelines
>     $ Documentation/master: git stash -- CodingGuidelines
>     Saved working directory and index state WIP on master: 89ea799ffc
>     $ Documentation/master: git stash show --stat
>      Documentation/CodingGuidelines | 1 +
>       1 file changed, 1 insertion(+)
>
> Trial #4 -- simulate a PEBKAC
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>no-such-file
>     $ Documentation/master: git stash -- no-such-file
>     error: pathspec 'Documentation/no-such-file' did not match any file(s) known to git.
>     Did you forget to 'git add'?
>
> The last one is an expected result---the pathspec given to the
> command does not match anything tracked, so without first adding the
> file, there is nothing for the command to do.
>

^ permalink raw reply	[relevance 6%]

* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
  2017-11-18  4:12  6%   ` 小川恭史
@ 2017-11-18  7:56  5%     ` Junio C Hamano
  2017-11-18  9:08  6%       ` 小川恭史
  0 siblings, 1 reply; 21+ results
From: Junio C Hamano @ 2017-11-18  7:56 UTC (permalink / raw)
  To: 小川恭史; +Cc: git

小川恭史 <aiueogawa217@gmail.com> writes:

>> Please make it a habit (not limited to when interacting with
>> _this_ project) to state a bit more than "does not work";
>> instead, say "it is expected to do X, but instead it does Y, and
>> the difference between X and Y I perceive is Z".
>
> Thanks. I'll rewrite the issue.
>
> Assuming that we have sub/something and something is not included anywhere else,
>
>         cd sub && git stash -- something
>
>  is expected to make a stash for sub/something but instead returns error like
>
>         error: pathspec 'something' did not match any file(s) known to git.
>         Did you forget to 'git add'?
>
> .
>
> I don't know what I should write about 'the difference between X and Y is Z'.

If the difference between X and Y is obvious there is no need.  

I just tried it and I do not see the command is broken in the way
you describe.

Trial #1 -- the command fully spelled out.

    $ git.git/master: cd Documentation
    $ Documentation/master: echo >>Makefile
    $ Documentation/master: git stash push -m "doc-make" -- Makefile
    Saved working directory and index state On master: doc-make
    $ Documentation/master: git stash show --stat 
     Documentation/Makefile | 1 +
     1 file changed, 1 insertion(+:

Trial #2 -- lazily issue the command without subcommand.

    $ git.git/master: cd Documentation
    $ Documentation/master: echo >>Makefile
    $ Documentation/master: git stash -- Makefile
    Saved working directory and index state WIP on master: 89ea799ffc Sync with maint
    $ Documentation/master: git stash show --stat 
     Documentation/Makefile | 1 +
     1 file changed, 1 insertion(+:

Trial #3 -- make sure having files with the same name is not hiding any bug.

    $ git.git/master: cd Documentation
    $ Documentation/master: echo >>CodingGuidelines
    $ Documentation/master: git stash -- CodingGuidelines
    Saved working directory and index state WIP on master: 89ea799ffc
    $ Documentation/master: git stash show --stat
     Documentation/CodingGuidelines | 1 +
      1 file changed, 1 insertion(+)

Trial #4 -- simulate a PEBKAC

    $ git.git/master: cd Documentation
    $ Documentation/master: echo >>no-such-file
    $ Documentation/master: git stash -- no-such-file
    error: pathspec 'Documentation/no-such-file' did not match any file(s) known to git.
    Did you forget to 'git add'?

The last one is an expected result---the pathspec given to the
command does not match anything tracked, so without first adding the
file, there is nothing for the command to do.


^ permalink raw reply	[relevance 5%]

* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
  2017-11-18  3:53  6% ` Junio C Hamano
@ 2017-11-18  4:12  6%   ` 小川恭史
  2017-11-18  7:56  5%     ` Junio C Hamano
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-11-18  4:12 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

> Please make it a habit (not limited to when interacting with _this_
project) to state a bit more than "does not work"; instead, say "it
is expected to do X, but instead it does Y, and the difference
between X and Y I perceive is Z".

Thanks. I'll rewrite the issue.

Assuming that we have sub/something and something is not included anywhere else,

        cd sub && git stash -- something

 is expected to make a stash for sub/something but instead returns error like

        error: pathspec 'something' did not match any file(s) known to git.
        Did you forget to 'git add'?

.

I don't know what I should write about 'the difference between X and Y is Z'.

2017-11-18 12:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>> Is it not bug git stash -- <pathspec> does not work at non-root directory?
>
> Please make it a habit (not limited to when interacting with _this_
> project) to state a bit more than "does not work"; instead, say "it
> is expected to do X, but instead it does Y, and the difference
> between X and Y I perceive is Z".
>
> If you mean
>
>         cd sub && git stash -- Makefile
>
> does not make a stash for only sub/Makefile and instead makes (or
> attempts to make) a stash for only Makefile at the top-level, then
> I think it is a bug, whose likely cause is that the implementation
> forgets to prepend the $prefix to the pathspec it got from the
> command line.  But I am writing this without looking at the
> implementation and with your unclear description of the issue, so
> I may be completely off the mark ;-)
>
> Thanks.

^ permalink raw reply	[relevance 6%]

* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
  2017-11-18  3:37  6% Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
@ 2017-11-18  3:53  6% ` Junio C Hamano
  2017-11-18  4:12  6%   ` 小川恭史
  0 siblings, 1 reply; 21+ results
From: Junio C Hamano @ 2017-11-18  3:53 UTC (permalink / raw)
  To: 小川恭史; +Cc: git

小川恭史 <aiueogawa217@gmail.com> writes:

> Is it not bug git stash -- <pathspec> does not work at non-root directory?

Please make it a habit (not limited to when interacting with _this_
project) to state a bit more than "does not work"; instead, say "it
is expected to do X, but instead it does Y, and the difference
between X and Y I perceive is Z".

If you mean

	cd sub && git stash -- Makefile

does not make a stash for only sub/Makefile and instead makes (or
attempts to make) a stash for only Makefile at the top-level, then
I think it is a bug, whose likely cause is that the implementation
forgets to prepend the $prefix to the pathspec it got from the
command line.  But I am writing this without looking at the
implementation and with your unclear description of the issue, so
I may be completely off the mark ;-)

Thanks.

^ permalink raw reply	[relevance 6%]

* Is it not bug git stash -- <pathspec> does not work at non-root directory?
@ 2017-11-18  3:37  6% 小川恭史
  2017-11-18  3:53  6% ` Junio C Hamano
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-11-18  3:37 UTC (permalink / raw)
  To: git

Is it not bug git stash -- <pathspec> does not work at non-root directory?

^ permalink raw reply	[relevance 6%]

* Re: How can I debug git source code interactively with debugger like gdb?
  2017-10-18 19:42  6% How can I debug git source code interactively with debugger like gdb? 小川恭史
@ 2017-10-18 19:57  6% ` Stefan Beller
  0 siblings, 0 replies; 21+ results
From: Stefan Beller @ 2017-10-18 19:57 UTC (permalink / raw)
  To: 小川恭史; +Cc: git@vger.kernel.org

On Wed, Oct 18, 2017 at 12:42 PM, 小川恭史 <aiueogawa217@gmail.com> wrote:
> I wanna learn how daily git command works when I run specific git command.

1. Obtain the sources and compile Git yourself
    (git clone https://kernel.googlesource.com/pub/scm/git/git
     cd git && make && make install).
   Documentation/* and the Makefile are pretty verbose if you want
   to compile for some non-mainstream hardware or OS.
2. "gdb git" and debug away.
  Note, that some Git commands call other git commands,
  So running the command with "GIT_TRACE=1 git <cmd>"
  first may be helpful for diagnosis as well.
  (See the general git man page that has a couple of env vars
   that aid in debugging)

> I wanna know which function is actually called then, how variables
> changes its value, and how some object is stored into database.

For understanding Gits model, it may be easier to read a book, such
as "git from the bottom up" as that conveys the concepts better.

The source code is riddled with handling corner cases, error handling
and other implementation details that are usually not interesting but
rather tedious.

> How can I debug git source code interactively with debugger like gdb?

Also checkout ddd, a graphical frontend of gdb.

Cheers,
Stefan

^ permalink raw reply	[relevance 6%]

* How can I debug git source code interactively with debugger like gdb?
@ 2017-10-18 19:42  6% 小川恭史
  2017-10-18 19:57  6% ` Stefan Beller
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-10-18 19:42 UTC (permalink / raw)
  To: git

I wanna learn how daily git command works when I run specific git command.

I wanna know which function is actually called then, how variables
changes its value, and how some object is stored into database.

How can I debug git source code interactively with debugger like gdb?

^ permalink raw reply	[relevance 6%]

* Can I remove multiple stashed states at a time?
@ 2017-10-13  2:58  6% 小川恭史
  0 siblings, 0 replies; 21+ results
From: 小川恭史 @ 2017-10-13  2:58 UTC (permalink / raw)
  To: git

I want to remove multiple stashed states at a time.

But "git stash drop <stash>" removes only one stashed state at a time
and "git stash clear" remove all.

Can I do that?

^ permalink raw reply	[relevance 6%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
  2017-10-12  3:54  6%       ` 小川恭史
@ 2017-10-12  9:56  6%         ` Junio C Hamano
  0 siblings, 0 replies; 21+ results
From: Junio C Hamano @ 2017-10-12  9:56 UTC (permalink / raw)
  To: 小川恭史; +Cc: git, Takahito Ogawa

小川恭史 <aiueogawa217@gmail.com> writes:

> As you point,
>
>     git stash
>
> without any argument is equivalent to both of
>
>     git stash save
>     git stash push
>
> . The original sentence is correct.

OK.  

Note that I was merely reacting to "Correct it." in your
justification for the change, which made it sound like 'save' was
incorrect.

As a part of a move to deprecate 'save' and nudge users towards
'push', the change does make sense.  I just wanted to make sure the
change and its motivation are presented with honesty ;-).


^ permalink raw reply	[relevance 6%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
  2017-10-12  3:52 12%     ` 小川恭史
@ 2017-10-12  3:54  6%       ` 小川恭史
  2017-10-12  9:56  6%         ` Junio C Hamano
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-10-12  3:54 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Takahito Ogawa

As you point,

    git stash

without any argument is equivalent to both of

    git stash save
    git stash push

. The original sentence is correct.

^ permalink raw reply	[relevance 6%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
       [not found]       ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
@ 2017-10-12  3:52 12%     ` 小川恭史
  2017-10-12  3:54  6%       ` 小川恭史
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-10-12  3:52 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Takahito Ogawa

As you point,

    git stash

without any argument is equivalent to both of

    git stash save
    git stash push

. The original sentence is correct.

2017-10-12 12:31 GMT+09:00 小川恭史 <aiueogawa217@gmail.com>:
> As you point,
>
>     git stash
>
> without any argument is equivalent to both of
> git stash save and
>
>
> 2017-10-12 9:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
>> Takahito Ogawa <aiueogawa217@gmail.com> writes:
>>
>>> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD`
>>> commit.
>>>  The modifications stashed away by this command can be listed with
>>>  `git stash list`, inspected with `git stash show`, and restored
>>>  (potentially on top of a different commit) with `git stash apply`.
>>> -Calling `git stash` without any arguments is equivalent to `git stash
>>> save`.
>>> +Calling `git stash` without any arguments is equivalent to `git stash
>>> push`.
>>
>> Hmph.  Is there any difference between
>>
>>         git stash save
>>         git stash push
>>
>> without any other argument?  Aren't they equivalent to
>>
>>         git stash
>>
>> without any argument, which is what this sentence explains?
>>
>

^ permalink raw reply	[relevance 12%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
  2017-10-11 18:03  6% [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
@ 2017-10-12  0:53  6% ` Junio C Hamano
       [not found]       ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
  0 siblings, 1 reply; 21+ results
From: Junio C Hamano @ 2017-10-12  0:53 UTC (permalink / raw)
  To: Takahito Ogawa; +Cc: git, Takahito Ogawa

Takahito Ogawa <aiueogawa217@gmail.com> writes:

> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
>  The modifications stashed away by this command can be listed with
>  `git stash list`, inspected with `git stash show`, and restored
>  (potentially on top of a different commit) with `git stash apply`.
> -Calling `git stash` without any arguments is equivalent to `git stash save`.
> +Calling `git stash` without any arguments is equivalent to `git stash push`.

Hmph.  Is there any difference between

	git stash save
	git stash push

without any other argument?  Aren't they equivalent to

	git stash

without any argument, which is what this sentence explains?


^ permalink raw reply	[relevance 6%]

* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 20:01 21% Takahito Ogawa
  0 siblings, 0 replies; 21+ results
From: Takahito Ogawa @ 2017-10-11 20:01 UTC (permalink / raw)
  To: gitster; +Cc: git, Takahito Ogawa

"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but documents says
"git stash save".

Correct it.

Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
---
 Documentation/git-stash.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
 The modifications stashed away by this command can be listed with
 `git stash list`, inspected with `git stash show`, and restored
 (potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
 A stash is by default listed as "WIP on 'branchname' ...", but
 you can give a more descriptive message on the command line when
 you create one.
-- 
2.13.1


^ permalink raw reply related	[relevance 21%]

* Re: Fwd: how can I conform if I succeed in sending patch to mailing list
  2017-10-11 19:14  6% ` Fwd: how can I conform if I succeed in sending patch to mailing list 小川恭史
@ 2017-10-11 19:23  8%   ` Jonathan Tan
  0 siblings, 0 replies; 21+ results
From: Jonathan Tan @ 2017-10-11 19:23 UTC (permalink / raw)
  To: 小川恭史; +Cc: git

On Thu, 12 Oct 2017 04:14:18 +0900
小川恭史 <aiueogawa217@gmail.com> wrote:

> Hello, I found a mistake in documents, fixed it, and send patch to mailing list.
> 
> Sending patches by 'git send-email' with Gmail smtp seemed to be
> successful because CC included my email address and I received it.
> However, I never received email from mailing list. Of course I'm
> subscribing mailing list.
> 
> How can I conform if I succeed in sending patch to mailing list?

The easiest way I can think of is to check an online mailing list
archive [1].

I think your patch was received, as you can see in [2].

[1] for example, https://public-inbox.org/git/

[2] https://public-inbox.org/git/?q=aiueogawa217

^ permalink raw reply	[relevance 8%]

* Fwd: how can I conform if I succeed in sending patch to mailing list
       [not found]     <CAC2JkrLfcUzipRPhUHiVEMipsPVcia6ku+QK7OwMJrME-JtAzQ@mail.gmail.com>
@ 2017-10-11 19:14  6% ` 小川恭史
  2017-10-11 19:23  8%   ` Jonathan Tan
  0 siblings, 1 reply; 21+ results
From: 小川恭史 @ 2017-10-11 19:14 UTC (permalink / raw)
  To: git

Hello, I found a mistake in documents, fixed it, and send patch to mailing list.

Sending patches by 'git send-email' with Gmail smtp seemed to be
successful because CC included my email address and I received it.
However, I never received email from mailing list. Of course I'm
subscribing mailing list.

How can I conform if I succeed in sending patch to mailing list?

Takahito Ogawa

^ permalink raw reply	[relevance 6%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
  2017-10-11 19:09  0% ` Thomas Gummerer
@ 2017-10-11 19:12  0%   ` Thomas Gummerer
  0 siblings, 0 replies; 21+ results
From: Thomas Gummerer @ 2017-10-11 19:12 UTC (permalink / raw)
  To: Takahito Ogawa; +Cc: git

On 10/11, Thomas Gummerer wrote:
> On 10/12, Takahito Ogawa wrote:
> > "git stash" behavior without any arguments was changed in
> > 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> > This is equivalent to "git stash push" but documents says
> > "git stash save".
> > 
> > Correct it.
> 
> Thanks for fixing this!  I recently sent a patch that would advertise
> git stash push more in general, which would also fix this occurrence [1], 
> but it didn't seem like it got much interest.  However this is
> obviously correct, and should definitely be fixed, while the other
> places can still mention 'git stash save'.
> 
> For what it's worth this is
> 
> Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>

And I forgot to include the link, sorry.  Here it is:

[1]: https://public-inbox.org/git/20171005200049.GF30301@hank/

> 
> > Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> > ---
> >  Documentation/git-stash.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> > index 00f95fee1..63642c145 100644
> > --- a/Documentation/git-stash.txt
> > +++ b/Documentation/git-stash.txt
> > @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
> >  The modifications stashed away by this command can be listed with
> >  `git stash list`, inspected with `git stash show`, and restored
> >  (potentially on top of a different commit) with `git stash apply`.
> > -Calling `git stash` without any arguments is equivalent to `git stash save`.
> > +Calling `git stash` without any arguments is equivalent to `git stash push`.
> >  A stash is by default listed as "WIP on 'branchname' ...", but
> >  you can give a more descriptive message on the command line when
> >  you create one.
> > -- 
> > 2.13.1
> > 

^ permalink raw reply	[relevance 0%]

* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
  2017-10-11 18:37 21% Takahito Ogawa
@ 2017-10-11 19:09  0% ` Thomas Gummerer
  2017-10-11 19:12  0%   ` Thomas Gummerer
  0 siblings, 1 reply; 21+ results
From: Thomas Gummerer @ 2017-10-11 19:09 UTC (permalink / raw)
  To: Takahito Ogawa; +Cc: git

On 10/12, Takahito Ogawa wrote:
> "git stash" behavior without any arguments was changed in
> 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> This is equivalent to "git stash push" but documents says
> "git stash save".
> 
> Correct it.

Thanks for fixing this!  I recently sent a patch that would advertise
git stash push more in general, which would also fix this occurrence [1], 
but it didn't seem like it got much interest.  However this is
obviously correct, and should definitely be fixed, while the other
places can still mention 'git stash save'.

For what it's worth this is

Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>


> Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> ---
>  Documentation/git-stash.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> index 00f95fee1..63642c145 100644
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
>  The modifications stashed away by this command can be listed with
>  `git stash list`, inspected with `git stash show`, and restored
>  (potentially on top of a different commit) with `git stash apply`.
> -Calling `git stash` without any arguments is equivalent to `git stash save`.
> +Calling `git stash` without any arguments is equivalent to `git stash push`.
>  A stash is by default listed as "WIP on 'branchname' ...", but
>  you can give a more descriptive message on the command line when
>  you create one.
> -- 
> 2.13.1
> 

^ permalink raw reply	[relevance 0%]

* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:37 21% Takahito Ogawa
  2017-10-11 19:09  0% ` Thomas Gummerer
  0 siblings, 1 reply; 21+ results
From: Takahito Ogawa @ 2017-10-11 18:37 UTC (permalink / raw)
  To: git; +Cc: Takahito Ogawa

"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but documents says
"git stash save".

Correct it.

Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
---
 Documentation/git-stash.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
 The modifications stashed away by this command can be listed with
 `git stash list`, inspected with `git stash show`, and restored
 (potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
 A stash is by default listed as "WIP on 'branchname' ...", but
 you can give a more descriptive message on the command line when
 you create one.
-- 
2.13.1


^ permalink raw reply related	[relevance 21%]

* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:06  6% Takahito Ogawa
  0 siblings, 0 replies; 21+ results
From: Takahito Ogawa @ 2017-10-11 18:06 UTC (permalink / raw)
  To: git; +Cc: Takahito Ogawa

"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but document says
"git stash save".

Correct it.

Signed-off-by: Takahito Ogawa <takahito.ogawa@datagrid.co.jp>
---
 Documentation/git-stash.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
 The modifications stashed away by this command can be listed with
 `git stash list`, inspected with `git stash show`, and restored
 (potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
 A stash is by default listed as "WIP on 'branchname' ...", but
 you can give a more descriptive message on the command line when
 you create one.
-- 
2.13.1


^ permalink raw reply related	[relevance 6%]

* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:03  6% Takahito Ogawa
  2017-10-12  0:53  6% ` Junio C Hamano
  0 siblings, 1 reply; 21+ results
From: Takahito Ogawa @ 2017-10-11 18:03 UTC (permalink / raw)
  To: git; +Cc: Takahito Ogawa

"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but document says
"git stash save".

Correct it.

Signed-off-by: Takahito Ogawa <takahito.ogawa@datagrid.co.jp>
---
 Documentation/git-stash.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
 The modifications stashed away by this command can be listed with
 `git stash list`, inspected with `git stash show`, and restored
 (potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
 A stash is by default listed as "WIP on 'branchname' ...", but
 you can give a more descriptive message on the command line when
 you create one.
-- 
2.13.1


^ permalink raw reply related	[relevance 6%]

Results 1-21 of 21 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2017-10-11 18:03  6% [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-12  0:53  6% ` Junio C Hamano
     [not found]       ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
2017-10-12  3:52 12%     ` 小川恭史
2017-10-12  3:54  6%       ` 小川恭史
2017-10-12  9:56  6%         ` Junio C Hamano
2017-10-11 18:06  6% Takahito Ogawa
2017-10-11 18:37 21% Takahito Ogawa
2017-10-11 19:09  0% ` Thomas Gummerer
2017-10-11 19:12  0%   ` Thomas Gummerer
     [not found]     <CAC2JkrLfcUzipRPhUHiVEMipsPVcia6ku+QK7OwMJrME-JtAzQ@mail.gmail.com>
2017-10-11 19:14  6% ` Fwd: how can I conform if I succeed in sending patch to mailing list 小川恭史
2017-10-11 19:23  8%   ` Jonathan Tan
2017-10-11 20:01 21% [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-13  2:58  6% Can I remove multiple stashed states at a time? 小川恭史
2017-10-18 19:42  6% How can I debug git source code interactively with debugger like gdb? 小川恭史
2017-10-18 19:57  6% ` Stefan Beller
2017-11-18  3:37  6% Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
2017-11-18  3:53  6% ` Junio C Hamano
2017-11-18  4:12  6%   ` 小川恭史
2017-11-18  7:56  5%     ` Junio C Hamano
2017-11-18  9:08  6%       ` 小川恭史
2017-11-18 11:36  6%         ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).