git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: 小川恭史 <aiueogawa217@gmail.com>
Cc: git@vger.kernel.org, Takahito Ogawa <takahito.ogawa@datagrid.co.jp>
Subject: Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
Date: Thu, 12 Oct 2017 18:56:11 +0900
Message-ID: <xmqqsheozo3o.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAC2JkrL01G-j+Dxbog9Lq95OKsLpVv6OjV=qg4h0-nwneZ+Oog@mail.gmail.com>

小川恭史 <aiueogawa217@gmail.com> writes:

> As you point,
>
>     git stash
>
> without any argument is equivalent to both of
>
>     git stash save
>     git stash push
>
> . The original sentence is correct.

OK.  

Note that I was merely reacting to "Correct it." in your
justification for the change, which made it sound like 'save' was
incorrect.

As a part of a move to deprecate 'save' and nudge users towards
'push', the change does make sense.  I just wanted to make sure the
change and its motivation are presented with honesty ;-).


  reply index

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <y>
2008-12-02 21:20 ` [JGIT PATCH 1/2] Close a forgotten reference to the HEAD ref Robin Rosenberg
2008-12-02 21:20   ` [JGIT PATCH 2/2] Improve closing of files in error situations Robin Rosenberg
2009-06-07 20:19 ` [EGIT PATCH 0/3] Ref log reader Robin Rosenberg
2009-06-07 20:19   ` [EGIT PATCH 1/3] Assert the name and origName properties of Ref objects Robin Rosenberg
2009-06-07 20:19     ` [EGIT PATCH 2/3] Add methods to RawParseUtils for scanning backwards Robin Rosenberg
2009-06-07 20:19       ` [EGIT PATCH 3/3] Add a ref log reader class Robin Rosenberg
2009-06-07 22:21         ` Shawn O. Pearce
2009-06-07 22:45           ` Robin Rosenberg
2009-06-07 22:47             ` Shawn O. Pearce
2009-06-08 17:28               ` [EGIT PATCH 1/2] Add methods to RawParseUtils for scanning backwards Robin Rosenberg
2009-06-08 17:28                 ` [EGIT PATCH 2/2] Add a ref log reader class Robin Rosenberg
2009-06-12 19:52                   ` Shawn O. Pearce
2009-06-15 21:25                     ` [EGIT PATCH 1/2] Use a UTC relative time zone for PersonIdent Robin Rosenberg
2009-06-15 21:25                       ` [EGIT PATCH 2/2] Add a ref log reader class Robin Rosenberg
2009-06-15 22:21                         ` Robin Rosenberg
2009-06-22 11:49 ` [BUG] apply: test for trailing whitespace & no new line bug y
2009-06-22 11:49 ` y
2010-07-08 15:12 ` [PATCH] diff.c: fix a graph output bug struggleyb.nku
2010-07-09  0:15   ` Junio C Hamano
2010-07-09  0:57     ` Junio C Hamano
2010-07-09  1:04       ` Nazri Ramliy
2010-07-09  1:09         ` Junio C Hamano
2010-07-11  6:10       ` Bo Yang
2010-10-07  4:46 ` [PATCH 1/2] setup.c: add enter_work_tree() pclouds
2010-10-07  4:46 ` [PATCH 2/2] worktree: provide better prefix to go back to original cwd pclouds
2010-10-07  5:53   ` Nguyen Thai Ngoc Duy
2010-10-07  5:54   ` Junio C Hamano
2010-10-07  7:20     ` Nguyen Thai Ngoc Duy
2010-10-07 14:56       ` Junio C Hamano
2010-10-07 15:11         ` Nguyen Thai Ngoc Duy
2010-11-23  2:32 ` [PATCH] Corrected cmitmode set in the right lower window when initiating a diff Michał Pomorski
2011-04-07  6:01 ` [PATCH] git-p4: replace each tab with 8 spaces for consistency Andrew Garber
2011-04-07  7:36   ` Junio C Hamano
2011-04-07 16:35     ` Phil Hord
2011-04-07 18:45       ` Junio C Hamano
2011-04-07  6:01 ` Andrew Garber
2012-06-04 19:15 ` [PATCH/RFC] file import functionality for git-remote-mw Pavel Volek
2012-06-04 20:49 ` [PATCH/RFC] Export file attachements in git-remote-mediawiki NGUYEN Kim Thuat
2012-06-04 21:34   ` Matthieu Moy
2012-06-05 17:00     ` nguyenki
2012-06-05 17:05       ` Matthieu Moy
2012-06-06 22:25         ` nguyenki
2012-06-05 17:11     ` nguyenki
2012-06-08 13:27 ` [PATCHv1] Export file " Kim Thuat NGUYEN
2012-06-08 14:07   ` Matthieu Moy
2012-06-08 22:59     ` nguyenki
2012-06-10 13:01       ` Matthieu Moy
2012-06-12 12:46 ` [PATCHv2] git-remote-mediawiki: export File: attachments Kim Thuat NGUYEN
2012-06-12 12:52   ` Matthieu Moy
2012-06-12 12:54   ` nguyenki
2012-06-12 13:51   ` Max Horn
2012-06-13  7:56 ` [PATCHv3] " kim-thuat.nguyen
     [not found] ` <1357885869-20815-1-git-send-email-cyliu@suse.com>
     [not found]   ` <50EFD066.60501@redhat.com>
2013-01-11 16:39     ` git send-email should not allow 'y' for in-reply-to Eric Blake
2013-01-11 16:47       ` Jeff King
2013-01-11 17:51         ` Eric Blake
2013-01-11 18:43         ` Hilco Wijbenga
2013-01-11 18:54           ` Jeff King
2013-02-24  9:03             ` Junio C Hamano
2013-06-10 15:13 ` v3 [PATCH 1/2] status: introduce status.short to enable --short by default y
2013-06-10 15:13   ` v3 [PATCH 2/2] status:introduce status.branch to enable --branch " y
2013-06-10 15:13   ` y
2013-06-10 15:20   ` v3 [PATCH 1/2] status: introduce status.short to enable --short " Matthieu Moy
2013-06-10 15:13 ` y
2014-01-29 13:33 ` [PATCH 3/3] builtin/blame.c: reduce scope of variables Elia Pinto
2014-03-05 19:29 ` [PATCH] use strchrnul() in place of strchr() and strlen() Rohit Mani
2014-03-08  6:48 ` [GSoC][PATCH v2] " Rohit Mani
2014-03-10 19:04 ` [PATCH][GSOC2014] TamerTas
     [not found] ` <1394478262-17911-1-git-send-email-tamertas@outlook.com>
2014-03-10 19:04   ` [PATCH][GSOC2014] changed logical chain in branch.c to lookup tables TamerTas
2014-03-10 21:05     ` Stefan Beller
2014-03-10 21:25     ` Eric Sunshine
2014-03-10 21:47       ` Tamer TAS
2014-03-10 22:39         ` Eric Sunshine
2014-03-11 11:33           ` Tamer TAS
2014-03-11 20:32             ` Eric Sunshine
2014-03-18 12:31 ` [PATCH][GSOC2014] add: Rewrite run_add_interactive to use struct argv_array Movchan Pavel
2016-06-09 17:46 ` [PATCH] Use "working tree" instead of "working directory" for git status Lars Vogel
2016-06-09 17:55   ` Eric Sunshine
2016-06-09 18:21     ` Lars Vogel
2017-10-11 18:03 ` [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-12  0:53   ` Junio C Hamano
     [not found]     ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
2017-10-12  3:52       ` 小川恭史
2017-10-12  3:54         ` 小川恭史
2017-10-12  9:56           ` Junio C Hamano [this message]
     [not found] <n>
2017-10-11 18:06 ` Takahito Ogawa
2017-10-11 18:37 ` Takahito Ogawa
2017-10-11 19:09   ` Thomas Gummerer
2017-10-11 19:12     ` Thomas Gummerer
2017-10-11 20:01 ` Takahito Ogawa

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsheozo3o.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=aiueogawa217@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=takahito.ogawa@datagrid.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox