From: Thomas Gummerer <t.gummerer@gmail.com>
To: Takahito Ogawa <aiueogawa217@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
Date: Wed, 11 Oct 2017 20:12:14 +0100 [thread overview]
Message-ID: <20171011191214.GB15399@hank> (raw)
In-Reply-To: <20171011190935.GA15399@hank>
On 10/11, Thomas Gummerer wrote:
> On 10/12, Takahito Ogawa wrote:
> > "git stash" behavior without any arguments was changed in
> > 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> > This is equivalent to "git stash push" but documents says
> > "git stash save".
> >
> > Correct it.
>
> Thanks for fixing this! I recently sent a patch that would advertise
> git stash push more in general, which would also fix this occurrence [1],
> but it didn't seem like it got much interest. However this is
> obviously correct, and should definitely be fixed, while the other
> places can still mention 'git stash save'.
>
> For what it's worth this is
>
> Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
And I forgot to include the link, sorry. Here it is:
[1]: https://public-inbox.org/git/20171005200049.GF30301@hank/
>
> > Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> > ---
> > Documentation/git-stash.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> > index 00f95fee1..63642c145 100644
> > --- a/Documentation/git-stash.txt
> > +++ b/Documentation/git-stash.txt
> > @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
> > The modifications stashed away by this command can be listed with
> > `git stash list`, inspected with `git stash show`, and restored
> > (potentially on top of a different commit) with `git stash apply`.
> > -Calling `git stash` without any arguments is equivalent to `git stash save`.
> > +Calling `git stash` without any arguments is equivalent to `git stash push`.
> > A stash is by default listed as "WIP on 'branchname' ...", but
> > you can give a more descriptive message on the command line when
> > you create one.
> > --
> > 2.13.1
> >
next prev parent reply other threads:[~2017-10-11 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 18:37 [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-11 19:09 ` Thomas Gummerer
2017-10-11 19:12 ` Thomas Gummerer [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 20:01 Takahito Ogawa
2017-10-11 18:06 Takahito Ogawa
2017-10-11 18:03 Takahito Ogawa
2017-10-12 0:53 ` Junio C Hamano
[not found] ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
2017-10-12 3:52 ` 小川恭史
2017-10-12 3:54 ` 小川恭史
2017-10-12 9:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011191214.GB15399@hank \
--to=t.gummerer@gmail.com \
--cc=aiueogawa217@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).