git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: 小川恭史 <aiueogawa217@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
Date: Sat, 18 Nov 2017 12:53:05 +0900	[thread overview]
Message-ID: <xmqqzi7kp7j2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAC2Jkr+brEKLy-z45WwP2iqssA14na9xpaCoKrNKbPcTvtUxJA@mail.gmail.com> ("小川恭史"'s message of "Sat, 18 Nov 2017 12:37:01 +0900")

小川恭史 <aiueogawa217@gmail.com> writes:

> Is it not bug git stash -- <pathspec> does not work at non-root directory?

Please make it a habit (not limited to when interacting with _this_
project) to state a bit more than "does not work"; instead, say "it
is expected to do X, but instead it does Y, and the difference
between X and Y I perceive is Z".

If you mean

	cd sub && git stash -- Makefile

does not make a stash for only sub/Makefile and instead makes (or
attempts to make) a stash for only Makefile at the top-level, then
I think it is a bug, whose likely cause is that the implementation
forgets to prepend the $prefix to the pathspec it got from the
command line.  But I am writing this without looking at the
implementation and with your unclear description of the issue, so
I may be completely off the mark ;-)

Thanks.

  reply	other threads:[~2017-11-18  3:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  3:37 Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
2017-11-18  3:53 ` Junio C Hamano [this message]
2017-11-18  4:12   ` 小川恭史
2017-11-18  7:56     ` Junio C Hamano
2017-11-18  9:08       ` 小川恭史
2017-11-18 11:36         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzi7kp7j2.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=aiueogawa217@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).