git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: 小川恭史 <aiueogawa217@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
Date: Sat, 18 Nov 2017 18:08:37 +0900	[thread overview]
Message-ID: <CAC2Jkr+TkqnZ+rZVxZNv80rpJHf-BBNZqXZqW+hBVZ8hRrPRSw@mail.gmail.com> (raw)
In-Reply-To: <xmqqmv3kow92.fsf@gitster.mtv.corp.google.com>

I upgraded the version of git from 2.13.1 to 2.15.0 on Mac and fixed my issue.
Thanks.

2017-11-18 16:56 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>>> Please make it a habit (not limited to when interacting with
>>> _this_ project) to state a bit more than "does not work";
>>> instead, say "it is expected to do X, but instead it does Y, and
>>> the difference between X and Y I perceive is Z".
>>
>> Thanks. I'll rewrite the issue.
>>
>> Assuming that we have sub/something and something is not included anywhere else,
>>
>>         cd sub && git stash -- something
>>
>>  is expected to make a stash for sub/something but instead returns error like
>>
>>         error: pathspec 'something' did not match any file(s) known to git.
>>         Did you forget to 'git add'?
>>
>> .
>>
>> I don't know what I should write about 'the difference between X and Y is Z'.
>
> If the difference between X and Y is obvious there is no need.
>
> I just tried it and I do not see the command is broken in the way
> you describe.
>
> Trial #1 -- the command fully spelled out.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>Makefile
>     $ Documentation/master: git stash push -m "doc-make" -- Makefile
>     Saved working directory and index state On master: doc-make
>     $ Documentation/master: git stash show --stat
>      Documentation/Makefile | 1 +
>      1 file changed, 1 insertion(+:
>
> Trial #2 -- lazily issue the command without subcommand.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>Makefile
>     $ Documentation/master: git stash -- Makefile
>     Saved working directory and index state WIP on master: 89ea799ffc Sync with maint
>     $ Documentation/master: git stash show --stat
>      Documentation/Makefile | 1 +
>      1 file changed, 1 insertion(+:
>
> Trial #3 -- make sure having files with the same name is not hiding any bug.
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>CodingGuidelines
>     $ Documentation/master: git stash -- CodingGuidelines
>     Saved working directory and index state WIP on master: 89ea799ffc
>     $ Documentation/master: git stash show --stat
>      Documentation/CodingGuidelines | 1 +
>       1 file changed, 1 insertion(+)
>
> Trial #4 -- simulate a PEBKAC
>
>     $ git.git/master: cd Documentation
>     $ Documentation/master: echo >>no-such-file
>     $ Documentation/master: git stash -- no-such-file
>     error: pathspec 'Documentation/no-such-file' did not match any file(s) known to git.
>     Did you forget to 'git add'?
>
> The last one is an expected result---the pathspec given to the
> command does not match anything tracked, so without first adding the
> file, there is nothing for the command to do.
>

  reply	other threads:[~2017-11-18  9:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  3:37 Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
2017-11-18  3:53 ` Junio C Hamano
2017-11-18  4:12   ` 小川恭史
2017-11-18  7:56     ` Junio C Hamano
2017-11-18  9:08       ` 小川恭史 [this message]
2017-11-18 11:36         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC2Jkr+TkqnZ+rZVxZNv80rpJHf-BBNZqXZqW+hBVZ8hRrPRSw@mail.gmail.com \
    --to=aiueogawa217@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).