* Is it not bug git stash -- <pathspec> does not work at non-root directory?
@ 2017-11-18 3:37 小川恭史
2017-11-18 3:53 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: 小川恭史 @ 2017-11-18 3:37 UTC (permalink / raw)
To: git
Is it not bug git stash -- <pathspec> does not work at non-root directory?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
2017-11-18 3:37 Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
@ 2017-11-18 3:53 ` Junio C Hamano
2017-11-18 4:12 ` 小川恭史
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2017-11-18 3:53 UTC (permalink / raw)
To: 小川恭史; +Cc: git
小川恭史 <aiueogawa217@gmail.com> writes:
> Is it not bug git stash -- <pathspec> does not work at non-root directory?
Please make it a habit (not limited to when interacting with _this_
project) to state a bit more than "does not work"; instead, say "it
is expected to do X, but instead it does Y, and the difference
between X and Y I perceive is Z".
If you mean
cd sub && git stash -- Makefile
does not make a stash for only sub/Makefile and instead makes (or
attempts to make) a stash for only Makefile at the top-level, then
I think it is a bug, whose likely cause is that the implementation
forgets to prepend the $prefix to the pathspec it got from the
command line. But I am writing this without looking at the
implementation and with your unclear description of the issue, so
I may be completely off the mark ;-)
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
2017-11-18 3:53 ` Junio C Hamano
@ 2017-11-18 4:12 ` 小川恭史
2017-11-18 7:56 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: 小川恭史 @ 2017-11-18 4:12 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
> Please make it a habit (not limited to when interacting with _this_
project) to state a bit more than "does not work"; instead, say "it
is expected to do X, but instead it does Y, and the difference
between X and Y I perceive is Z".
Thanks. I'll rewrite the issue.
Assuming that we have sub/something and something is not included anywhere else,
cd sub && git stash -- something
is expected to make a stash for sub/something but instead returns error like
error: pathspec 'something' did not match any file(s) known to git.
Did you forget to 'git add'?
.
I don't know what I should write about 'the difference between X and Y is Z'.
2017-11-18 12:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>> Is it not bug git stash -- <pathspec> does not work at non-root directory?
>
> Please make it a habit (not limited to when interacting with _this_
> project) to state a bit more than "does not work"; instead, say "it
> is expected to do X, but instead it does Y, and the difference
> between X and Y I perceive is Z".
>
> If you mean
>
> cd sub && git stash -- Makefile
>
> does not make a stash for only sub/Makefile and instead makes (or
> attempts to make) a stash for only Makefile at the top-level, then
> I think it is a bug, whose likely cause is that the implementation
> forgets to prepend the $prefix to the pathspec it got from the
> command line. But I am writing this without looking at the
> implementation and with your unclear description of the issue, so
> I may be completely off the mark ;-)
>
> Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
2017-11-18 4:12 ` 小川恭史
@ 2017-11-18 7:56 ` Junio C Hamano
2017-11-18 9:08 ` 小川恭史
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2017-11-18 7:56 UTC (permalink / raw)
To: 小川恭史; +Cc: git
小川恭史 <aiueogawa217@gmail.com> writes:
>> Please make it a habit (not limited to when interacting with
>> _this_ project) to state a bit more than "does not work";
>> instead, say "it is expected to do X, but instead it does Y, and
>> the difference between X and Y I perceive is Z".
>
> Thanks. I'll rewrite the issue.
>
> Assuming that we have sub/something and something is not included anywhere else,
>
> cd sub && git stash -- something
>
> is expected to make a stash for sub/something but instead returns error like
>
> error: pathspec 'something' did not match any file(s) known to git.
> Did you forget to 'git add'?
>
> .
>
> I don't know what I should write about 'the difference between X and Y is Z'.
If the difference between X and Y is obvious there is no need.
I just tried it and I do not see the command is broken in the way
you describe.
Trial #1 -- the command fully spelled out.
$ git.git/master: cd Documentation
$ Documentation/master: echo >>Makefile
$ Documentation/master: git stash push -m "doc-make" -- Makefile
Saved working directory and index state On master: doc-make
$ Documentation/master: git stash show --stat
Documentation/Makefile | 1 +
1 file changed, 1 insertion(+:
Trial #2 -- lazily issue the command without subcommand.
$ git.git/master: cd Documentation
$ Documentation/master: echo >>Makefile
$ Documentation/master: git stash -- Makefile
Saved working directory and index state WIP on master: 89ea799ffc Sync with maint
$ Documentation/master: git stash show --stat
Documentation/Makefile | 1 +
1 file changed, 1 insertion(+:
Trial #3 -- make sure having files with the same name is not hiding any bug.
$ git.git/master: cd Documentation
$ Documentation/master: echo >>CodingGuidelines
$ Documentation/master: git stash -- CodingGuidelines
Saved working directory and index state WIP on master: 89ea799ffc
$ Documentation/master: git stash show --stat
Documentation/CodingGuidelines | 1 +
1 file changed, 1 insertion(+)
Trial #4 -- simulate a PEBKAC
$ git.git/master: cd Documentation
$ Documentation/master: echo >>no-such-file
$ Documentation/master: git stash -- no-such-file
error: pathspec 'Documentation/no-such-file' did not match any file(s) known to git.
Did you forget to 'git add'?
The last one is an expected result---the pathspec given to the
command does not match anything tracked, so without first adding the
file, there is nothing for the command to do.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
2017-11-18 7:56 ` Junio C Hamano
@ 2017-11-18 9:08 ` 小川恭史
2017-11-18 11:36 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: 小川恭史 @ 2017-11-18 9:08 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
I upgraded the version of git from 2.13.1 to 2.15.0 on Mac and fixed my issue.
Thanks.
2017-11-18 16:56 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>>> Please make it a habit (not limited to when interacting with
>>> _this_ project) to state a bit more than "does not work";
>>> instead, say "it is expected to do X, but instead it does Y, and
>>> the difference between X and Y I perceive is Z".
>>
>> Thanks. I'll rewrite the issue.
>>
>> Assuming that we have sub/something and something is not included anywhere else,
>>
>> cd sub && git stash -- something
>>
>> is expected to make a stash for sub/something but instead returns error like
>>
>> error: pathspec 'something' did not match any file(s) known to git.
>> Did you forget to 'git add'?
>>
>> .
>>
>> I don't know what I should write about 'the difference between X and Y is Z'.
>
> If the difference between X and Y is obvious there is no need.
>
> I just tried it and I do not see the command is broken in the way
> you describe.
>
> Trial #1 -- the command fully spelled out.
>
> $ git.git/master: cd Documentation
> $ Documentation/master: echo >>Makefile
> $ Documentation/master: git stash push -m "doc-make" -- Makefile
> Saved working directory and index state On master: doc-make
> $ Documentation/master: git stash show --stat
> Documentation/Makefile | 1 +
> 1 file changed, 1 insertion(+:
>
> Trial #2 -- lazily issue the command without subcommand.
>
> $ git.git/master: cd Documentation
> $ Documentation/master: echo >>Makefile
> $ Documentation/master: git stash -- Makefile
> Saved working directory and index state WIP on master: 89ea799ffc Sync with maint
> $ Documentation/master: git stash show --stat
> Documentation/Makefile | 1 +
> 1 file changed, 1 insertion(+:
>
> Trial #3 -- make sure having files with the same name is not hiding any bug.
>
> $ git.git/master: cd Documentation
> $ Documentation/master: echo >>CodingGuidelines
> $ Documentation/master: git stash -- CodingGuidelines
> Saved working directory and index state WIP on master: 89ea799ffc
> $ Documentation/master: git stash show --stat
> Documentation/CodingGuidelines | 1 +
> 1 file changed, 1 insertion(+)
>
> Trial #4 -- simulate a PEBKAC
>
> $ git.git/master: cd Documentation
> $ Documentation/master: echo >>no-such-file
> $ Documentation/master: git stash -- no-such-file
> error: pathspec 'Documentation/no-such-file' did not match any file(s) known to git.
> Did you forget to 'git add'?
>
> The last one is an expected result---the pathspec given to the
> command does not match anything tracked, so without first adding the
> file, there is nothing for the command to do.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?
2017-11-18 9:08 ` 小川恭史
@ 2017-11-18 11:36 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2017-11-18 11:36 UTC (permalink / raw)
To: 小川恭史; +Cc: git
小川恭史 <aiueogawa217@gmail.com> writes:
> I upgraded the version of git from 2.13.1 to 2.15.0 on Mac and fixed my issue.
> Thanks.
Ah, yes, that bug was fixed in the 2.14.0 timeframe but was
backported to 2.13.2 and onwards (it was a bug in 2.13.0, I think).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-18 11:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-18 3:37 Is it not bug git stash -- <pathspec> does not work at non-root directory? 小川恭史
2017-11-18 3:53 ` Junio C Hamano
2017-11-18 4:12 ` 小川恭史
2017-11-18 7:56 ` Junio C Hamano
2017-11-18 9:08 ` 小川恭史
2017-11-18 11:36 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).