* Re: git send-email should not allow 'y' for in-reply-to
@ 2013-01-11 20:13 Matt Seitz (matseitz)
2013-01-11 21:23 ` Jeff King
0 siblings, 1 reply; 14+ messages in thread
From: Matt Seitz (matseitz) @ 2013-01-11 20:13 UTC (permalink / raw)
To: git@vger.kernel.org
"Jeff King" <peff@peff.net> wrote in message news:<20130111185417.GA12852@sigill.intra.peff.net>...
> On Fri, Jan 11, 2013 at 10:43:39AM -0800, Hilco Wijbenga wrote:
>
>
> > How about "What Message-ID to use as In-Reply-To for the first email?"
> > or "Provide the Message-ID to use as In-Reply-To for the first
> > email:".
>
> seem fine to me. Maybe somebody who has been confused by it can offer
> more. At any rate, patches welcome.
Suggestion: "Message-ID to use as In-Reply-To for the first email:".
Simple and unlikely to generate a "y" or "n" response. Putting "Message-ID" first makes it more obvious what data is being asked for by this prompt.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 20:13 git send-email should not allow 'y' for in-reply-to Matt Seitz (matseitz)
@ 2013-01-11 21:23 ` Jeff King
2013-01-11 21:53 ` Antoine Pelisse
0 siblings, 1 reply; 14+ messages in thread
From: Jeff King @ 2013-01-11 21:23 UTC (permalink / raw)
To: Matt Seitz (matseitz); +Cc: git@vger.kernel.org
On Fri, Jan 11, 2013 at 08:13:57PM +0000, Matt Seitz (matseitz) wrote:
> > > How about "What Message-ID to use as In-Reply-To for the first email?"
> > > or "Provide the Message-ID to use as In-Reply-To for the first
> > > email:".
> >
> > seem fine to me. Maybe somebody who has been confused by it can offer
> > more. At any rate, patches welcome.
>
> Suggestion: "Message-ID to use as In-Reply-To for the first email:".
>
> Simple and unlikely to generate a "y" or "n" response. Putting
> "Message-ID" first makes it more obvious what data is being asked for
> by this prompt.
You'd think. But the existing message that has been causing problems is:
Message-ID to be used as In-Reply-To for the first email?
which is more or less what you are proposing. I do think a colon rather
than a question mark helps indicate that the response is not yes/no.
-Peff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 21:23 ` Jeff King
@ 2013-01-11 21:53 ` Antoine Pelisse
2013-01-11 22:18 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Antoine Pelisse @ 2013-01-11 21:53 UTC (permalink / raw)
To: Jeff King; +Cc: Matt Seitz (matseitz), git@vger.kernel.org
On Fri, Jan 11, 2013 at 10:23 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jan 11, 2013 at 08:13:57PM +0000, Matt Seitz (matseitz) wrote:
>
>> > > How about "What Message-ID to use as In-Reply-To for the first email?"
>> > > or "Provide the Message-ID to use as In-Reply-To for the first
>> > > email:".
>> >
>> > seem fine to me. Maybe somebody who has been confused by it can offer
>> > more. At any rate, patches welcome.
>>
>> Suggestion: "Message-ID to use as In-Reply-To for the first email:".
>>
>> Simple and unlikely to generate a "y" or "n" response. Putting
>> "Message-ID" first makes it more obvious what data is being asked for
>> by this prompt.
>
> You'd think. But the existing message that has been causing problems is:
>
> Message-ID to be used as In-Reply-To for the first email?
>
> which is more or less what you are proposing. I do think a colon rather
> than a question mark helps indicate that the response is not yes/no.
That is true.
I'm definitely not a wording person, but assuming people who make the
mistake probably don't read the whole sentence out of laziness (that
might be somehow extreme though ;), starting it with "what" makes it
obvious at first sight that you can't answer yes/no.
That is not true if the message starts with Message-ID .. which
doesn't look like a question. Now it feels like you have agree or not.
Antoine,
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 21:53 ` Antoine Pelisse
@ 2013-01-11 22:18 ` Junio C Hamano
2013-01-11 22:42 ` Antoine Pelisse
0 siblings, 1 reply; 14+ messages in thread
From: Junio C Hamano @ 2013-01-11 22:18 UTC (permalink / raw)
To: Antoine Pelisse; +Cc: Jeff King, Matt Seitz (matseitz), git@vger.kernel.org
Antoine Pelisse <apelisse@gmail.com> writes:
> On Fri, Jan 11, 2013 at 10:23 PM, Jeff King <peff@peff.net> wrote:
>> On Fri, Jan 11, 2013 at 08:13:57PM +0000, Matt Seitz (matseitz) wrote:
>>
>>> > > How about "What Message-ID to use as In-Reply-To for the first email?"
>>> > > or "Provide the Message-ID to use as In-Reply-To for the first
>>> > > email:".
>>> >
>>> > seem fine to me. Maybe somebody who has been confused by it can offer
>>> > more. At any rate, patches welcome.
>>>
>>> Suggestion: "Message-ID to use as In-Reply-To for the first email:".
>>>
>>> Simple and unlikely to generate a "y" or "n" response. Putting
>>> "Message-ID" first makes it more obvious what data is being asked for
>>> by this prompt.
>>
>> You'd think. But the existing message that has been causing problems is:
>>
>> Message-ID to be used as In-Reply-To for the first email?
>>
>> which is more or less what you are proposing. I do think a colon rather
>> than a question mark helps indicate that the response is not yes/no.
>
> That is true.
>
> I'm definitely not a wording person, but assuming people who make the
> mistake probably don't read the whole sentence out of laziness (that
> might be somehow extreme though ;), starting it with "what" makes it
> obvious at first sight that you can't answer yes/no.
> That is not true if the message starts with Message-ID .. which
> doesn't look like a question. Now it feels like you have agree or not.
The exchange, when you do not have a configuration, goes like this:
$ git send-email 0001-filename-of-the-patch.patch
0001-filename-of-the-patch.patch
Who should the emails be sent to (if any)? junio
Are you sure you want to use <junio> [y/N]? y
Message-ID to be used as In-Reply-To for the first email (if any)?
Why not do this instead?
$ git send-email 0001-filename-of-the-patch.patch
0001-filename-of-the-patch.patch
Who should the emails be sent to (if any)? junio
Are you sure you want to use <junio> [y/N]? y
Is this a response to an existing message [y/N]? y
What is the Message-ID of the message you are replying to?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 22:18 ` Junio C Hamano
@ 2013-01-11 22:42 ` Antoine Pelisse
2013-01-11 23:54 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Antoine Pelisse @ 2013-01-11 22:42 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeff King, Matt Seitz (matseitz), git@vger.kernel.org
On Fri, Jan 11, 2013 at 11:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The exchange, when you do not have a configuration, goes like this:
>
> $ git send-email 0001-filename-of-the-patch.patch
> 0001-filename-of-the-patch.patch
> Who should the emails be sent to (if any)? junio
> Are you sure you want to use <junio> [y/N]? y
> Message-ID to be used as In-Reply-To for the first email (if any)?
>
> Why not do this instead?
>
> $ git send-email 0001-filename-of-the-patch.patch
> 0001-filename-of-the-patch.patch
> Who should the emails be sent to (if any)? junio
> Are you sure you want to use <junio> [y/N]? y
> Is this a response to an existing message [y/N]? y
I'm not sure about the extra question. If the user doesn't care, he
will probably use the empty default, which will result in the same
number of steps. If the user cares, he probably knows what he's doing
and will give a sensible value.
> What is the Message-ID of the message you are replying to?
I would simply go for:
What Message-ID are you replying to (if any)?
If I don't know what to answer, I would definitely not say y/yes/n/no,
but press enter directly.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 22:42 ` Antoine Pelisse
@ 2013-01-11 23:54 ` Junio C Hamano
2013-01-12 1:02 ` Ben Aveling
0 siblings, 1 reply; 14+ messages in thread
From: Junio C Hamano @ 2013-01-11 23:54 UTC (permalink / raw)
To: Antoine Pelisse
Cc: Jeff King, Matt Seitz (matseitz), git@vger.kernel.org,
Hilco Wijbenga
Antoine Pelisse <apelisse@gmail.com> writes:
> I would simply go for:
>
> What Message-ID are you replying to (if any)?
>
> If I don't know what to answer, I would definitely not say y/yes/n/no,
> but press enter directly.
Sounds sensible (even though technically you reply to a message
that has that message ID, and not to a message ID ;-)).
Any better phrasing from others? If not, I'd say we adopt this
text.
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-11 23:54 ` Junio C Hamano
@ 2013-01-12 1:02 ` Ben Aveling
2013-01-12 2:56 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Ben Aveling @ 2013-01-12 1:02 UTC (permalink / raw)
To: Junio C Hamano
Cc: Antoine Pelisse, Jeff King, Matt Seitz (matseitz),
git@vger.kernel.org, Hilco Wijbenga
On 12/01/2013 10:54 AM, Junio C Hamano wrote:
> Antoine Pelisse <apelisse@gmail.com> writes:
>
>> I would simply go for:
>>
>> What Message-ID are you replying to (if any)?
>>
>> If I don't know what to answer, I would definitely not say y/yes/n/no,
>> but press enter directly.
> Sounds sensible (even though technically you reply to a message
> that has that message ID, and not to a message ID ;-)).
>
> Any better phrasing from others? If not, I'd say we adopt this
> text.
I guess it depends on how much we mind if people accidentally miss the
message ID.
If we don't mind much, we could say something like:
What Message-ID are you replying to [Default=None]?
If we are concerned that when a Message-ID exists, it should be
provided, we could split to 2 questions:
Are you replying to an existing Message [Y/n]?
And then, if the answer is Y,
What Message-ID are you replying to?
Regards, Ben
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: git send-email should not allow 'y' for in-reply-to
2013-01-12 1:02 ` Ben Aveling
@ 2013-01-12 2:56 ` Junio C Hamano
0 siblings, 0 replies; 14+ messages in thread
From: Junio C Hamano @ 2013-01-12 2:56 UTC (permalink / raw)
To: Ben Aveling
Cc: Antoine Pelisse, Jeff King, Matt Seitz (matseitz),
git@vger.kernel.org, Hilco Wijbenga
Ben Aveling <bena.001@optusnet.com.au> writes:
> On 12/01/2013 10:54 AM, Junio C Hamano wrote:
>> Antoine Pelisse <apelisse@gmail.com> writes:
>>
>>> I would simply go for:
>>>
>>> What Message-ID are you replying to (if any)?
>>>
>>> If I don't know what to answer, I would definitely not say y/yes/n/no,
>>> but press enter directly.
>> Sounds sensible (even though technically you reply to a message
>> that has that message ID, and not to a message ID ;-)).
>>
>> Any better phrasing from others? If not, I'd say we adopt this
>> text.
>
> I guess it depends on how much we mind if people accidentally miss the
> message ID.
>
> If we don't mind much, we could say something like:
>
> What Message-ID are you replying to [Default=None]?
>
>
> If we are concerned that when a Message-ID exists, it should be
> provided, we could split to 2 questions:
>
> Are you replying to an existing Message [Y/n]?
>
> And then, if the answer is Y,
>
> What Message-ID are you replying to?
Eewww. Now we come back to full circles.
It sometimes helps to follow the in-reply-to chain to see what has
already been said in the thread, I guess ;-)
^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1357885869-20815-1-git-send-email-cyliu@suse.com>]
end of thread, other threads:[~2013-02-24 9:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-11 20:13 git send-email should not allow 'y' for in-reply-to Matt Seitz (matseitz)
2013-01-11 21:23 ` Jeff King
2013-01-11 21:53 ` Antoine Pelisse
2013-01-11 22:18 ` Junio C Hamano
2013-01-11 22:42 ` Antoine Pelisse
2013-01-11 23:54 ` Junio C Hamano
2013-01-12 1:02 ` Ben Aveling
2013-01-12 2:56 ` Junio C Hamano
[not found] <1357885869-20815-1-git-send-email-cyliu@suse.com>
[not found] ` <50EFD066.60501@redhat.com>
2013-01-11 16:39 ` Eric Blake
2013-01-11 16:47 ` Jeff King
2013-01-11 17:51 ` Eric Blake
2013-01-11 18:43 ` Hilco Wijbenga
2013-01-11 18:54 ` Jeff King
2013-02-24 9:03 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).