From: Jeff King <peff@peff.net>
To: Eric Blake <eblake@redhat.com>
Cc: git@vger.kernel.org, libvir-list@redhat.com
Subject: Re: git send-email should not allow 'y' for in-reply-to
Date: Fri, 11 Jan 2013 11:47:30 -0500 [thread overview]
Message-ID: <20130111164730.GA7921@sigill.intra.peff.net> (raw)
In-Reply-To: <50F0402A.1000108@redhat.com>
On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
> > Please don't answer "y" when git send email shows the following prompt:
> >
> > "Message-ID to be used as In-Reply-To for the first email?"
> >
> > you should respond with a message ID there. Unfortunately we have a
> > growing thread that contains submissions with this mistake.
>
> Anyone willing to patch upstream 'git send-email' to reject a simple 'y'
> rather than blindly sending a bad messageID for the in-reply-to field,
> to help future users avoid this mistake? Obviously, it won't help until
> the patch eventually percolates into distros, so it would be a few more
> months before we see the benefits, but down the road it will prevent
> confusing threads.
What version of git? Commit 51bbccf is in v1.7.12.1 and higher, and
says:
$ git show 51bbccf
commit 51bbccfd1b4a9e2807413022c56ab05c835164fb
Author: Junio C Hamano <gitster@pobox.com>
Date: Tue Aug 14 15:15:53 2012 -0700
send-email: validate & reconfirm interactive responses
People answer 'y' to "Who should the emails appear to be from?" and
'n' to "Message-ID to be used as In-Reply-To for the first email?"
for some unknown reason. While it is possible that your local
username really is "y" and you are sending the mail to your local
colleagues, it is possible, and some might even say it is likely,
that it is a user error.
Fortunately, our interactive prompter already has input validation
mechanism built-in. Enhance it so that we can optionally reconfirm
and allow the user to pass an input that does not validate, and
"softly" require input to the sender, in-reply-to, and recipient to
contain "@" and "." in this order, which would catch most cases of
mistakes.
-Peff
next prev parent reply other threads:[~2013-01-11 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1357885869-20815-1-git-send-email-cyliu@suse.com>
[not found] ` <50EFD066.60501@redhat.com>
2013-01-11 16:39 ` git send-email should not allow 'y' for in-reply-to Eric Blake
2013-01-11 16:47 ` Jeff King [this message]
2013-01-11 17:51 ` Eric Blake
2013-01-11 18:43 ` Hilco Wijbenga
2013-01-11 18:54 ` Jeff King
2013-02-24 9:03 ` Junio C Hamano
2013-01-11 20:13 Matt Seitz (matseitz)
2013-01-11 21:23 ` Jeff King
2013-01-11 21:53 ` Antoine Pelisse
2013-01-11 22:18 ` Junio C Hamano
2013-01-11 22:42 ` Antoine Pelisse
2013-01-11 23:54 ` Junio C Hamano
2013-01-12 1:02 ` Ben Aveling
2013-01-12 2:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111164730.GA7921@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=libvir-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).