From: Eric Blake <eblake@redhat.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, libvir-list@redhat.com
Subject: Re: git send-email should not allow 'y' for in-reply-to
Date: Fri, 11 Jan 2013 10:51:42 -0700 [thread overview]
Message-ID: <50F0512E.8000205@redhat.com> (raw)
In-Reply-To: <20130111164730.GA7921@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]
On 01/11/2013 09:47 AM, Jeff King wrote:
> On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
>
>>> Please don't answer "y" when git send email shows the following prompt:
>>>
>>
>> Anyone willing to patch upstream 'git send-email' to reject a simple 'y'
> What version of git? Commit 51bbccf is in v1.7.12.1 and higher, and
> says:
>
> $ git show 51bbccf
> commit 51bbccfd1b4a9e2807413022c56ab05c835164fb
> Author: Junio C Hamano <gitster@pobox.com>
> Date: Tue Aug 14 15:15:53 2012 -0700
>
> send-email: validate & reconfirm interactive responses
>
> People answer 'y' to "Who should the emails appear to be from?" and
> 'n' to "Message-ID to be used as In-Reply-To for the first email?"
> for some unknown reason. While it is possible that your local
> username really is "y" and you are sending the mail to your local
> colleagues, it is possible, and some might even say it is likely,
> that it is a user error.
Awesome! Already implemented! In the case that sparked this particular
email, the culprit was using 1.7.3.4; earlier this month, a separate
culprit to the same libvirt mailing list was using 1.7.11.7.
I was right about it needing to take a few months to percolate to the
actual users.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2013-01-11 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1357885869-20815-1-git-send-email-cyliu@suse.com>
[not found] ` <50EFD066.60501@redhat.com>
2013-01-11 16:39 ` git send-email should not allow 'y' for in-reply-to Eric Blake
2013-01-11 16:47 ` Jeff King
2013-01-11 17:51 ` Eric Blake [this message]
2013-01-11 18:43 ` Hilco Wijbenga
2013-01-11 18:54 ` Jeff King
2013-02-24 9:03 ` Junio C Hamano
2013-01-11 20:13 Matt Seitz (matseitz)
2013-01-11 21:23 ` Jeff King
2013-01-11 21:53 ` Antoine Pelisse
2013-01-11 22:18 ` Junio C Hamano
2013-01-11 22:42 ` Antoine Pelisse
2013-01-11 23:54 ` Junio C Hamano
2013-01-12 1:02 ` Ben Aveling
2013-01-12 2:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F0512E.8000205@redhat.com \
--to=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=libvir-list@redhat.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).