From: Jan Stary <hans@stare.cz>
To: sox-devel@lists.sourceforge.net
Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio
Date: Tue, 11 Aug 2020 15:41:50 +0200 [thread overview]
Message-ID: <20200811134150.GA70131@www.stare.cz> (raw)
In-Reply-To: <20200811133407.GA88171@www.stare.cz>
> > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,,
> > - [AC_CHECK_HEADERS(machine/soundcard.h,
> > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")],
> > - using_oss=no)])])
> > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)])
>
> Apparently, the presence of <sys/soundcard.h> is not
> a correct test of ossaudio being available in the system.
Maybe I am confused by the Subject:
"remove check for machine/soundcard.h and libossaudio"
It seems this diff does not remove, but change the way
ossaudio is detected; namely, if sys/soundcard.h is present,
we have oss (which is wrong, at least on OpenBSD);
also, even with oss detected, we no longer set -libossaudio,
which also seems wrong 9anywhere we want to use it).
Jan
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
next prev parent reply other threads:[~2020-08-11 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 12:17 [PATCH] oss: remove check for machine/soundcard.h and libossaudio Mans Rullgard
2020-08-11 13:34 ` Jan Stary
2020-08-11 13:41 ` Jan Stary [this message]
2020-08-11 14:14 ` Måns Rullgård
2020-08-11 14:33 ` Jan Stary
2020-08-11 14:39 ` Måns Rullgård
2020-08-11 13:58 ` Måns Rullgård
2020-08-11 14:40 ` Jan Stary
2020-08-11 15:17 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811134150.GA70131@www.stare.cz \
--to=sox-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).