sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: Mans Rullgard <mans@mansr.com>
To: sox-devel@lists.sourceforge.net
Subject: [PATCH] oss: remove check for machine/soundcard.h and libossaudio
Date: Mon, 10 Aug 2020 13:17:07 +0100	[thread overview]
Message-ID: <20200810121707.29623-1-mans@mansr.com> (raw)

Near as I can tell, no system actually has a machine/soundcard.h file.
The libossaudio library on NetBSD and OpenBSD is meant to emulate a
few ioctl() commands to facilitate porting of Linux applications.  As
we have proper sndio support, this is of no use for SoX.
---
Are there any BSD users here who can comment on this?
---
 configure.ac | 5 +----
 src/oss.c    | 3 ---
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/configure.ac b/configure.ac
index b1440560181c..9f55b5f8a55c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -609,10 +609,7 @@ AC_OPTIONAL_FORMAT(sndfile, SNDFILE, [using_sndfile=$tmp_using_sndfile])
 
 
 
-AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,,
-      [AC_CHECK_HEADERS(machine/soundcard.h,
-	  [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")],
-	  using_oss=no)])])
+AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)])
 
 
 
diff --git a/src/oss.c b/src/oss.c
index 9c6682f1d478..35c7cd2fae9b 100644
--- a/src/oss.c
+++ b/src/oss.c
@@ -32,9 +32,6 @@
 #ifdef HAVE_SYS_SOUNDCARD_H
   #include <sys/soundcard.h>
 #endif
-#ifdef HAVE_MACHINE_SOUNDCARD_H
-  #include <machine/soundcard.h>
-#endif
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif
-- 
2.28.0



_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

             reply	other threads:[~2020-08-10 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 12:17 Mans Rullgard [this message]
2020-08-11 13:34 ` [PATCH] oss: remove check for machine/soundcard.h and libossaudio Jan Stary
2020-08-11 13:41   ` Jan Stary
2020-08-11 14:14     ` Måns Rullgård
2020-08-11 14:33       ` Jan Stary
2020-08-11 14:39         ` Måns Rullgård
2020-08-11 13:58   ` Måns Rullgård
2020-08-11 14:40     ` Jan Stary
2020-08-11 15:17       ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810121707.29623-1-mans@mansr.com \
    --to=sox-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).