Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio

["Måns Rullgård" <mans@mansr.com>]

Jan Stary <hans@stare.cz> writes:

> On Aug 11 15:14:29, mans@mansr.com wrote:
>> Jan Stary <hans@stare.cz> writes:
>> 
>> >> > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,,
>> >> > -      [AC_CHECK_HEADERS(machine/soundcard.h,
>> >> > -	  [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")],
>> >> > -	  using_oss=no)])])
>> >> > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)])
>> >> 
>> >> Apparently, the presence of <sys/soundcard.h> is not
>> >> a correct test of ossaudio being available in the system.
>> >
>> > Maybe I am confused by the Subject:
>> > "remove check for machine/soundcard.h and libossaudio"
>> 
>> The checks for those things have been removed.  It now only checks for
>> sys/soundcard.h since that better reflects what we actually want.
>
> Does that mean "if sys/soundcard.h was found,
> we are on a system where we want to use OSS"?

For want of a more specific test, yes.  Maybe we should check for one of
the SNDCTL_ macros as well.

>> > It seems this diff does not remove, but change the way
>> > ossaudio is detected; namely, if sys/soundcard.h is present,
>> > we have oss (which is wrong, at least on OpenBSD);
>> 
>> Did you fix that typo (a git pull will do it)?  If not, it would
>> definitely "detect" it as present on any system.
>
> With that typo fixed, ./configure on OpenBSD thinks that
>
> 	OPTIONAL DEVICE DRIVERS
> 	ao (Xiph)..................no
> 	alsa (Linux)...............no
> 	coreaudio (Mac OS X).......no
> 	sndio (OpenBSD)............yes
> 	oss........................no
> 	pulseaudio.................no
> 	sunaudio...................yes
> 	waveaudio (MS-Windows).....no
>
> and the compilatiopn fails as in my previous email.
> But ./configure --without-sunaudio results in
>
> 	OPTIONAL DEVICE DRIVERS
> 	ao (Xiph)..................no
> 	alsa (Linux)...............no
> 	coreaudio (Mac OS X).......no
> 	sndio (OpenBSD)............yes
> 	oss........................no
> 	pulseaudio.................no
> 	sunaudio...................no
> 	waveaudio (MS-Windows).....no
>
> and it builds fine.
>
>> > also, even with oss detected, we no longer set -libossaudio,
>> > which also seems wrong (anywhere we want to use it).
>> 
>> -lossaudio is _only_ for the emulation on *BSD.  No library is required
>> on systems with real OSS drivers.  We shouldn't be using the emulation,
>> so there is no need to link with the library either.
>
> Right; sorry for the confusion.
>
> 	Jan
>

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel