From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 95D631F66E for ; Tue, 11 Aug 2020 13:42:05 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5UXS-00086o-VU; Tue, 11 Aug 2020 13:42:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5UXR-00086d-VO for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:42:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DLh8Rm71Jfrk8WbhucAJV5ldisb5LX3adI1+jbbH8Xo=; b=S++Fs9K8aj6+eTpfSSh9/vb49R A9qJA3F3/lEs44NeUExoO2gtu1mdWxYDo+cqTduDCGIsCsaBfCC0pNDqyz95lNxsaVhKgNZlzs+ob tleLH4OsDsyQCCBXI3NATF1XkM2Geo8J/yZWoSRvEBeOSsjV3c3D2qej55xd936skWWU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To: From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DLh8Rm71Jfrk8WbhucAJV5ldisb5LX3adI1+jbbH8Xo=; b=K3WbaYLRwuw8MYJ80xHFyHU3MG wI98NJ326NvEojmuuk9JM+0ty0DUHD9kvrjb9lhY/taV7qWBBUTs5GRYxJtpZsj6Jxftoh1ic/X/j OFYIKGqKT+6lqdpgXqwU4a/oF32E5W82HM7un1sjA/S3tbHoqfHubzytcC4+DaPlwcD8=; Received: from uvt.stare.cz ([185.63.96.79] helo=mx.stare.cz) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5UXP-0013bY-Vq for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:42:01 +0000 Received: from localhost (stare.cz [local]) by stare.cz (OpenSMTPD) with ESMTPA id fa6a112f for ; Tue, 11 Aug 2020 15:41:52 +0200 (CEST) Date: Tue, 11 Aug 2020 15:41:50 +0200 From: Jan Stary To: sox-devel@lists.sourceforge.net Message-ID: <20200811134150.GA70131@www.stare.cz> References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200811133407.GA88171@www.stare.cz> X-Headers-End: 1k5UXP-0013bY-Vq Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net > > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, > > - [AC_CHECK_HEADERS(machine/soundcard.h, > > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")], > > - using_oss=no)])]) > > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)]) > > Apparently, the presence of is not > a correct test of ossaudio being available in the system. Maybe I am confused by the Subject: "remove check for machine/soundcard.h and libossaudio" It seems this diff does not remove, but change the way ossaudio is detected; namely, if sys/soundcard.h is present, we have oss (which is wrong, at least on OpenBSD); also, even with oss detected, we no longer set -libossaudio, which also seems wrong 9anywhere we want to use it). Jan _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel