Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio

[Jan Stary <hans@stare.cz>]

This is OpenBSD/current.

On Aug 10 13:17:07, mans@mansr.com wrote:
> Near as I can tell, no system actually has a machine/soundcard.h file.

OpenBSD has neither <machine/soundcard.h> nor <sys/soundcard.h>;
it has <soundcard.h>, as documented in http://man.openbsd.org/ossaudio

> The libossaudio library on NetBSD and OpenBSD is meant to emulate a
> few ioctl() commands to facilitate porting of Linux applications.

Yes.

> As we have proper sndio support, this is of no use for SoX.

On OpenBSD, yes (I will look at NetBSD and FreeBSD in separate emails).
Current SoX git builds and runs fine on OpenBSD
(except the recent -Wl,--as-needed) using sndio,
if ./configure'd right. The OpenBSD port of SoX 14.4.2
http://cvsweb.openbsd.org/ports/audio/sox/Makefile?rev=1.72
explicitly builds --without-oss	--without-sunaudio --with-sndio

In fact, these options are necessary (that is to say,
the autodetection is broken); when ./configure'd without options,
it detects each of sndio, ossaudio and sunaudio, and fails with

sox.c: In function 'adjust_volume':
sox.c:1337: error: 'audio_info_t' undeclared (first use in this function)
sox.c:1337: error: (Each undeclared identifier is reported only once
sox.c:1337: error: for each function it appears in.)
sox.c:1337: error: expected ';' before 'audio_info'
sox.c:1338: error: 'AUDIO_GETINFO' undeclared (first use in this function)
sox.c:1338: error: 'audio_info' undeclared (first use in this function)
sox.c:1341: warning: implicit declaration of function 'AUDIO_INITINFO'
sox.c:1345: error: 'AUDIO_SETINFO' undeclared (first use in this function)

(These are artifacts of sunaudio, right?)
A naive 'grep -Fr audio_info_t .' reveals that SoX ships with

	src/bit-rot/
	src/bit-rot/CoreAudio
	src/bit-rot/CoreAudio/CoreAudio.h
	src/bit-rot/mmreg.h
	src/bit-rot/mmsystem.h
	src/bit-rot/sndio.h
	src/bit-rot/sys
	src/bit-rot/sys/audioio.h
	src/bit-rot/windows.h

What are these for?

> ---
> Are there any BSD users here who can comment on this?
> ---
>  configure.ac | 5 +----
>  src/oss.c    | 3 ---
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b1440560181c..9f55b5f8a55c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -609,10 +609,7 @@ AC_OPTIONAL_FORMAT(sndfile, SNDFILE, [using_sndfile=$tmp_using_sndfile])
>  
>  
>  
> -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,,
> -      [AC_CHECK_HEADERS(machine/soundcard.h,
> -	  [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")],
> -	  using_oss=no)])])
> +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)])

Apparently, the presence of <sys/soundcard.h> is not
a correct test of ossaudio being available in the system.

'uing_oss' is a typo I guess.

(God I hate autotools.)

	Jan



_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel