Re: Potential Rack-Contrib contributions

[Ryan Tomayko <r@tomayko.com>]

On Fri, Jan 15, 2010 at 8:23 AM, Geoff Buesing <gbuesing@gmail.com> wrote:
> I've pulled together some useful generic middleware into
> http://github.com/gbuesing/rackables:
>
> * Rackables::Branch - Conditionally re-routes the Rack stack at
> runtime to an alternate endpoint
> * Rackables::CacheControl - Sets response Cache-Control header
> * Rackables::DefaultCharset - Sets charset directive in Content-Type
> header
> * Rackables::Get - Allows creation of simple endpoints and path
> routing with a syntax similar to Sinatra's get method
> * Rackables::HideExceptions - Rescues exceptions with a static
> exception page
> * Rackables::TrailingSlashRedirect - 301 Redirects requests paths with
> a trailing slash
>
> If any of these would be a good fit for Rack-Contrib, let me know, I'd
> be happy to pull together patches.

You have some great stuff in there.

So far, the rack-contrib policy has been to accept anything that's
generally useful, has tests, and is more or less documented. All of
the above appear to pass those tests.

The only thing I would have a problem with is Rackables::Get -- the
name is just too general. How about SimpleGetEndpoint or something
similarly verbose. Classname brevity isn't a feature when it comes to
rack-contrib.

If you want to roll these into one rack-contrib patch per middleware,
I'd be very happy to review and merge them.

Thanks,
Ryan