Re: Potential Rack-Contrib contributions

["Iñaki Baz Castillo" <ibc@aliax.net>]

El Sábado, 16 de Enero de 2010, Iñaki Baz Castillo escribió:

> 1) HAS_CHARSET = /charset=/
> Note that HTTP grammar is case insensitive (in most of the cases) so IMGO
>  it shoud be:
> 
>   HAS_CHARSET = /charset=/i


Humm, definitively it's not enough. HTTP BNF grammar is really more complex 
that the above hyper simplified assumption.

The folllowing headers are all valid "Content-Type" headers, and all of them 
contain a valid "charset" param (replace <LF> with a real \r symbol and <TAB> 
with \t):


Content-Type: text/plain ; CharSet<LF>
  = utf-8


content-TYPE:text/plain ; CharSet<LF>
  = utf-8


Content-Type: text/plain <LF>
 ; CharSet <LF>
  = utf-8


Content-Type:<TAB><TAB>text/plain<TAB>; <LF>
 charset <LF>
<TAB><TAB>  <TAB> = <TAB><LF>
  utf-8


Well for sure we can assume that other Rack middlewwares and also our Rack app 
would generate a simple inline header value. Then I would rewrite the regex to 
this one (the ";" is important):

  HAS_CHARSET = /;[\s\t]*charset[\s\t]*=[\s\t]*/i


Regards.


-- 
Iñaki Baz Castillo <ibc@aliax.net>