Re: Potential Rack-Contrib contributions

[Geoff Buesing <gbuesing@gmail.com>]

@Ryan - patches added as Lighthouse tickets:

http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/3-new-middleware-rackbranch
http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/4-new-middleware-rackcachecontrol
http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/5-new-middleware-rackdefaultcharset
http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/6-new-middleware-rackhideexceptions
http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/7-new-middleware-racksimpleendpoint
http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/8-rackenv-reader-and-rackenvdevelopment-etc-inquiry-methods

Thanks!

Geoff

On Jan 16, 11:47 am, Geoff Buesing <gbues...@gmail.com> wrote:
> @Ryan - thanks, I'll pull together patches. And I agree that
> Rackables::Get is to generic of a name; SimpleGetEndpoint is much
> better. Running with that idea, I'm thinking of going a bit more
> generic: Rack::SimpleEndpoint, with a verb requirement as an optional
> argument.
>
> @Iñaki and @Michael - thanks for the case-sensitivity heads up, and
> the regex. I'll make sure to put in tests for these cases.
>
> Geoff
>
> On Jan 16, 8:47 am, Iñaki Baz Castillo <i...@aliax.net> wrote:
>
>
>
> > El Sábado, 16 de Enero de 2010, Michael Fellinger escribió:
>
> > > > Well for sure we can assume that other Rack middlewwares and also our
> > > > Rack app would generate a simple inline header value. Then I would
> > > > rewrite the regex to this one (the ";" is important):
>
> > > >  HAS_CHARSET = /;[\s\t]*charset[\s\t]*=[\s\t]*/i
>
> > > "\t" =~ /\s/
> > > # 0
> > > means
> > > /;\s*charset\s*=\s*/i
> > > will be enough.
>
> > Right, my fault, normally I use [ \t]* instead of [\s\t]* which makes no sense
> > as \s includes space and tabulator.
>
> > > Regarding the case of Content-Type in the header Hash, as long as it's
> > > an instance of HeaderHash, the case will not matter, we normalize it
> > > behind the scene.
>
> > ok, that's why I said "in case 2 perhaps I'm wrong" :)
>
> > Thanks a lot.
>
> > --
> > Iñaki Baz Castillo <i...@aliax.net>