From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs359460rvd; Sun, 17 Jan 2010 10:32:55 -0800 (PST) Received: from mr.google.com ([10.100.228.1]) by 10.100.228.1 with SMTP id a1mr6313132anh.16.1263753174701 (num_hops = 1); Sun, 17 Jan 2010 10:32:54 -0800 (PST) Received: by 10.100.228.1 with SMTP id a1mr377249anh.16.1263753172863; Sun, 17 Jan 2010 10:32:52 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.91.11.6 with SMTP id o6ls547286agi.3.p; Sun, 17 Jan 2010 10:32:51 -0800 (PST) Received: by 10.90.61.6 with SMTP id j6mr6859328aga.12.1263753171088; Sun, 17 Jan 2010 10:32:51 -0800 (PST) Received: by 10.90.61.6 with SMTP id j6mr6859327aga.12.1263753171044; Sun, 17 Jan 2010 10:32:51 -0800 (PST) Return-Path: Received: from mail-yx0-f162.google.com (mail-yx0-f162.google.com [209.85.210.162]) by gmr-mx.google.com with ESMTP id 18si411466ywh.5.2010.01.17.10.32.51; Sun, 17 Jan 2010 10:32:51 -0800 (PST) Received-SPF: pass (google.com: domain of gbuesing@gmail.com designates 209.85.210.162 as permitted sender) client-ip=209.85.210.162; Received: by mail-yx0-f162.google.com with SMTP id 34so27838yxe.16 for ; Sun, 17 Jan 2010 10:32:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.142.34 with SMTP id u34mr375625ann.39.1263753170994; Sun, 17 Jan 2010 10:32:50 -0800 (PST) Date: Sun, 17 Jan 2010 10:32:50 -0800 (PST) In-Reply-To: X-IP: 64.81.227.173 References: <201001161438.53304.ibc@aliax.net> <9c00d3e01001160601l62bf274ay6b899ff141c10fec@mail.gmail.com> <201001161547.26915.ibc@aliax.net> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10,gzip(gfe),gzip(gfe) Message-ID: <311ba86f-84ad-4b05-91f3-ffc46592066b@l19g2000yqb.googlegroups.com> Subject: Re: Potential Rack-Contrib contributions From: Geoff Buesing To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gbuesing@gmail.com designates 209.85.210.162 as permitted sender) smtp.mail=gbuesing@gmail.com X-Original-Sender: gbuesing@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/c034955ef1a34475 X-Message-Url: http://groups.google.com/group/rack-devel/msg/9524412c24402732 Sender: rack-devel@googlegroups.com List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable @Ryan - patches added as Lighthouse tickets: http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/3-new-mid= dleware-rackbranch http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/4-new-mid= dleware-rackcachecontrol http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/5-new-mid= dleware-rackdefaultcharset http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/6-new-mid= dleware-rackhideexceptions http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/7-new-mid= dleware-racksimpleendpoint http://rack.lighthouseapp.com/projects/22456-rack-contrib/tickets/8-rackenv= -reader-and-rackenvdevelopment-etc-inquiry-methods Thanks! Geoff On Jan 16, 11:47=A0am, Geoff Buesing wrote: > @Ryan - thanks, I'll pull together patches. And I agree that > Rackables::Get is to generic of a name; SimpleGetEndpoint is much > better. Running with that idea, I'm thinking of going a bit more > generic: Rack::SimpleEndpoint, with a verb requirement as an optional > argument. > > @I=F1aki and @Michael - thanks for the case-sensitivity heads up, and > the regex. I'll make sure to put in tests for these cases. > > Geoff > > On Jan 16, 8:47=A0am, I=F1aki Baz Castillo wrote: > > > > > El S=E1bado, 16 de Enero de 2010, Michael Fellinger escribi=F3: > > > > > Well for sure we can assume that other Rack middlewwares and also o= ur > > > > Rack app would generate a simple inline header value. Then I would > > > > rewrite the regex to this one (the ";" is important): > > > > > =A0HAS_CHARSET =3D /;[\s\t]*charset[\s\t]*=3D[\s\t]*/i > > > > "\t" =3D~ /\s/ > > > # 0 > > > means > > > /;\s*charset\s*=3D\s*/i > > > will be enough. > > > Right, my fault, normally I use [ \t]* instead of [\s\t]* which makes n= o sense > > as \s includes space and tabulator. > > > > Regarding the case of Content-Type in the header Hash, as long as it'= s > > > an instance of HeaderHash, the case will not matter, we normalize it > > > behind the scene. > > > ok, that's why I said "in case 2 perhaps I'm wrong" :) > > > Thanks a lot. > > > -- > > I=F1aki Baz Castillo