From: Geoff Buesing <gbuesing@gmail.com>
To: Rack Development <rack-devel@googlegroups.com>
Subject: Re: Potential Rack-Contrib contributions
Date: Sat, 16 Jan 2010 09:47:51 -0800 (PST) [thread overview]
Message-ID: <bd0eec4f-3416-42d5-a3b7-06c5c3725c03@m3g2000yqf.googlegroups.com> (raw)
In-Reply-To: <201001161547.26915.ibc@aliax.net>
@Ryan - thanks, I'll pull together patches. And I agree that
Rackables::Get is to generic of a name; SimpleGetEndpoint is much
better. Running with that idea, I'm thinking of going a bit more
generic: Rack::SimpleEndpoint, with a verb requirement as an optional
argument.
@Iñaki and @Michael - thanks for the case-sensitivity heads up, and
the regex. I'll make sure to put in tests for these cases.
Geoff
On Jan 16, 8:47 am, Iñaki Baz Castillo <i...@aliax.net> wrote:
> El Sábado, 16 de Enero de 2010, Michael Fellinger escribió:
>
> > > Well for sure we can assume that other Rack middlewwares and also our
> > > Rack app would generate a simple inline header value. Then I would
> > > rewrite the regex to this one (the ";" is important):
>
> > > HAS_CHARSET = /;[\s\t]*charset[\s\t]*=[\s\t]*/i
>
> > "\t" =~ /\s/
> > # 0
> > means
> > /;\s*charset\s*=\s*/i
> > will be enough.
>
> Right, my fault, normally I use [ \t]* instead of [\s\t]* which makes no sense
> as \s includes space and tabulator.
>
> > Regarding the case of Content-Type in the header Hash, as long as it's
> > an instance of HeaderHash, the case will not matter, we normalize it
> > behind the scene.
>
> ok, that's why I said "in case 2 perhaps I'm wrong" :)
>
> Thanks a lot.
>
> --
> Iñaki Baz Castillo <i...@aliax.net>
next prev parent reply other threads:[~2010-01-16 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 16:23 Potential Rack-Contrib contributions Geoff Buesing
2010-01-16 12:29 ` Ryan Tomayko
2010-01-16 13:22 ` Iñaki Baz Castillo
2010-01-16 13:38 ` Iñaki Baz Castillo
2010-01-16 14:01 ` Michael Fellinger
2010-01-16 14:47 ` Iñaki Baz Castillo
2010-01-16 17:47 ` Geoff Buesing [this message]
2010-01-17 18:32 ` Geoff Buesing
2010-01-17 19:15 ` Geoff Buesing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd0eec4f-3416-42d5-a3b7-06c5c3725c03@m3g2000yqf.googlegroups.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).