From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs304683rvd; Sat, 16 Jan 2010 04:29:20 -0800 (PST) Received: from mr.google.com ([10.224.40.208]) by 10.224.40.208 with SMTP id l16mr1176768qae.29.1263644959237 (num_hops = 1); Sat, 16 Jan 2010 04:29:19 -0800 (PST) Received: by 10.224.40.208 with SMTP id l16mr67524qae.29.1263644957544; Sat, 16 Jan 2010 04:29:17 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.229.100.199 with SMTP id z7ls605500qcn.0.p; Sat, 16 Jan 2010 04:29:15 -0800 (PST) Received: by 10.229.32.12 with SMTP id a12mr641518qcd.15.1263644955135; Sat, 16 Jan 2010 04:29:15 -0800 (PST) Received: by 10.229.32.12 with SMTP id a12mr641517qcd.15.1263644955114; Sat, 16 Jan 2010 04:29:15 -0800 (PST) Return-Path: Received: from mail-qy0-f187.google.com (mail-qy0-f187.google.com [209.85.221.187]) by gmr-mx.google.com with ESMTP id 19si1045696qyk.8.2010.01.16.04.29.14; Sat, 16 Jan 2010 04:29:14 -0800 (PST) Received-SPF: pass (google.com: domain of rtomayko@gmail.com designates 209.85.221.187 as permitted sender) client-ip=209.85.221.187; Received: by qyk17 with SMTP id 17so252632qyk.2 for ; Sat, 16 Jan 2010 04:29:14 -0800 (PST) MIME-Version: 1.0 Sender: rack-devel@googlegroups.com Received: by 10.224.51.200 with SMTP id e8mr3011886qag.373.1263644953906; Sat, 16 Jan 2010 04:29:13 -0800 (PST) In-Reply-To: References: Date: Sat, 16 Jan 2010 04:29:13 -0800 Message-ID: Subject: Re: Potential Rack-Contrib contributions From: Ryan Tomayko To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of rtomayko@gmail.com designates 209.85.221.187 as permitted sender) smtp.mail=rtomayko@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: r@tomayko.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/c034955ef1a34475 X-Message-Url: http://groups.google.com/group/rack-devel/msg/9d55ae85805c5f06 List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=UTF-8 On Fri, Jan 15, 2010 at 8:23 AM, Geoff Buesing wrote: > I've pulled together some useful generic middleware into > http://github.com/gbuesing/rackables: > > * Rackables::Branch - Conditionally re-routes the Rack stack at > runtime to an alternate endpoint > * Rackables::CacheControl - Sets response Cache-Control header > * Rackables::DefaultCharset - Sets charset directive in Content-Type > header > * Rackables::Get - Allows creation of simple endpoints and path > routing with a syntax similar to Sinatra's get method > * Rackables::HideExceptions - Rescues exceptions with a static > exception page > * Rackables::TrailingSlashRedirect - 301 Redirects requests paths with > a trailing slash > > If any of these would be a good fit for Rack-Contrib, let me know, I'd > be happy to pull together patches. You have some great stuff in there. So far, the rack-contrib policy has been to accept anything that's generally useful, has tests, and is more or less documented. All of the above appear to pass those tests. The only thing I would have a problem with is Rackables::Get -- the name is just too general. How about SimpleGetEndpoint or something similarly verbose. Classname brevity isn't a feature when it comes to rack-contrib. If you want to roll these into one rack-contrib patch per middleware, I'd be very happy to review and merge them. Thanks, Ryan