Double quotes are not preserved confirmation

Double quotes are not preserved confirmation

[Neeraj Singh]

I am working on this rails ticket https://rails.lighthouseapp.com/projects/8994/tickets/4576
.

Then I found this test case http://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35
. As you can see if the data has double quotes then double quotes are
being removed.

However if the data has a new line character then double quotes are
preserved.

Questions:

1) I looked at the rack spec but could not find any mention of this
behavior that double quotes should be removed only if string does not
contain a new line character.

2) If the existing behavior is the correct behavior then could you
please add this test case which makes it explicitly clear that string
with new line character will have double quotes preserver.  Here is my
commit.

http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1077aad08fc4b59a

Needless to say that test is passing with that commit.


Thanks

- Neeraj

Re: Double quotes are not preserved confirmation

[Simon Chiang]

Hi this issue has come up several times now.

* http://groups.google.com/group/rack-devel/browse_thread/thread/befbad49b6409b45
* http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79e633b9e086

I think it is a bug.  I found the commit that introduced this
behavior.  Looks like it was intentional but perhaps just a bad
choice?  http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361a3885bd88b42ca

A patch that removes quote parsing and fixes the specs is here:
http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46848e90e21ba



On May 14, 9:58 am, Neeraj Singh <neerajdotn...@gmail.com> wrote:
> I am working on this rails tickethttps://rails.lighthouseapp.com/projects/8994/tickets/4576
> .
>
> Then I found this test casehttp://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35
> . As you can see if the data has double quotes then double quotes are
> being removed.
>
> However if the data has a new line character then double quotes are
> preserved.
>
> Questions:
>
> 1) I looked at the rack spec but could not find any mention of this
> behavior that double quotes should be removed only if string does not
> contain a new line character.
>
> 2) If the existing behavior is the correct behavior then could you
> please add this test case which makes it explicitly clear that string
> with new line character will have double quotes preserver.  Here is my
> commit.
>
> http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1...
>
> Needless to say that test is passing with that commit.
>
> Thanks
>
> - Neeraj

Re: Double quotes are not preserved confirmation

[Neeraj Singh]

@Simon Thanks for the update.

I should have looked into the archive before asking the question.
Sorry about that.

Well it is an issue confirmed by some and there is already a patch.
Looks like someone has to pull the trigger and apply the patch.



On May 14, 7:32 pm, Simon Chiang <simon.a.chi...@gmail.com> wrote:
> Hi this issue has come up several times now.
>
> *http://groups.google.com/group/rack-devel/browse_thread/thread/befbad...
> *http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79...
>
> I think it is a bug.  I found the commit that introduced this
> behavior.  Looks like it was intentional but perhaps just a bad
> choice?  http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361a38...
>
> A patch that removes quote parsing and fixes the specs is here:http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46...
>
> On May 14, 9:58 am, Neeraj Singh <neerajdotn...@gmail.com> wrote:
>
>
>
> > I am working on this rails tickethttps://rails.lighthouseapp.com/projects/8994/tickets/4576
> > .
>
> > Then I found this test casehttp://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35
> > . As you can see if the data has double quotes then double quotes are
> > being removed.
>
> > However if the data has a new line character then double quotes are
> > preserved.
>
> > Questions:
>
> > 1) I looked at the rack spec but could not find any mention of this
> > behavior that double quotes should be removed only if string does not
> > contain a new line character.
>
> > 2) If the existing behavior is the correct behavior then could you
> > please add this test case which makes it explicitly clear that string
> > with new line character will have double quotes preserver.  Here is my
> > commit.
>
> >http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1...
>
> > Needless to say that test is passing with that commit.
>
> > Thanks
>
> > - Neeraj

Re: Double quotes are not preserved confirmation

[Andreas S.]

OK, so apparently this has been known for months, reported several
times, and a patch is available; would PLEASE someone put this in and
make a release?

Re: Double quotes are not preserved confirmation

[Filip Tepper]

On Jun 6, 1:16 pm, "Andreas S." <use...@andreas-s.net> wrote:

> OK, so apparently this has been known for months, reported several
> times, and a patch is available; would PLEASE someone put this in and
> make a release?

+1 for the release, please!

--
Filip Tepper

Re: Double quotes are not preserved confirmation

[Michael Fellinger]

On Fri, Jun 11, 2010 at 8:21 PM, Filip Tepper <filip@tepper.pl> wrote:
> On Jun 6, 1:16 pm, "Andreas S." <use...@andreas-s.net> wrote:
>
>> OK, so apparently this has been known for months, reported several
>> times, and a patch is available; would PLEASE someone put this in and
>> make a release?
>
> +1 for the release, please!

We'll try to get a release out this weekend.

-- 
Michael Fellinger
CTO, The Rubyists, LLC

Re: Double quotes are not preserved confirmation

[Jeremy Hinegardner]

On Sat, Jun 12, 2010 at 11:44:56AM +0900, Michael Fellinger wrote:
> On Fri, Jun 11, 2010 at 8:21 PM, Filip Tepper <filip@tepper.pl> wrote:
> > On Jun 6, 1:16??pm, "Andreas S." <use...@andreas-s.net> wrote:
> >
> >> OK, so apparently this has been known for months, reported several
> >> times, and a patch is available; would PLEASE someone put this in and
> >> make a release?
> >
> > +1 for the release, please!
> 
> We'll try to get a release out this weekend.

In this vein, can this commit(dae12e08) be cherry-picked to the rack-1.1 
branch and a rack-1.1.1 release be made?  The primary reason is that rails 
v2.3.8 has a "rack ~> 1.1.0" dependency.  Since this commit is applied in 
the rack 1.2 branch, it will not be installed on a rails 2.3.8 installation.

enjoy,

-jeremy

-- 
========================================================================
 Jeremy Hinegardner                              jeremy@hinegardner.org