Re: Double quotes are not preserved confirmation

[Neeraj Singh <neerajdotname@gmail.com>]

@Simon Thanks for the update.

I should have looked into the archive before asking the question.
Sorry about that.

Well it is an issue confirmed by some and there is already a patch.
Looks like someone has to pull the trigger and apply the patch.



On May 14, 7:32 pm, Simon Chiang <simon.a.chi...@gmail.com> wrote:
> Hi this issue has come up several times now.
>
> *http://groups.google.com/group/rack-devel/browse_thread/thread/befbad...
> *http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79...
>
> I think it is a bug.  I found the commit that introduced this
> behavior.  Looks like it was intentional but perhaps just a bad
> choice?  http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361a38...
>
> A patch that removes quote parsing and fixes the specs is here:http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46...
>
> On May 14, 9:58 am, Neeraj Singh <neerajdotn...@gmail.com> wrote:
>
>
>
> > I am working on this rails tickethttps://rails.lighthouseapp.com/projects/8994/tickets/4576
> > .
>
> > Then I found this test casehttp://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35
> > . As you can see if the data has double quotes then double quotes are
> > being removed.
>
> > However if the data has a new line character then double quotes are
> > preserved.
>
> > Questions:
>
> > 1) I looked at the rack spec but could not find any mention of this
> > behavior that double quotes should be removed only if string does not
> > contain a new line character.
>
> > 2) If the existing behavior is the correct behavior then could you
> > please add this test case which makes it explicitly clear that string
> > with new line character will have double quotes preserver.  Here is my
> > commit.
>
> >http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1...
>
> > Needless to say that test is passing with that commit.
>
> > Thanks
>
> > - Neeraj