From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.239.138.72 with SMTP id o8cs2869hbo; Fri, 14 May 2010 16:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of rack-devel+bncCKCqpoPSDBCju7ffBBoEng4syw@googlegroups.com designates 10.150.174.18 as permitted sender) client-ip=10.150.174.18; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCKCqpoPSDBCju7ffBBoEng4syw@googlegroups.com designates 10.150.174.18 as permitted sender) smtp.mail=rack-devel+bncCKCqpoPSDBCju7ffBBoEng4syw@googlegroups.com; dkim=pass header.i=rack-devel+bncCKCqpoPSDBCju7ffBBoEng4syw@googlegroups.com Received: from mr.google.com ([10.150.174.18]) by 10.150.174.18 with SMTP id w18mr1141485ybe.18.1273879972793 (num_hops = 1); Fri, 14 May 2010 16:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:received:date :in-reply-to:x-ip:references:user-agent:x-http-useragent:message-id :subject:from:to:x-original-authentication-results:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=rXlMAfjxqCuGQ2S/JekfHraZR+nbdRvtu0LFSq5qnSc=; b=s8LJd20lyk48x6IEHRt31wlXxP/OkJAJjKETTEuw1ML7qwWpZ4BxzJ6TAwYc3tk8X3 dwgqlxSux3O5YzBV9qV20Y9Bnv0l5WidzhKhVLM/wIVtbWYB/6pUIA43ZEr1Gps6oQBP bLyPGIh0UapHQJUOehET6+lRIsalv4QuFt9qw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:in-reply-to:x-ip :references:user-agent:x-http-useragent:message-id:subject:from:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; b=lNCMZ56d/fJ8pcMaElq+LrbUdNo5Y5Ek6p2I23SBgRLBOqcyDYNDaItrWOfv295ltE JhkYg2hinnjMvj8GBTWtYGu9kah1MHuy507VLikVCSjOK/bWKLDkCchJfuFUkxQ/z+6b xfewjq9aH+w+CuTb49bblL0jksrOTB6aCZKgk= Received: by 10.150.174.18 with SMTP id w18mr217733ybe.18.1273879971408; Fri, 14 May 2010 16:32:51 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.150.247.33 with SMTP id u33ls2618317ybh.4.p; Fri, 14 May 2010 16:32:50 -0700 (PDT) Received: by 10.150.120.12 with SMTP id s12mr877691ybc.28.1273879970281; Fri, 14 May 2010 16:32:50 -0700 (PDT) Received: by 10.150.120.12 with SMTP id s12mr877690ybc.28.1273879970264; Fri, 14 May 2010 16:32:50 -0700 (PDT) Return-Path: Received: from mail-gx0-f200.google.com (mail-gx0-f200.google.com [209.85.217.200]) by gmr-mx.google.com with ESMTP id 18si236770yxe.12.2010.05.14.16.32.50; Fri, 14 May 2010 16:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of simon.a.chiang@gmail.com designates 209.85.217.200 as permitted sender) client-ip=209.85.217.200; Received: by gxk24 with SMTP id 24so3627854gxk.18 for ; Fri, 14 May 2010 16:32:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.152.22 with SMTP id e22mr103663ano.60.1273879970198; Fri, 14 May 2010 16:32:50 -0700 (PDT) Received: by j36g2000prj.googlegroups.com with HTTP; Fri, 14 May 2010 16:32:50 -0700 (PDT) Date: Fri, 14 May 2010 16:32:50 -0700 (PDT) In-Reply-To: <2686b707-fe09-43ba-a757-4d879adbe44c@o1g2000vbe.googlegroups.com> X-IP: 63.227.24.4 References: <2686b707-fe09-43ba-a757-4d879adbe44c@o1g2000vbe.googlegroups.com> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3,gzip(gfe) Message-ID: <7c5a66d5-4db0-4057-9591-4423af6d9c6a@j36g2000prj.googlegroups.com> Subject: Re: Double quotes are not preserved confirmation From: Simon Chiang To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of simon.a.chiang@gmail.com designates 209.85.217.200 as permitted sender) smtp.mail=simon.a.chiang@gmail.com X-Original-Sender: simon.a.chiang@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi this issue has come up several times now. * http://groups.google.com/group/rack-devel/browse_thread/thread/befbad49b6= 409b45 * http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79e633= b9e086 I think it is a bug. I found the commit that introduced this behavior. Looks like it was intentional but perhaps just a bad choice? http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361= a3885bd88b42ca A patch that removes quote parsing and fixes the specs is here: http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46848e90= e21ba On May 14, 9:58=A0am, Neeraj Singh wrote: > I am working on this rails tickethttps://rails.lighthouseapp.com/projects= /8994/tickets/4576 > . > > Then I found this test casehttp://github.com/rack/rack/blob/master/test/s= pec_rack_utils.rb#L35 > . As you can see if the data has double quotes then double quotes are > being removed. > > However if the data has a new line character then double quotes are > preserved. > > Questions: > > 1) I looked at the rack spec but could not find any mention of this > behavior that double quotes should be removed only if string does not > contain a new line character. > > 2) If the existing behavior is the correct behavior then could you > please add this test case which makes it explicitly clear that string > with new line character will have double quotes preserver. =A0Here is my > commit. > > http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1... > > Needless to say that test is passing with that commit. > > Thanks > > - Neeraj