* Double quotes are not preserved confirmation @ 2010-05-14 15:58 Neeraj Singh 2010-05-14 23:32 ` Simon Chiang 0 siblings, 1 reply; 7+ messages in thread From: Neeraj Singh @ 2010-05-14 15:58 UTC (permalink / raw) To: Rack Development I am working on this rails ticket https://rails.lighthouseapp.com/projects/8994/tickets/4576 . Then I found this test case http://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35 . As you can see if the data has double quotes then double quotes are being removed. However if the data has a new line character then double quotes are preserved. Questions: 1) I looked at the rack spec but could not find any mention of this behavior that double quotes should be removed only if string does not contain a new line character. 2) If the existing behavior is the correct behavior then could you please add this test case which makes it explicitly clear that string with new line character will have double quotes preserver. Here is my commit. http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1077aad08fc4b59a Needless to say that test is passing with that commit. Thanks - Neeraj ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-05-14 15:58 Double quotes are not preserved confirmation Neeraj Singh @ 2010-05-14 23:32 ` Simon Chiang 2010-05-15 1:25 ` Neeraj Singh 0 siblings, 1 reply; 7+ messages in thread From: Simon Chiang @ 2010-05-14 23:32 UTC (permalink / raw) To: Rack Development Hi this issue has come up several times now. * http://groups.google.com/group/rack-devel/browse_thread/thread/befbad49b6409b45 * http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79e633b9e086 I think it is a bug. I found the commit that introduced this behavior. Looks like it was intentional but perhaps just a bad choice? http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361a3885bd88b42ca A patch that removes quote parsing and fixes the specs is here: http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46848e90e21ba On May 14, 9:58 am, Neeraj Singh <neerajdotn...@gmail.com> wrote: > I am working on this rails tickethttps://rails.lighthouseapp.com/projects/8994/tickets/4576 > . > > Then I found this test casehttp://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35 > . As you can see if the data has double quotes then double quotes are > being removed. > > However if the data has a new line character then double quotes are > preserved. > > Questions: > > 1) I looked at the rack spec but could not find any mention of this > behavior that double quotes should be removed only if string does not > contain a new line character. > > 2) If the existing behavior is the correct behavior then could you > please add this test case which makes it explicitly clear that string > with new line character will have double quotes preserver. Here is my > commit. > > http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1... > > Needless to say that test is passing with that commit. > > Thanks > > - Neeraj ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-05-14 23:32 ` Simon Chiang @ 2010-05-15 1:25 ` Neeraj Singh 2010-06-06 11:16 ` Andreas S. 0 siblings, 1 reply; 7+ messages in thread From: Neeraj Singh @ 2010-05-15 1:25 UTC (permalink / raw) To: Rack Development @Simon Thanks for the update. I should have looked into the archive before asking the question. Sorry about that. Well it is an issue confirmed by some and there is already a patch. Looks like someone has to pull the trigger and apply the patch. On May 14, 7:32 pm, Simon Chiang <simon.a.chi...@gmail.com> wrote: > Hi this issue has come up several times now. > > *http://groups.google.com/group/rack-devel/browse_thread/thread/befbad... > *http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79... > > I think it is a bug. I found the commit that introduced this > behavior. Looks like it was intentional but perhaps just a bad > choice? http://github.com/bahuvrihi/rack/commit/fb4f2b5fe26a0e3821ac0f6361a38... > > A patch that removes quote parsing and fixes the specs is here:http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46... > > On May 14, 9:58 am, Neeraj Singh <neerajdotn...@gmail.com> wrote: > > > > > I am working on this rails tickethttps://rails.lighthouseapp.com/projects/8994/tickets/4576 > > . > > > Then I found this test casehttp://github.com/rack/rack/blob/master/test/spec_rack_utils.rb#L35 > > . As you can see if the data has double quotes then double quotes are > > being removed. > > > However if the data has a new line character then double quotes are > > preserved. > > > Questions: > > > 1) I looked at the rack spec but could not find any mention of this > > behavior that double quotes should be removed only if string does not > > contain a new line character. > > > 2) If the existing behavior is the correct behavior then could you > > please add this test case which makes it explicitly clear that string > > with new line character will have double quotes preserver. Here is my > > commit. > > >http://github.com/neerajdotname/rack/commit/1454a2171032e2260dc7199f1... > > > Needless to say that test is passing with that commit. > > > Thanks > > > - Neeraj ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-05-15 1:25 ` Neeraj Singh @ 2010-06-06 11:16 ` Andreas S. 2010-06-11 11:21 ` Filip Tepper 0 siblings, 1 reply; 7+ messages in thread From: Andreas S. @ 2010-06-06 11:16 UTC (permalink / raw) To: Rack Development OK, so apparently this has been known for months, reported several times, and a patch is available; would PLEASE someone put this in and make a release? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-06-06 11:16 ` Andreas S. @ 2010-06-11 11:21 ` Filip Tepper 2010-06-12 2:44 ` Michael Fellinger 0 siblings, 1 reply; 7+ messages in thread From: Filip Tepper @ 2010-06-11 11:21 UTC (permalink / raw) To: Rack Development On Jun 6, 1:16 pm, "Andreas S." <use...@andreas-s.net> wrote: > OK, so apparently this has been known for months, reported several > times, and a patch is available; would PLEASE someone put this in and > make a release? +1 for the release, please! -- Filip Tepper ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-06-11 11:21 ` Filip Tepper @ 2010-06-12 2:44 ` Michael Fellinger 2010-06-30 23:34 ` Jeremy Hinegardner 0 siblings, 1 reply; 7+ messages in thread From: Michael Fellinger @ 2010-06-12 2:44 UTC (permalink / raw) To: rack-devel On Fri, Jun 11, 2010 at 8:21 PM, Filip Tepper <filip@tepper.pl> wrote: > On Jun 6, 1:16 pm, "Andreas S." <use...@andreas-s.net> wrote: > >> OK, so apparently this has been known for months, reported several >> times, and a patch is available; would PLEASE someone put this in and >> make a release? > > +1 for the release, please! We'll try to get a release out this weekend. -- Michael Fellinger CTO, The Rubyists, LLC ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Double quotes are not preserved confirmation 2010-06-12 2:44 ` Michael Fellinger @ 2010-06-30 23:34 ` Jeremy Hinegardner 0 siblings, 0 replies; 7+ messages in thread From: Jeremy Hinegardner @ 2010-06-30 23:34 UTC (permalink / raw) To: rack-devel On Sat, Jun 12, 2010 at 11:44:56AM +0900, Michael Fellinger wrote: > On Fri, Jun 11, 2010 at 8:21 PM, Filip Tepper <filip@tepper.pl> wrote: > > On Jun 6, 1:16??pm, "Andreas S." <use...@andreas-s.net> wrote: > > > >> OK, so apparently this has been known for months, reported several > >> times, and a patch is available; would PLEASE someone put this in and > >> make a release? > > > > +1 for the release, please! > > We'll try to get a release out this weekend. In this vein, can this commit(dae12e08) be cherry-picked to the rack-1.1 branch and a rack-1.1.1 release be made? The primary reason is that rails v2.3.8 has a "rack ~> 1.1.0" dependency. Since this commit is applied in the rack 1.2 branch, it will not be installed on a rails 2.3.8 installation. enjoy, -jeremy -- ======================================================================== Jeremy Hinegardner jeremy@hinegardner.org ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-06-30 23:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-05-14 15:58 Double quotes are not preserved confirmation Neeraj Singh 2010-05-14 23:32 ` Simon Chiang 2010-05-15 1:25 ` Neeraj Singh 2010-06-06 11:16 ` Andreas S. 2010-06-11 11:21 ` Filip Tepper 2010-06-12 2:44 ` Michael Fellinger 2010-06-30 23:34 ` Jeremy Hinegardner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).