unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/3] linux: Fix time64 support for futimesat
@ 2020-10-15 13:06 Adhemerval Zanella via Libc-alpha
  2020-10-15 13:06 ` [PATCH 2/3] Move ftime to a compatibility symbol Adhemerval Zanella via Libc-alpha
                   ` (2 more replies)
  0 siblings, 3 replies; 24+ messages in thread
From: Adhemerval Zanella via Libc-alpha @ 2020-10-15 13:06 UTC (permalink / raw)
  To: libc-alpha

The generic implementation does not support time64 and the default
one return overflow for invalid tv_sec with UTIME_NOW / UTIME_OMIT
(which is valid since tv_sec in such cases is ignored by the
kernel).

Checked on x86_64-linux-gnu and i686-linux-gnu (on 5.4 and on 4.15
kernel).
---
 sysdeps/unix/sysv/linux/generic/futimesat.c | 52 ---------------------
 sysdeps/unix/sysv/linux/utimensat.c         |  8 +++-
 2 files changed, 6 insertions(+), 54 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/generic/futimesat.c

diff --git a/sysdeps/unix/sysv/linux/generic/futimesat.c b/sysdeps/unix/sysv/linux/generic/futimesat.c
deleted file mode 100644
index 7be1fbc252..0000000000
--- a/sysdeps/unix/sysv/linux/generic/futimesat.c
+++ /dev/null
@@ -1,52 +0,0 @@
-/* futimesat -- Change access and modification times of file.  Linux version.
-   Copyright (C) 2005-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <fcntl.h>
-#include <stddef.h>
-#include <stdio.h>
-#include <string.h>
-#include <utime.h>
-#include <sys/time.h>
-#include <sysdep.h>
-
-
-/* Change the access time of FILE relative to FD to TVP[0] and
-   the modification time of FILE to TVP[1].  */
-int
-futimesat (int fd, const char *file, const struct timeval tvp[2])
-{
-  struct timespec tsp[2];
-  int result;
-
-  if (tvp)
-    {
-      if (tvp[0].tv_usec >= 1000000 || tvp[0].tv_usec < 0
-          || tvp[1].tv_usec >= 1000000 || tvp[1].tv_usec < 0)
-        {
-          __set_errno (EINVAL);
-          return -1;
-        }
-      TIMEVAL_TO_TIMESPEC (&tvp[0], &tsp[0]);
-      TIMEVAL_TO_TIMESPEC (&tvp[1], &tsp[1]);
-    }
-
-  result = INLINE_SYSCALL (utimensat, 4, fd, file, tvp ? tsp : NULL, 0);
-  return result;
-}
diff --git a/sysdeps/unix/sysv/linux/utimensat.c b/sysdeps/unix/sysv/linux/utimensat.c
index ea23c2f051..72784d824a 100644
--- a/sysdeps/unix/sysv/linux/utimensat.c
+++ b/sysdeps/unix/sysv/linux/utimensat.c
@@ -36,9 +36,13 @@ __utimensat64_helper (int fd, const char *file,
   if (ret == 0 || errno != ENOSYS)
     return ret;
 
+  /* For UTIME_NOW and UTIME_OMIT the value of tv_sec field is ignored.  */
+# define NS_VALID(ns) \
+  ((((ns).tv_nsec == UTIME_NOW || (ns).tv_nsec == UTIME_OMIT) \
+   || in_time_t_range ((ns).tv_sec)))
+
   if (tsp64 != NULL
-      && (! in_time_t_range (tsp64[0].tv_sec)
-          || ! in_time_t_range (tsp64[1].tv_sec)))
+      && (!NS_VALID (tsp64[0]) || !NS_VALID (tsp64[1])))
     {
       __set_errno (EOVERFLOW);
       return -1;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-10-19 17:56 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 13:06 [PATCH 1/3] linux: Fix time64 support for futimesat Adhemerval Zanella via Libc-alpha
2020-10-15 13:06 ` [PATCH 2/3] Move ftime to a compatibility symbol Adhemerval Zanella via Libc-alpha
2020-10-16  9:05   ` Lukasz Majewski
2020-10-16 18:18   ` [COMMITTED] Add NEWS entry for ftime compatibility move Adhemerval Zanella via Libc-alpha
2020-10-19  7:55   ` [PATCH 2/3] Move ftime to a compatibility symbol Szabolcs Nagy via Libc-alpha
2020-10-19  8:17     ` Andreas Schwab
2020-10-19  8:30     ` Florian Weimer via Libc-alpha
2020-10-19  9:18       ` Tamar Christina via Libc-alpha
2020-10-19  9:51         ` Florian Weimer via Libc-alpha
2020-10-19 10:20           ` Tamar Christina via Libc-alpha
2020-10-19 10:46             ` Florian Weimer via Libc-alpha
2020-10-19 10:49   ` Florian Weimer via Libc-alpha
2020-10-19 11:56     ` Andreas Schwab
2020-10-19 11:58       ` Florian Weimer via Libc-alpha
2020-10-19 12:30         ` Adhemerval Zanella via Libc-alpha
2020-10-19 12:31           ` Adhemerval Zanella via Libc-alpha
2020-10-19 17:56     ` Joseph Myers
2020-10-15 13:06 ` [PATCH 3/3] linux: Add 64-bit time_t support for wait3 Adhemerval Zanella via Libc-alpha
2020-10-15 14:43   ` Alistair Francis via Libc-alpha
2020-10-16  9:14   ` Lukasz Majewski
2020-10-16 17:02     ` Adhemerval Zanella via Libc-alpha
2020-10-18 19:55       ` Lukasz Majewski
2020-10-16  8:41 ` [PATCH 1/3] linux: Fix time64 support for futimesat Lukasz Majewski
2020-10-16 14:20   ` Adhemerval Zanella via Libc-alpha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).