From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7A49B1F4B4 for ; Mon, 19 Oct 2020 08:30:51 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 53AAF385482F; Mon, 19 Oct 2020 08:30:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53AAF385482F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603096250; bh=HESSCwOoxLBTjOIz8XiHxwVi96ACmUDi1HRyyQCd33g=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BVIVrBc4lBs15YNwVoyf9W5TmRffLcLEZ2t4tLleEtHlCZuTkAUHIV++mMHbyb1qX gotXQNE7Yf6yahvEkrlC9Q1l1y3RL1rRf/VptGQ50EQ+N7tTf9rPF5RJHzY0bb6niO sj+spVgls8ouU5kUzmx+r2+y8zqyPZzmqF3X8Vpw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id B73663858020 for ; Mon, 19 Oct 2020 08:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B73663858020 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-Rk7r3yqGOyWpPsjSi6j65Q-1; Mon, 19 Oct 2020 04:30:43 -0400 X-MC-Unique: Rk7r3yqGOyWpPsjSi6j65Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66CC885EE94; Mon, 19 Oct 2020 08:30:42 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-203.ams2.redhat.com [10.36.112.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AEAF1A837; Mon, 19 Oct 2020 08:30:41 +0000 (UTC) To: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH 2/3] Move ftime to a compatibility symbol References: <20201015130632.90961-1-adhemerval.zanella@linaro.org> <20201015130632.90961-2-adhemerval.zanella@linaro.org> <20201019075518.GJ3819@arm.com> Date: Mon, 19 Oct 2020 10:30:39 +0200 In-Reply-To: <20201019075518.GJ3819@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Mon, 19 Oct 2020 08:55:19 +0100") Message-ID: <874kmqd3dc.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Szabolcs Nagy via Libc-alpha: > The 10/15/2020 10:06, Adhemerval Zanella via Libc-alpha wrote: >> It was made deprecated on 2.31, so it moves to compat symbol after >> two releases. It was also removed from exported symbol for riscv32 >> (since ABI will be supported on for 2.33). >> >> Checked on x86_64-linux-gnu and i686-linux-gnu. >> --- >> include/sys/timeb.h | 1 - >> .../unix/sysv/linux/riscv/rv32/libc.abilist | 1 - >> time/Makefile | 5 +- >> time/ftime.c | 19 +++++- >> time/sys/timeb.h | 44 -------------- >> time/tst-ftime.c | 59 ++++++++++--------- >> 6 files changed, 50 insertions(+), 79 deletions(-) >> delete mode 100644 include/sys/timeb.h >> delete mode 100644 time/sys/timeb.h > > removing sys/timeb.h and ftime breaks several > spec2006 and spec2017 benchmarks. > > which means this header is used in practice, > sometimes without configure checks. > > is there a reason it cannot be supported? I think we should minimize the number of time-related symbols, in case we ever want to provide a dual ABI (with multiple time_t sizes). SPEC isn't going to change, so I don't think it makes sense to wait for it getting fixed. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill