On 16/10/2020 05:41, Lukasz Majewski wrote:
> Hi Adhemerval,

>> diff --git a/sysdeps/unix/sysv/linux/utimensat.c
>> b/sysdeps/unix/sysv/linux/utimensat.c index ea23c2f051..72784d824a
>> 100644 --- a/sysdeps/unix/sysv/linux/utimensat.c
>> +++ b/sysdeps/unix/sysv/linux/utimensat.c
>> @@ -36,9 +36,13 @@ __utimensat64_helper (int fd, const char *file,
>>    if (ret == 0 || errno != ENOSYS)
>>      return ret;
>>  
>> +  /* For UTIME_NOW and UTIME_OMIT the value of tv_sec field is
>> ignored.  */ +# define NS_VALID(ns) \
>> +  ((((ns).tv_nsec == UTIME_NOW || (ns).tv_nsec == UTIME_OMIT) \
>> +   || in_time_t_range ((ns).tv_sec)))
> 
> IMHO, this is a bit misleading. The macro NS_VALID() seems to be
> supposed to check the nano seconds value,but it also check if tv_sec is
> in time_t range.
> 
> Maybe we can change its name (and passed argument) to e.g.
> #define TS_VALID(ts) ...

Fair enough, I changed to to TS_VALID.

> 
> Despite this minor comment:
> 
> Reviewed-by: Lukasz Majewski <lukma@denx.de>

Ack.